Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWLhX-0001aF-QA for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 14:06:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hWLhU-00045P-Tj for pgadmin-hackers@arkaria.postgresql.org; Thu, 30 May 2019 14:06:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWLhU-00045H-7C for pgadmin-hackers@lists.postgresql.org; Thu, 30 May 2019 14:06:36 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWLhP-0006io-QG for pgadmin-hackers@postgresql.org; Thu, 30 May 2019 14:06:34 +0000 Received: by mail-it1-x144.google.com with SMTP id m141so10067173ita.3 for ; Thu, 30 May 2019 07:06:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hiqL8EEpVIONeJW8n5A4KMo6Frf7wwnZjgj2krXzVv4=; b=YiIzrSmvMek+4pM42AyAjhXRP9xUnNwPEMEP8KsBewudM2Iyr3f91gwTEa3lk4szYk mnCrHwe9fJLB/wCt1o6eC0Xoj4ClbTmA12Oi+dsxopnCBCp7AlPtm38xTIzjKbBWFTbz t51xFqVX8uXdADJehs9mAiWCYQwYOLTq2JEEv2C7HXEAgOs/ECZPM6DONZxwHnnAcfge zAIHle8crnXAveeCEwXue1cmjV20rCDrxgRqNSFXn9t9ZY8Kq5NDMGL7DUCxfOXsMQ9E d7OgTJB79OiJm14CgG/gHYC8vTBKBJUyAazUVMKj60PhoiR7lq+eiMFK3r5VKXwXicOO 5Kzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hiqL8EEpVIONeJW8n5A4KMo6Frf7wwnZjgj2krXzVv4=; b=diFFy+KPb7yH87cIhrXYNowFTvSXsXZ34Ds6yH/EDCMV0UBGfsomV5MB5UKvcaMHGz wFTAv9VmSwRsPq8O+8ajl1GvkMkZVEQvOnQAjLrMm4edxrl3mdOISm0CTC1aTkqsETTk lT3hbuot6C3/3/+Bkg8A2fFfnOxG1JCK2y3pH4oRDZudfE8l1kst7iEu/UJ1ZQBOLnaJ 5lH45Z9nN3TcTC4fbSzxODYzz//Fs7BLq179rHeRYJgKyxOQ7P+oqr44irr6pYVYGLra XVDzfMNqs4Jb8OFBEMoZOQTChlSnQ0eXIFSY+N6lLpl+84qp6tWOiHNLrJkxHX28h3FI 8lDg== X-Gm-Message-State: APjAAAX8Sjdi5F6x1ycD5LZfDOU31TIKOmZr6wg1PIrl+0c6OsRm6cM/ xZ1lpDwJYtXpfNdV60cddIjEiOkHzvYuxwb86YGUcQ== X-Google-Smtp-Source: APXvYqytANA+xKJV/93JweYiwsCNnolF57Jr0g/VZ5QcELCTrNcnBr+iUhUyM/MvjR7Z9+D6p0jNEP5TZmYwDCsCcro= X-Received: by 2002:a02:9143:: with SMTP id b3mr2409692jag.12.1559225190784; Thu, 30 May 2019 07:06:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 30 May 2019 10:06:17 -0400 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009f487c058a1b67de" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009f487c058a1b67de Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: > >> Hi >> >> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: >>> >>>> Hi, >>>> >>>> On further testing, this doesn't seem to be working as expected. >>>> Alt+Shift+] or [ in the query tool are typing =E2=80=99 and =E2=80=9D = and not changing the >>>> tab. If I switch to a non-input tab (e.g. History), they still don't w= ork. >>>> >>> I am not able to simulate the quotes problem, but I have made a few >>> corrections to fix the switching. >>> Attached is the updated patch, kindly review. >>> >> >> Alt+Shift+[ (or ]) don[t work at all for me now :-( >> > Did you restart the server after applying the patch ? What shortcut does > preferences show ? > Yes, did that, rebuilt the bundle and hard-reloaded the browser, all multiple times. The shortcut preferences show the expected keys. > >> >>> >>>> Alt+Shift+Tab changes the panel successfully though, and does cause th= e >>>> flash as expected. >>>> >>>> I'm using Chrome 74.0.3729.131 on Mojave. >>>> >>>> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Attached is the updated patch with doc changes. >>>>> >>>>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On Tue, May 21, 2019 at 5:32 PM Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> Attached is the patch to fix the accessibility issue in query tool= . >>>>>>>> >>>>>>>> The query tool can be completely restructured unlike previously >>>>>>>> where query tool used to stick at top and other tabs in the bottom= . >>>>>>>> - I have added a new shortcut to switch between frames if in query >>>>>>>> tool the tab positions are changed. On switching the frames, the f= rame will >>>>>>>> blink to show it is focussed. >>>>>>>> - In the frame, you can switch tab same as previous. The tabs in >>>>>>>> SQL editor are cyclic now, which means if you execute shortcut to = go right >>>>>>>> on the last tab then it will cycle to first tab. >>>>>>>> - I have also changed the default shortcut to switch between tabs >>>>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what we= have in >>>>>>>> browser tabs. >>>>>>>> - Similar changes done for debugger also. >>>>>>>> >>>>>>> >>>>>>> Shouldn't there be documentation changes to go with this? >>>>>>> >>>>>> Yes, definitely :P >>>>>> Will send the updated patch. >>>>>> >>>>>>> >>>>>>> Otherwise, it seems to work :-) >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000009f487c058a1b67de Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, May 30, 2019 at 4:40 AM Aditya = Toshniwal <aditya.t= oshniwal@enterprisedb.com> wrote:
Hi,=C2=A0

On Thu, May 30, 2019 at 1:38 A= M Dave Page <dpag= e@pgadmin.org> wrote:
Hi

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, May 28, 2019 at 3:41 AM Aditya= Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Thu, May 23, = 2019 at 1:31 PM Dave Page <dpage@pgadmin.org> wrote:
Hi,

On further testing, this doesn't seem to be= working as expected. Alt+Shift+] or [ in the query tool are typing=C2=A0= =E2=80=99 and =E2=80=9D and not changing the tab. If I switch to a non-inpu= t tab (e.g. History), they still don't work.=C2=A0
I am not able to simulate the quotes problem, but I have m= ade a few corrections to fix the switching.
Attached is the up= dated patch, kindly review.=C2=A0

Alt+Shift+[ (or ]) don[t work at all for me now :-(
Did you restart the server after applying the patch= ?=C2=A0 What shortcut does preferences show ?=C2=A0

Yes, did that, rebuilt the bundle and ha= rd-reloaded the browser, all multiple times.

The s= hortcut preferences show the expected keys.
=C2=A0
=C2=A0
<= div dir=3D"ltr">

Alt+Shift+Tab changes the panel success= fully though, and does cause the flash as expected.=C2=A0

I'm using Chrome=C2=A074.0.3729.131 on Mojave.

On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <aditya.toshniwal@enterpri= sedb.com> wrote:
Hi,<= /div>

Attached is the updated patch with doc chan= ges.

On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <aditya.toshniwal= @enterprisedb.com> wrote:
Hi,

On Tue, May 21, 2019 at 5:32 PM Dave Page &l= t;dpage@pgadmin.org<= /a>> wrote:
<= div dir=3D"ltr">
Hi

On Tue, May 21, 2019 at 10:01 AM Aditya = Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the accessibility issue in= query tool.

<= div style=3D"font-family:verdana,sans-serif">The query tool can be complete= ly restructured unlike previously where query tool used to stick at top and= other tabs in the bottom.=C2=A0
- I have added a new shortcut to switch between frames if in query= tool the tab positions are changed. On switching the frames, the frame wil= l blink to show it is focussed.=C2=A0
- In the frame, you can switch tab same as previous. The tabs= in SQL editor are cyclic now, which means if you execute shortcut to go ri= ght on the last tab then it will cycle to first tab.
- I have also changed the default shortcut to = switch between tabs from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar= to what we have in browser tabs.
- Similar changes done for debugger also.

Shouldn't there be documentation changes to go wit= h this?=C2=A0
Yes, definitely :P
Will send the updated patch.=C2=A0
Otherwise, it seems to work :-)

-- <= br>
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't= Complain about Heat, Plant a TREE"


--
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Thanks and R= egards,
Aditya Toshniwal<= /font>
Softwa= re Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Com= plain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000009f487c058a1b67de--