Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bkRip-000760-Tb for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 08:08:40 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bkRip-0005lq-G5 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Sep 2016 08:08:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bkRic-0005XB-I8 for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 08:08:26 +0000 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bkRiX-0004Z5-Vk for pgadmin-hackers@postgresql.org; Thu, 15 Sep 2016 08:08:25 +0000 Received: by mail-it0-x236.google.com with SMTP id 15so2514636ita.1 for ; Thu, 15 Sep 2016 01:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ICkYsr3ZSA2L561XHpElwD01ybn75BU6C1y3R+Ek5cA=; b=sUeP84LCmRqrKRLHE+2W5ycS/F5dqjFvRuXfmuTOP2SnvpnGHn515St5TcP6pGCY2s C02ckiEbSZtNNthX2rRVMTi57pH9MT/ZV1G4/NNRHzUjwJ2ajIpZ2QX9ALQd/Mz2zO8F 1Do6hf1iOUcZtg5SGzmbNopKmFZpZlzfqVxDd5x6Ao9WIJeaOfmlS6il5sNW2BfZzTLG rx68z68gZYQGXQYRSBSKWBVFJvC0Sb6A9KSzijX2BiANMAdWoP/nN6+MC2e/kP95Me61 sLUIAERZIrk+LW5NO0hs0aXbzlCw2jozF+DU8adTTdL7GmJnYXlXLq15g5i3fDYD/wn2 399g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ICkYsr3ZSA2L561XHpElwD01ybn75BU6C1y3R+Ek5cA=; b=R/32RClex0iA3vAHtmdcOlnMyOb2OHMQCT/7+gwS2tVqyJDRnTWpGsj/utYkJXG/BO Xy9VjlTnumxXR7CYOlKuwBFuNDbrRCz/PucwGsWUmt+cPZEwebAGOMsqYctbtPLd2Zns kuVpbcbXJP9nBGBw9LuYyvUN0x5Afcb9SXZ1auBYj/aCQpnoLOGW/DUvMRPv4KbRxch7 gdDPlnheOLhagFtOLTjr/EcmzqhBccFT8EUryDehZuIP9djoa3wzodwiiGTKWlYzXaO2 7E/MCJs6M2lXmusgV/JYG7BsnpV+8Mi51XRV/b/zcX0hb36+Symwr8tqxVal9J/Tiw/r fpiQ== X-Gm-Message-State: AE9vXwN35tV5eZ8tjNBwv+ydgLBAXgkk0yqjHJ0A4GPRU0E2lz7W983EAYCjJ1YyF4o6pzb3vwdsPGwfTacJyQ== X-Received: by 10.107.137.68 with SMTP id l65mr14492524iod.70.1473926900324; Thu, 15 Sep 2016 01:08:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Thu, 15 Sep 2016 01:08:19 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 15 Sep 2016 09:08:19 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1579 - Unable to scroll the query text window during selection To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org (pgadmin4)piranha:pgadmin4 dpage$ git apply ~/Downloads/RM1579.patch error: patch failed: web/pgadmin/static/css/overrides.css:53 error: web/pgadmin/static/css/overrides.css: patch does not apply Please rebase! On Thu, Sep 15, 2016 at 8:54 AM, Surinder Kumar wrote: > Hi > > Please find the attached patch patch with following changes: > > 1) Implemented CodeMirror addon 'simplescrollbars'. > > 2) The CodeMirror instance of query tool was not rendering into wcDocker's > 'pg-panel-content' div. it renders outside the div, due to which it took > little more time investigating why scrollbars doesn't appear in editor. > > 3) Add new css specific to query tool. > > > Please review. > > Thanks, > Surinder Kumar > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers