MIME-Version: 1.0
References: 
 <CAKtn9dP2TmBCqHxV0szjdmCEVLbJwBNXA6rsumoOKeQJG1qyUw@mail.gmail.com>
In-Reply-To: 
 <CAKtn9dP2TmBCqHxV0szjdmCEVLbJwBNXA6rsumoOKeQJG1qyUw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 28 Jun 2021 17:03:28 +0100
Message-ID: 
 <CA+OCxoxE+OK3_KW_vu_pWY4+t5qyH985_Znp7v+uA2vmYRo2BQ@mail.gmail.com>
Subject: Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure
To: Rahul Shirsat <rahul.shirsat@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000f7536205c5d5a140"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoxE%2BOK3_KW_vu_pWY4%2Bt5qyH985_Znp7v%2BuA2vmYRo2BQ%40mail.gmail.com>
Precedence: bulk

--000000000000f7536205c5d5a140
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat <
rahul.shirsat@enterprisedb.com> wrote:

> Hi Hackers,
>
> Please find the attached patch for fixation of jenkins failure.
>

That won't work - you can't include variables (or string building
operations) in the first argument to gettext calls, as there won't be any
way to extract a complete message into the catalogs. The way it's being
done at the moment is correct (I don't know why it's failing, but it's the
correct way to structure the gettext calls).

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--000000000000f7536205c5d5a140
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Mon, Jun 28, 2021 at 4:57 PM Rahul Shirsat &lt;<=
a href=3D"mailto:rahul.shirsat@enterprisedb.com">rahul.shirsat@enterprisedb=
.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"mar=
gin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-=
left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<=
div><br></div><div>Please find the attached patch for fixation of jenkins f=
ailure.</div></div></blockquote><div><br></div><div>That won&#39;t work - y=
ou can&#39;t include variables (or string building operations) in the first=
 argument=C2=A0to gettext calls, as there won&#39;t be any way to extract a=
 complete message into the catalogs. The way it&#39;s being done at the mom=
ent is correct (I don&#39;t know why it&#39;s failing, but it&#39;s the cor=
rect way to structure the gettext calls).</div><div>=C2=A0</div></div>-- <b=
r><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Page<br>=
Blog: <a href=3D"https://pgsnake.blogspot.com" target=3D"_blank">https://pg=
snake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"https://=
www.enterprisedb.com" target=3D"_blank">https://www.enterprisedb.com</a><br=
><br></div></div></div>

--000000000000f7536205c5d5a140--