MIME-Version: 1.0
In-Reply-To: 
 <CANhDX=YhqQtmDRo8Gb0Wrmg05bGwX690zpZxH4-F-DbCvbrXog@mail.gmail.com>
References: 
 <CANhDX=a8ZJUvWTDbx7eCc2bqe9i6xkZKTcRyPXpb6p3uEGaWyg@mail.gmail.com>
 <CAAeC-SsGLG7_9mAsZpCZjX3TrQr_C+su3erM+vvsi=KkfatfKg@mail.gmail.com>
 <CANhDX=b91i+xq1z9YWyXvGAhfHAD4gwG1QOAx3sJ7xv+p0PijQ@mail.gmail.com>
 <CANhDX=bE9Wx6D2jNzDcFrMGvMiRTHfW9Svup6SAxzV2Pb=BdvQ@mail.gmail.com>
 <CAECtzeXhbbCG7XPgeRpMKrnpRxJO6HsnE9v=vgxEb+ndFps7AQ@mail.gmail.com>
 <CA+OCxowUQ=B3kCyKfOFiiMSkLhj+oz5os=fs=0ihEqvv4r+UZw@mail.gmail.com>
 <CANhDX=YhqQtmDRo8Gb0Wrmg05bGwX690zpZxH4-F-DbCvbrXog@mail.gmail.com>
Date: Thu, 7 Jan 2016 11:10:12 +0000
Message-ID: 
 <CA+OCxoxERDMQq_0AN9-B=eGTV=T+B=JvjkNzJgaRttOvxi4SBg@mail.gmail.com>
Subject: Re: ]GTK 3
From: Dave Page <dpage@pgadmin.org>
To: =?UTF-8?Q?Bj=C3=B6rn_Harrtell?= <bjorn@wololo.org>
Cc: Guillaume Lelarge <guillaume@lelarge.info>,
 pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

On Thu, Jan 7, 2016 at 7:47 AM, Bj=C3=B6rn Harrtell <bjorn.harrtell@gmail.c=
om> wrote:
> Yes, sorry, I made both the comments and the patch too hastily and agree
> that it should not be removed based on my findings.
>
> It should be noted though that wx3 or GTK3 by themselves is not to blame
> here, I'm guessing it should affect wx2 and GTK2 too because it's more of=
 a
> logical problem in where a user created the server node in a light theme
> which will save a white color for the background... then if the user
> switches to a dark theme, the saved white color is problematic.

Well the same applies in a more default theme if you use a dark
background. I guess the answer is to say "don't do that then" - I'd
certainly prefer not to have pgAdmin try to second guess what colours
might work against whatever the theme has for the current text colour.

> I noticed work on pgadmin4 too and while interesting, I want to see pgadm=
in3
> shine on linux desktops in the life it has left which might be quite some
> time (?). I see several distinct areas of work that I'd like to contribute
> efforts with:
>
> 1. Upgrade to latest stable wx

That should be largely done, at least as far as compilation/linking is
concerned. As far as I know the only outstanding issue is with
resource generation when creating a Mac package.

> 2. Compile with GTK+ 3.x as default on Linux (not sure it's ready for thi=
s,
> needs research and collaboration with dist packaging)

OK.

> 3. Evaluate which controls that can/need replacement (i.e replace with
> wxTreeListCtrl, wxDataViewCtrl and perhaps wxToolBar)

I think we'd want compelling reasons to use different controls with
wx3 - and they'd need to be compelling enough to warrant additional
code complexity that would be added to continue to support wx2.

> 4. Refactor existing code to use the controls that pass evaulation
>
> Feedback and guidance on how to proceed is much appreciated!

Propose changes here, and justify why they're needed essentially. If
consensus is that a change is warranted, then work can start on a
patch.

Please do bear in mind though that I have something like 10 people
working almost exclusively on pgAdmin 4 right now, pushing us to an
alpha state by the end of Q1 - and whilst I expect pgAdmin 3 to be
around for a while yet, my, and my teams focus will be primarily on
that work.

--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers