Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAbi2-0004oI-53 for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Jun 2016 11:31:42 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bAbi1-00049g-Hi for pgadmin-hackers@arkaria.postgresql.org; Wed, 08 Jun 2016 11:31:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bAbi0-00049Y-Ua for pgadmin-hackers@postgresql.org; Wed, 08 Jun 2016 11:31:41 +0000 Received: from mail-it0-x236.google.com ([2607:f8b0:4001:c0b::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bAbhs-0007iw-Se for pgadmin-hackers@postgresql.org; Wed, 08 Jun 2016 11:31:39 +0000 Received: by mail-it0-x236.google.com with SMTP id z123so5995019itg.0 for ; Wed, 08 Jun 2016 04:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TX/wzTW5PKlX3D0/g/ndg7dWguWNeD2xR7NpxbTBKxU=; b=jWpzuynw7XKXIqvc5Bef8TWgkhhSoJ5CUMhv5/nfImAg8nfthffpRdLszNtVcP3+47 O1WDQIXxjGCdtt2TfAS5E2RodEtOiAuFOzrHo+qr2OpwhT6fwGii5qS7GCyGnXNjlNy5 B3tc6Qg6q6SQGzNJn4Zbnd2iwgYlbblEVakyQXSjREDajhg7o9mllRJZqgtGJxOgMgyZ fkn3fIqboK38YQPYt4PGMQuNhCVKpEf3jDZFuegkkr1XBlAKV2cSuLWK1eEyCFPwf0To HvmJ0qIzLsyTGsO075jOCJ3WVZkvtXHUUYh0eYKICRFwrY8mAf4+hn9SWJvkNE8GqZ1R IrQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TX/wzTW5PKlX3D0/g/ndg7dWguWNeD2xR7NpxbTBKxU=; b=QrqCoEsMxhWlrHaU+PQ1xRW2UgBcAj3Olqgh+HJAX9kDL1/ZXX5IPysiR1tNFJ3gDt aQQbQLSFI2fI27QvqpFfdl/0MntJ4UgYyiJtKd0cFT00UaN4jUqPVE8drgBFJf21DS0b PefxfA8qYTMABZZrl6N9UnpoUdOALnd34/+NYdRJMZBJSIBuByNlDyZnoefQv0fBUtr4 9SyR/4tGgUaXyGnpliAGi8rkQgsfKEHdtL71zpu5t6fH4CFXaGOIAxQPz2sDftWPmIn4 yGMEZnM6D7aQ0XmKQ6fMyNERC/dyEe0JqG1MfrufaepObgljkDddubVdUwsgLAe5b8A2 pjkg== X-Gm-Message-State: ALyK8tI5YVwNI3BJHC9uiTSLu/dpMVRpCSwjZZabg1engpGEvPjTZjB0PFVej23rEuXjh4LVU8R7NxYPzLGWmg== X-Received: by 10.36.1.144 with SMTP id 138mr7053556itk.35.1465385492139; Wed, 08 Jun 2016 04:31:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.24.233 with HTTP; Wed, 8 Jun 2016 04:31:30 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 8 Jun 2016 12:31:30 +0100 Message-ID: Subject: Re: PATCH: pgAdmin4 windows installer To: Paresh More Cc: pgadmin-hackers , Sandeep Thakkar , Hamid Quddus Content-Type: multipart/alternative; boundary=001a1143d454b7e5e10534c2a567 X-Pg-Spam-Score: -1.5 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143d454b7e5e10534c2a567 Content-Type: text/plain; charset=UTF-8 Thanks! That's now committed, with a few modifications: - Install/uninstall Sphinx as it's not actually in the requirements.txt file and is only needed for building. - Detect errors in the doc build. - Rename ve_python to venv for consistency with Mac. - Comment/progress info improvements On Wed, Jun 8, 2016 at 7:23 AM, Paresh More wrote: > Hello Dave, > > As discuss added vcdist runtime, remove splash screen and added start menu > icon. > > Now also inno setup standard and Unicode both version are working fine. > > > > Attached is the updated patch. > > > On Mon, Jun 6, 2016 at 2:51 PM, Dave Page wrote: > >> Hi, >> >> On Fri, Jun 3, 2016 at 9:30 PM, Paresh More > > wrote: >> >>> Hello Dave. >>> >>> There was problem with the Make.bat file ^M characters which is been >>> removed. >>> >>> Issues are fixed along with some code and README tidied >>> >> >> I'm still seeing the same error: >> >> copy "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss.in" >> "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss" >> 1 file(s) copied. >> Error on line 113 in >> C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.iss: Column 3: >> Semicolon (';') expected. >> Compile aborted. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1143d454b7e5e10534c2a567 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks! That's now committed, with a few modifications= :

- Install/uninstall Sphinx as it's not actually in= the requirements.txt file and is only needed for building.
- Det= ect errors in the doc build.
- Rename ve_python to venv for consi= stency with Mac.
- Comment/progress info improvements
=

On Wed, Jun 8, 20= 16 at 7:23 AM, Paresh More <paresh.more@enterprisedb.com>= ; wrote:
Hello Da= ve,

As discuss added vcdist runtime, remove splash scree= n and added start menu icon.
=C2=A0
Now also inno setup= standard and Unicode both version are working=C2=A0fine.=C2=A0
=C2=A0
=C2=A0

Attached is the updat= ed patch.
=C2=A0

On Mon, Jun 6, 2016 at 2= :51 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,

On Fri, Jun 3, 2016 at 9:30 PM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hello Dave.

There was problem w= ith the Make.bat file ^M characters which is been removed.

Issues are fixed along with some code and README tidied

I'm still seeing the same erro= r:

copy "C:\Users\dpage\Documents\pgadmin4\pk= g\win32\installer.iss= .in" "C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.i= ss"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 1 file(s) copied.
= Error on line 113 in C:\Users\dpage\Documents\pgadmin4\pkg\win32\installer.= iss: Column 3:
Semicolon (';') expected.
= Compile aborted.=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company



-= -

Thanks & Regards

Paresh More

3D"NEW-EDB-logo-4c"

Pune, India.


--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1143d454b7e5e10534c2a567--