MIME-Version: 1.0
References: 
 <CANxoLDdq2T63tbdL+7OqfxxKkPe2PLbkSC1Bov4oEHzOcvQfLQ@mail.gmail.com>
In-Reply-To: 
 <CANxoLDdq2T63tbdL+7OqfxxKkPe2PLbkSC1Bov4oEHzOcvQfLQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 19 Jun 2019 15:27:46 +0100
Message-ID: 
 <CA+OCxoxFsPN_vP3k6znphGTm7t0L3Ov3ScVhO6hsEMQztN_RDQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM #4362 trigger function create script
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000002b69d2058bae09a8"
Precedence: bulk

--0000000000002b69d2058bae09a8
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #4362 trigger function create script.
> Please review it.
>

While I can see how this works, I question why we have the string "SETOF"
in prorettypname anyway? That's a separate property, so it should be in a
separate variable. What if I have a type called "SETOFDavesStuff"
(unlikely, but it illustrates the point)?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--0000000000002b69d2058bae09a8
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi &lt;<a=
 href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterprisedb.co=
m</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin=
:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"=
><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Attached is the patch to f=
ix RM #4362 trigger function create script.=C2=A0</div><div>Please review i=
t.</div></div></blockquote><div><br></div><div>While I can see how this wor=
ks, I question why we have the string &quot;SETOF&quot; in prorettypname an=
yway? That&#39;s a separate property, so it should be in a separate variabl=
e. What if I have a type called &quot;SETOFDavesStuff&quot; (unlikely, but =
it illustrates the point)?</div></div><div><br></div>-- <br><div dir=3D"ltr=
" class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.bl=
ogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @=
pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" tar=
get=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL=
 Company<br></div></div>

--0000000000002b69d2058bae09a8--