Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyHtr-0007sU-OE for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 14:06:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyHtq-0004z1-0z for pgadmin-hackers@arkaria.postgresql.org; Tue, 20 Mar 2018 14:06:02 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyHtp-0004yr-F5 for pgadmin-hackers@lists.postgresql.org; Tue, 20 Mar 2018 14:06:01 +0000 Received: from mail-wm0-x229.google.com ([2a00:1450:400c:c09::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyHti-0007fv-Ek for pgadmin-hackers@postgresql.org; Tue, 20 Mar 2018 14:05:59 +0000 Received: by mail-wm0-x229.google.com with SMTP id t7so3699646wmh.5 for ; Tue, 20 Mar 2018 07:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KHKR+uMNbIfD2p3eUlrohiP+vmkRt2unQpM1UeeUOx8=; b=Ap81nsEggmFcRBgk+vz/mdZJ4MebhV8h0DDF9VF2QkbtdpsM9lYlZi/V3TgODe1tUf OofdvoLzP2jbmTPgpgiWJCDL+wvcGtzHnMi3cOBRrcrdBej2/46hnT8k5hby8cAlPULL 1VGNGfQMemme3AqYlrn2faGq6KyCtPbnULrpjXbjxUppyn2GakG65w1oIc1NsFZYM/wH kkynHn0YMNecFlfoMyJLtWqTgKypCsjObZ5aNMp3SPr0H9gd0YsGt2DIyF6v8YYMsMdB wg6cz0cr89HWwiB3INHzESjUT+sON9BS9To4znbGBKdH5rQXGmzLoCSEwKhtK32J5L0M srog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KHKR+uMNbIfD2p3eUlrohiP+vmkRt2unQpM1UeeUOx8=; b=TYEd/rqljtZ2HvOYoRWxRP4e1gEJqNORGhZSU9RxsZ2pAozEz6uyHEybytR6o0esly Isr+qSdNAKt7HX4ysOE7+iIMG0waFY1aEdHYSZxa8Pjog4ZFRkGtJIQeCPWlCR5PJymh BbGvfq2ucnnrVVXTjSyd65zFzSQIBdN6r5HeFtnDwTfoOHnuBg5XumIiNJ15EU73GDAA 8dIOmzxeCqwFmQ+iJigPSsQq6ZTJPlvKlqA6sJVyL90Ng/GLJvFQzfjjowM9ET7ej+lb N2NjEppfwTLM8tFUQMr+d1i1j5sSTLWXnvepQa8WjVfSkdN+xfGTv0rWla+yFFZOtjs+ Y03w== X-Gm-Message-State: AElRT7HAXQZt+k6iTJJ6iD5X89djGVf4lv1IFkGLuIUCfJDoq9Irhdt+ SDThP9R968peJ6b/oLRL4TsEIwT9t0K02c6pcqNsck6efShiP8FKbQWyUsRyi7TW/y88dxQi5TF i4ZHIrQkDgU5KNAFlbA231IP0ZKGWNj7aUWvkvXZMizAjkyMXzpI6WPoc8Cg63T9KXDbvcMiEy4 7zc6wzCg== X-Google-Smtp-Source: AG47ELtzaHIo7k5GlMMg7HyhjYq8cxVe14ANmAYg5zRjhwKmgApvvT0OAAgXQfRqkijUEEeI5txUPg== X-Received: by 10.80.226.5 with SMTP id n5mr17952088edl.264.1521554750930; Tue, 20 Mar 2018 07:05:50 -0700 (PDT) Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com. [209.85.128.178]) by smtp.gmail.com with ESMTPSA id 4sm1834008edx.8.2018.03.20.07.05.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Mar 2018 07:05:49 -0700 (PDT) Received: by mail-wr0-f178.google.com with SMTP id z12so1829169wrg.4 for ; Tue, 20 Mar 2018 07:05:49 -0700 (PDT) X-Received: by 10.223.166.171 with SMTP id t40mr13925207wrc.49.1521554748921; Tue, 20 Mar 2018 07:05:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 20 Mar 2018 07:05:48 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 20 Mar 2018 14:05:48 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed To: Akshay Joshi Cc: Joao Pedro De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113df90a510e3f0567d892fe" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113df90a510e3f0567d892fe Content-Type: text/plain; charset="UTF-8" Hi This doesn't pass the Javascript tests for me. Please investigate ASAP: webpack: Compiled successfully. HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 152 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 153 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 154 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 155 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 156 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 157 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 158 of 486 SUCCESS (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is not required should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some error in JSON' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:11753:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 285 of 486 (1 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is not required should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some error in JSON' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some error in JSON' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:11760:60 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 286 of 486 (2 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some error in JSON' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is required should login is displayed FAILED Expected spy UserManagement.pga_login to have been called. at regression/javascript/sqleditor/execute_query_spec.js:11840:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 296 of 486 (3 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when JSON response is available when login is required should login is displayed FAILED Expected spy UserManagement.pga_login to have been called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is not required should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some plain text error' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:11875:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 299 of 486 (4 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is not required should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some plain text error' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some plain text error' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:11882:60 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 300 of 486 (5 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some plain text error' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is required should login is displayed FAILED Expected spy UserManagement.pga_login to have been called. at regression/javascript/sqleditor/execute_query_spec.js:11964:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 310 of 486 (6 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when no JSON response is available when login is required should login is displayed FAILED Expected spy UserManagement.pga_login to have been called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12002:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 314 of 486 (7 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occur when the connection to the server was lost when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when JSON response is available should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some error in JSON' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12232:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 334 of 486 (8 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when JSON response is available should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some error in JSON' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when JSON response is available should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some error in JSON' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12239:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 335 of 486 (9 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when JSON response is available should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some error in JSON' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when no JSON response is available should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some plain text error' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12282:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 340 of 486 (10 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when no JSON response is available should highlight the error in the SQL panel FAILED Expected spy SqlEditor._highlight_error to have been called with [ 'Some plain text error' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when no JSON response is available should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some plain text error' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12289:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 341 of 486 (11 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when no JSON response is available should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Some plain text error' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12340:58 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 347 of 486 (12 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an error occur when the connection to the server was lost when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12645:54 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 376 of 486 (13 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when cannot reach the Python Server should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'Not connected to the server or the connection to the server has been closed.' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12693:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 381 of 486 (14 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12751:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 388 of 486 (15 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should save the state FAILED Expected spy SqlEditor.save_state to have been called with [ 'execute', [ '' ] ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12774:48 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 391 of 486 (16 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should save the state FAILED Expected spy SqlEditor.save_state to have been called with [ 'execute', [ '' ] ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should display pga login FAILED Expected spy UserManagement.pga_login to have been called. at regression/javascript/sqleditor/execute_query_spec.js:12780:52 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 392 of 486 (17 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when login is required should display pga login FAILED Expected spy UserManagement.pga_login to have been called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12809:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 395 of 486 (18 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is not required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12874:56 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 403 of 486 (19 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should add new entry to history and update the Messages tab FAILED Expected spy SqlEditor.update_msg_history to have been called with [ false, 'some error message' ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should save the state FAILED Expected spy SqlEditor.save_state to have been called with [ 'execute', [ '' ] ] but it was never called. at regression/javascript/sqleditor/execute_query_spec.js:12897:48 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 406 of 486 (20 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should save the state FAILED Expected spy SqlEditor.save_state to have been called with [ 'execute', [ '' ] ] but it was never called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should initialize a new transaction FAILED Expected spy SqlEditor.init_transaction to have been called. at regression/javascript/sqleditor/execute_query_spec.js:12909:54 HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 408 of 486 (21 FAILED) (0 secs / 0 secs) HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when error is returned by the server when a new transaction is required should initialize a new transaction FAILED Expected spy SqlEditor.init_transaction to have been called. HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 486 of 486 (21 FAILED) (7.05 secs / 0 secs) error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. make: *** [check-js] Error 1 On Tue, Mar 20, 2018 at 1:12 PM, Akshay Joshi wrote: > Hi Hackers > > Attached is the patch file to fix the RM #2815. > > On Tue, Mar 20, 2018 at 3:24 PM, Dave Page > wrote: > >> >> >> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page >>> wrote: >>> >>>> I'm a little concerned that noone mentioned this earlier; I'm supposed >>>> to be building the release this afternoon, and I expect this change to at >>>> the very least be complex to fully test and verify. What's the ETA on the >>>> patch? What steps are being taken to ensure it's correct and doesn't cause >>>> regressions? >>>> >>> >>> Harshal has already mentioned in the RM. Currently I am changing >>> the logic, but it may take time to complete, fully test and verify. I'll >>> try my best to do it asap. >>> >> >> Sure, but how many of us are watching every comment on every RM? I know >> I'm not (I currently average ~400 emails/day). >> >> >>> >>>> On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Joao >>>>> >>>>> It seems that this fix broke the functionality of RM #2815. It is >>>>> mentioned in the RM what needs to be fixed now and I am currently working >>>>> on it. >>>>> While fixing the issue following problem that I found >>>>> >>>>> - In "start_running_query.py" file, we need to remove check "if >>>>> conn.connected()" from "__execute_query" function as we required >>>>> exception to be thrown while executing the query to identify the >>>>> ConnectionLost. >>>>> - In "execute_query.js" we have used *axios* to execute the query >>>>> and in case of exception, object is different then normal javascript >>>>> response object. >>>>> - We call following functions when exception or error comes and >>>>> send the "*.response.data*" as parameter >>>>> - wasConnectionLostToServer(): Check for the readyState >>>>> parameter, which is not the part of ".response.data". >>>>> - extractErrorMessage(): Check for the "responseJSON" and " >>>>> responseJSON.info", which is not the part of >>>>> ".response.data". >>>>> - is_pga_login_required(): Check for the "responseJSON" and " >>>>> responseJSON.info", which is not the part of >>>>> ".response.data". >>>>> - is_new_transaction_required(): Check for the "responseJSON" >>>>> and "responseJSON.info", which is not the part of >>>>> ".response.data". >>>>> >>>>> From the above list, some of the function calls are generic where they >>>>> need "responseJSON" and "responseJSON.info", so we can't change that. >>>>> Possible solution could be pass one extra flag as parameter to identify the >>>>> object is a axios response or javascript response to above functions >>>>> and change the logic accordingly. >>>>> >>>>> Please let me know your thoughts or any other suggestion. >>>>> >>>>> >>>>> On Fri, Feb 9, 2018 at 8:17 PM, Dave Page wrote: >>>>> >>>>>> Thanks, applied. >>>>>> >>>>>> On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < >>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>> >>>>>>> Hello, >>>>>>> Attached you can find the fix for the current pronlem >>>>>>> >>>>>>> >>>>>>> On Fri, Feb 9, 2018 at 7:29 AM Dave Page wrote: >>>>>>> >>>>>>>> Hi Joao, >>>>>>>> >>>>>>>> It looks like Jenkins has taken umbrage to this change, at least >>>>>>>> with Python 3.x. Can you take a look please? >>>>>>>> >>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Thanks, patches applied. >>>>>>>>> >>>>>>>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>> >>>>>>>>>> Hi Hackers, >>>>>>>>>> This is quite a big patch in order to solve the problem with the >>>>>>>>>> Explain Plan. >>>>>>>>>> >>>>>>>>>> We sent 2 patches that have the following: >>>>>>>>>> *- update-javascript-packages.diff * >>>>>>>>>> Add package: >>>>>>>>>> is-docker to select a specific setting when running the >>>>>>>>>> Chrome tests in >>>>>>>>>> Docker >>>>>>>>>> >>>>>>>>>> Upgrade the version of: >>>>>>>>>> - babel-loader >>>>>>>>>> - extract-text-webpack-plugin >>>>>>>>>> - jasmine-core >>>>>>>>>> - jasmine-enzyme >>>>>>>>>> - moment >>>>>>>>>> *- explain-plan-greenplum.diff* >>>>>>>>>> Extract SQLEditor.execute and SQLEditor._poll into their own >>>>>>>>>> files and add test around them >>>>>>>>>> Extract SQLEditor backend functions that start executing query >>>>>>>>>> to their own files and add tests around it >>>>>>>>>> Move the Explain SQL from the front-end and now pass the >>>>>>>>>> Explain plan parameters as a JSON object in the start query call. >>>>>>>>>> Extract the compile_template_name into a function that can be >>>>>>>>>> used by the different places that try to select the version of the template >>>>>>>>>> and the server type >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> Joao >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect * >>>>> >>>>> >>>>> >>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>> 976-788-8246 <+91%2097678%2088246>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>> 976-788-8246 <+91%2097678%2088246>* >>> >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --001a113df90a510e3f0567d892fe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

This doesn't pass the Javascript= tests for me. Please investigate ASAP:

webpa= ck: Compiled successfully.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6= ): Executed 152 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0= .0.0 (Mac OS X 10.12.6): Executed 153 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 154 of 486 SUCCESS = (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Execut= ed 155 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac= OS X 10.12.6): Executed 156 of 486 SUCCESS (0 secs / 0 secs)
Hea= dlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 157 of 486 SUCCESS (0 secs /= 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 158 of= 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.= 12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error occ= ur when the connection to the server was lost when JSON response is availab= le when login is not required should highlight the error in the SQL panel F= AILED
Expected spy SqlEdi= tor._highlight_error to have been called with [ 'Some error in JSON'= ; ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:= 11753:58
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 285 of= 486 (1 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X = 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error = occur when the connection to the server was lost when JSON response is avai= lable when login is not required should highlight the error in the SQL pane= l FAILED
Expected spy Sql= Editor._highlight_error to have been called with [ 'Some error in JSON&= #39; ] but it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10= .12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error oc= cur when the connection to the server was lost when JSON response is availa= ble when login is not required should add new entry to history and update t= he Messages tab FAILED
Ex= pected spy SqlEditor.update_msg_history to have been called with [ false, &= #39;Some error in JSON' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqledi= tor/execute_query_spec.js:11760:60
HeadlessChrome 0.0.0 (Mac OS X= 10.12.6): Executed 286 of 486 (2 FAILED) (0 secs / 0 secs)
Headl= essChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the= query tool when an error occur when the connection to the server was lost = when JSON response is available when login is not required should add new e= ntry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have= been called with [ false, 'Some error in JSON' ] but it was never = called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #pol= l when SQLEditor is the query tool when an error occur when the connection = to the server was lost when JSON response is available when login is requir= ed should login is displayed FAILED
Expected spy UserManagement.pga_login to have been called.
=
=C2=A0 =C2=A0 at regression/ja= vascript/sqleditor/execute_query_spec.js:11840:56
HeadlessChrome = 0.0.0 (Mac OS X 10.12.6): Executed 296 of 486 (3 FAILED) (0 secs / 0 secs)<= /div>
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when S= QLEditor is the query tool when an error occur when the connection to the s= erver was lost when JSON response is available when login is required shoul= d login is displayed FAILED
Expected spy UserManagement.pga_login to have been called.
Hea= dlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is t= he query tool when an error occur when the connection to the server was los= t when no JSON response is available when login is not required should high= light the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been called = with [ 'Some plain text error' ] but it was never called.
=C2=A0 =C2=A0 at regression/javasc= ript/sqleditor/execute_query_spec.js:11875:58
HeadlessChrome 0.0.= 0 (Mac OS X 10.12.6): Executed 299 of 486 (4 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEd= itor is the query tool when an error occur when the connection to the serve= r was lost when no JSON response is available when login is not required sh= ould highlight the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have bee= n called with [ 'Some plain text error' ] but it was never called.<= /div>
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when S= QLEditor is the query tool when an error occur when the connection to the s= erver was lost when no JSON response is available when login is not require= d should add new entry to history and update the Messages tab FAILED
<= div> Expected spy SqlEditor.update_m= sg_history to have been called with [ false, 'Some plain text error'= ; ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:= 11882:60
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 300 of= 486 (5 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X = 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error = occur when the connection to the server was lost when no JSON response is a= vailable when login is not required should add new entry to history and upd= ate the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called with [ fal= se, 'Some plain text error' ] but it was never called.
He= adlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is = the query tool when an error occur when the connection to the server was lo= st when no JSON response is available when login is required should login i= s displayed FAILED
Expect= ed spy UserManagement.pga_login to have been called.
=C2=A0 =C2=A0 at regression/javascript/sqledit= or/execute_query_spec.js:11964:56
HeadlessChrome 0.0.0 (Mac OS X = 10.12.6): Executed 310 of 486 (6 FAILED) (0 secs / 0 secs)
Headle= ssChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the = query tool when an error occur when the connection to the server was lost w= hen no JSON response is available when login is required should login is di= splayed FAILED
Expected s= py UserManagement.pga_login to have been called.
HeadlessChrome 0= .0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool= when an error occur when the connection to the server was lost when cannot= reach the Python Server should add new entry to history and update the Mes= sages tab FAILED
Expected= spy SqlEditor.update_msg_history to have been called with [ false, 'No= t connected to the server or the connection to the server has been closed.&= #39; ] but it was never called.
= =C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.= js:12002:58
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 314= of 486 (7 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS= X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an err= or occur when the connection to the server was lost when cannot reach the P= ython Server should add new entry to history and update the Messages tab FA= ILED
Expected spy SqlEdit= or.update_msg_history to have been called with [ false, 'Not connected = to the server or the connection to the server has been closed.' ] but i= t was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Execu= teQuery #poll when SQLEditor is NOT the query tool when an error occur when= the connection to the server was lost when JSON response is available shou= ld highlight the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been = called with [ 'Some error in JSON' ] but it was never called.
=
=C2=A0 =C2=A0 at regression/ja= vascript/sqleditor/execute_query_spec.js:12232:56
HeadlessChrome = 0.0.0 (Mac OS X 10.12.6): Executed 334 of 486 (8 FAILED) (0 secs / 0 secs)<= /div>
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when S= QLEditor is NOT the query tool when an error occur when the connection to t= he server was lost when JSON response is available should highlight the err= or in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been called with [ 'S= ome error in JSON' ] but it was never called.
HeadlessChrome = 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query= tool when an error occur when the connection to the server was lost when J= SON response is available should add new entry to history and update the Me= ssages tab FAILED
Expecte= d spy SqlEditor.update_msg_history to have been called with [ false, 'S= ome error in JSON' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/e= xecute_query_spec.js:12239:58
HeadlessChrome 0.0.0 (Mac OS X 10.1= 2.6): Executed 335 of 486 (9 FAILED) (0 secs / 0 secs)
HeadlessCh= rome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the = query tool when an error occur when the connection to the server was lost w= hen JSON response is available should add new entry to history and update t= he Messages tab FAILED
Ex= pected spy SqlEditor.update_msg_history to have been called with [ false, &= #39;Some error in JSON' ] but it was never called.
HeadlessCh= rome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the = query tool when an error occur when the connection to the server was lost w= hen no JSON response is available should highlight the error in the SQL pan= el FAILED
Expected spy Sq= lEditor._highlight_error to have been called with [ 'Some plain text er= ror' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_s= pec.js:12282:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed= 340 of 486 (10 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (M= ac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool wh= en an error occur when the connection to the server was lost when no JSON r= esponse is available should highlight the error in the SQL panel FAILED
Expected spy SqlEditor._high= light_error to have been called with [ 'Some plain text error' ] bu= t it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Ex= ecuteQuery #poll when SQLEditor is NOT the query tool when an error occur w= hen the connection to the server was lost when no JSON response is availabl= e should add new entry to history and update the Messages tab FAILED
<= div> Expected spy SqlEditor.update_m= sg_history to have been called with [ false, 'Some plain text error'= ; ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:= 12289:58
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 341 of= 486 (11 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X= 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an e= rror occur when the connection to the server was lost when no JSON response= is available should add new entry to history and update the Messages tab F= AILED
Expected spy SqlEdi= tor.update_msg_history to have been called with [ false, 'Some plain te= xt error' ] but it was never called.
HeadlessChrome 0.0.0 (Ma= c OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool whe= n an error occur when the connection to the server was lost when cannot rea= ch the Python Server should add new entry to history and update the Message= s tab FAILED
Expected spy= SqlEditor.update_msg_history to have been called with [ false, 'Not co= nnected to the server or the connection to the server has been closed.'= ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:1= 2340:58
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 347 of = 486 (12 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X = 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool when an er= ror occur when the connection to the server was lost when cannot reach the = Python Server should add new entry to history and update the Messages tab F= AILED
Expected spy SqlEdi= tor.update_msg_history to have been called with [ false, 'Not connected= to the server or the connection to the server has been closed.' ] but = it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Exec= uteQuery #execute when the SQL statement is not empty when cannot reach the= Python Server should add new entry to history and update the Messages tab = FAILED
Expected spy SqlEd= itor.update_msg_history to have been called with [ false, 'Not connecte= d to the server or the connection to the server has been closed.' ] but= it was never called.
=C2= =A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:12645:5= 4
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 376 of 486 (1= 3 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.= 6) ExecuteQuery #execute when the SQL statement is not empty when cannot re= ach the Python Server should add new entry to history and update the Messag= es tab FAILED
Expected sp= y SqlEditor.update_msg_history to have been called with [ false, 'Not c= onnected to the server or the connection to the server has been closed.'= ; ] but it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12= .6) ExecuteQuery #execute when the SQL statement is not empty when error is= returned by the server when login is not required should add new entry to = history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been ca= lled with [ false, 'some error message' ] but it was never called.<= /div>
=C2=A0 =C2=A0 at regressi= on/javascript/sqleditor/execute_query_spec.js:12693:56
HeadlessCh= rome 0.0.0 (Mac OS X 10.12.6): Executed 381 of 486 (14 FAILED) (0 secs / 0 = secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execu= te when the SQL statement is not empty when error is returned by the server= when login is not required should add new entry to history and update the = Messages tab FAILED
Expec= ted spy SqlEditor.update_msg_history to have been called with [ false, '= ;some error message' ] but it was never called.
HeadlessChrom= e 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is = not empty when error is returned by the server when login is required shoul= d add new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_hist= ory to have been called with [ false, 'some error message' ] but it= was never called.
=C2=A0= =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:12751:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 388 of 486 (15 F= AILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) = ExecuteQuery #execute when the SQL statement is not empty when error is ret= urned by the server when login is required should add new entry to history = and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called wit= h [ false, 'some error message' ] but it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQ= L statement is not empty when error is returned by the server when login is= required should save the state FAILED
Expected spy SqlEditor.save_state to have been called with [ = 'execute', [ '' ] ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/= sqleditor/execute_query_spec.js:12774:48
HeadlessChrome 0.0.0 (Ma= c OS X 10.12.6): Executed 391 of 486 (16 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQ= L statement is not empty when error is returned by the server when login is= required should save the state FAILED
Expected spy SqlEditor.save_state to have been called with [ = 'execute', [ '' ] ] but it was never called.
Head= lessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL stat= ement is not empty when error is returned by the server when login is requi= red should display pga login FAILED
Expected spy UserManagement.pga_login to have been called.
=
=C2=A0 =C2=A0 at regression/ja= vascript/sqleditor/execute_query_spec.js:12780:52
HeadlessChrome = 0.0.0 (Mac OS X 10.12.6): Executed 392 of 486 (17 FAILED) (0 secs / 0 secs)=
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute wh= en the SQL statement is not empty when error is returned by the server when= login is required should display pga login FAILED
Expected spy UserManagement.pga_login to have bee= n called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #e= xecute when the SQL statement is not empty when error is returned by the se= rver when a new transaction is not required should add new entry to history= and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called wi= th [ false, 'some error message' ] but it was never called.
=C2=A0 =C2=A0 at regression/java= script/sqleditor/execute_query_spec.js:12809:56
HeadlessChrome 0.= 0.0 (Mac OS X 10.12.6): Executed 395 of 486 (18 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when= the SQL statement is not empty when error is returned by the server when a= new transaction is not required should add new entry to history and update= the Messages tab FAILED
= Expected spy SqlEditor.update_msg_history to have been called with [ false,= 'some error message' ] but it was never called.
Headless= Chrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statemen= t is not empty when error is returned by the server when a new transaction = is required should add new entry to history and update the Messages tab FAI= LED
Expected spy SqlEdito= r.update_msg_history to have been called with [ false, 'some error mess= age' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_s= pec.js:12874:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed= 403 of 486 (19 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (M= ac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty = when error is returned by the server when a new transaction is required sho= uld add new entry to history and update the Messages tab FAILED
<= span style=3D"white-space:pre"> Expected spy SqlEditor.update_msg_hi= story to have been called with [ false, 'some error message' ] but = it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Exec= uteQuery #execute when the SQL statement is not empty when error is returne= d by the server when a new transaction is required should save the state FA= ILED
Expected spy SqlEdit= or.save_state to have been called with [ 'execute', [ '' ] = ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:12= 897:48
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 406 of 4= 86 (20 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 1= 0.12.6) ExecuteQuery #execute when the SQL statement is not empty when erro= r is returned by the server when a new transaction is required should save = the state FAILED
Expected= spy SqlEditor.save_state to have been called with [ 'execute', [ &= #39;' ] ] but it was never called.
HeadlessChrome 0.0.0 (Mac = OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty whe= n error is returned by the server when a new transaction is required should= initialize a new transaction FAILED
Expected spy SqlEditor.init_transaction to have been called.
=C2=A0 =C2=A0 at regression= /javascript/sqleditor/execute_query_spec.js:12909:54
HeadlessChro= me 0.0.0 (Mac OS X 10.12.6): Executed 408 of 486 (21 FAILED) (0 secs / 0 se= cs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute= when the SQL statement is not empty when error is returned by the server w= hen a new transaction is required should initialize a new transaction FAILE= D
Expected spy SqlEditor.= init_transaction to have been called.
HeadlessChrome 0.0.0 (Mac O= S X 10.12.6): Executed 486 of 486 (21 FAILED) (7.05 secs / 0 secs)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run = for documentation about this command.
make: *** [check-js] Error = 1


On Tue, Mar 20, 2018 at 1:12 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers

Attached is th= e patch file to fix the RM #2815.

On Tue,= Mar 20, 2018 at 3:24 PM, Dave Page <dave.page@enterprisedb.com> wrote:

On Tue, Ma= r 20, 2018 at 9:48 AM, Akshay Joshi <akshay.joshi@enterprisedb= .com> wrote:


On Tue, Mar 20, 2018 at 3:06 PM, Dave Page <dave.page@enterprisedb.com> wrote:
I'm a little concerned that noone = mentioned this earlier; I'm supposed to be building the release this af= ternoon, and I expect this change to at the very least be complex to fully = test and verify. What's the ETA on the patch? What steps are being take= n to ensure it's correct and doesn't cause regressions?

=C2=A0 =C2=A0 Harshal has = already mentioned in the RM. Currently I am changing the logic, but it may = take time to complete, fully test and verify. I'll try my best to do it= asap.

Sure,= but how many of us are watching every comment on every RM? I know I'm = not (I currently average ~400 emails/day).
=C2=A0

On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi <akshay.joshi= @enterprisedb.com> wrote:
Hi = Joao

It seems that this fix broke the functionali= ty of RM #2815. It is mentioned in the RM what needs to be fixed now and I = am currently working on it.
While fixing the issue following prob= lem that I found
  • In "start= _running_query.py= " file, we need to remove check "if conn.connected()" from "__execute_qu= ery" function as we required exception to be thrown while executing th= e query to identify the = ConnectionLost.=C2=A0=C2=A0
  • In "execute_query.js" we have us= ed axios t= o execute the query and in case of exception, object is different then norm= al javascript response object.=C2=A0
  • We call following functions wh= en exception or error comes and send the "<object>.response.d= ata" as parameter=C2=A0
    • wasConnectionLostToServer(): Check for the readyState parameter,= which is not the part of "<object>.response.data".=C2=A0
    • extractErrorMessa= ge(): Check for the "responseJSON" and "responseJSON.info&q= uot;,=C2=A0which is not the part of "&= lt;object>.response.data".
    • is_pga_login_required(): Check for the=C2=A0"responseJSON" and "responseJSON.info",= =C2=A0which is not the part of "<ob= ject>.response.data".
    • is_new_transaction_required():= =C2=A0Check for the=C2=A0"responseJSON" and "responseJSON.info",= =C2=A0which is not the part of "<ob= ject>.response.data".
From the above list, som= e of the function calls are generic where they need "responseJSON" and "responseJSON.info&qu= ot;, so we can't change that. Possible solution could be pass one extra= flag as parameter to identify the object is a axios response or javascript response to abo= ve functions and change the logic accordingly.

Ple= ase let me know your thoughts or any other suggestion.=C2=A0
=C2= =A0 =C2=A0 =C2=A0=C2=A0

On Fri, Feb 9, 2018 at 8= :17 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Fri,= Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira <jdealmeidaper= eira@pivotal.io> wrote:
Hello,
Attached you can find the fix for the current pron= lem


On = Fri, Feb 9, 2018 at 7:29 AM Dave Page <dpage@pgadmin.org> wrote:
Hi Joao,

It looks l= ike Jenkins has taken umbrage to this change, at least with Python 3.x. Can= you take a look please?


On Fri, Feb 9, 2018 at 11:54 AM, Dave Page <dpage@p= gadmin.org> wrote:
Thanks, patches applied.

On Fri, Fe= b 2, 2018 at 10:50 PM, Joao De Almeida Pereira <jdealmeidaperei= ra@pivotal.io> wrote:
Hi Hackers,
This is quite a big patch in order to solve the= problem with the Explain Plan.

We sent 2 patches = that have the following:
-=C2=A0update-javascript-packages.diff=C2=A0
=C2=A0 =C2=A0 Add package:
= =C2=A0 =C2=A0 =C2=A0is-docker to select a specific setting when running the= Chrome tests in
=C2=A0 =C2=A0 =C2=A0Docker

<= div>=C2=A0 =C2=A0 Upgrade the version of:
=C2=A0 =C2=A0 - babel-l= oader
=C2=A0 =C2=A0 - extract-text-webpack-plugin
=C2= =A0 =C2=A0 - jasmine-core
=C2=A0 =C2=A0 - jasmine-enzyme
=C2=A0 =C2=A0 - moment
-=C2=A0explain-plan-greenplum.d= iff
=C2=A0 Extract SQLEditor.execute and SQLEditor._poll into= their own files and add test around them
=C2=A0 Extract SQLEdito= r backend functions that start executing query to their own files and add t= ests around it
=C2=A0 Move the Explain SQL from the front-end and= now pass the Explain plan parameters as a JSON object in the start query c= all.
=C2=A0 Extract the compile_template_name into a function tha= t can be used by the different places that try to select the version of the= template and the server type


Thank= s
Joao



-= -
Dave Page
Blog: http://pgsnake.blogspot.com
= Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise = PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company



<= /div>--
Akshay Joshi
=
Sr. Software Arc= hitect





--
Dave Page
VP, Chief Architect, Tools & Installers
Enter= priseDB: http://w= ww.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
Akshay Joshi
Sr. Software Architect

<= font color=3D"#3333FF">
=
=


--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB:= http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake



--
Akshay Joshi
Sr. Software Architect

=
Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--001a113df90a510e3f0567d892fe--