MIME-Version: 1.0
References: 
 <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>
In-Reply-To: 
 <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 9 Jul 2019 16:58:41 +0100
Message-ID: 
 <CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com>
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
To: Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000325f89058d41a31e"
Precedence: bulk

--000000000000325f89058d41a31e
Content-Type: text/plain; charset="UTF-8"

Hi,

What's the ticket number for this? That's a fair amount of code for a
one-line description. There are also no doc changes describing how to
navigate the sub-node control that I can see.

Also; instead of changing the repo used for backgrid, can we not
un-vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
ganesh.jaybhay@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached is the patch for keyboard accessibility of sub-node control. It
> also covers sub-node dialog forward/backward tab navigation with shortcuts.
>
> Kindly review.
>
> Regards,
> Ganesh Jaybhay
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000325f89058d41a31e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<div><br></div><div>What&#39;s the ticket number for th=
is? That&#39;s a fair amount of code for a one-line description. There are =
also no doc changes describing how to navigate the sub-node control that I =
can see.</div><div><br></div><div>Also; instead of changing the repo used f=
or backgrid, can we not un-vendorise it?</div></div><br><div class=3D"gmail=
_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 8, 2019 at 4:49 P=
M Ganesh Jaybhay &lt;<a href=3D"mailto:ganesh.jaybhay@enterprisedb.com">gan=
esh.jaybhay@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi Hackers,<d=
iv><br></div><div>Attached is the patch for keyboard accessibility of sub-n=
ode control. It also covers sub-node dialog forward/backward tab navigation=
 with shortcuts.</div><div><br></div><div>Kindly review.</div><div><br></di=
v><div>Regards,</div><div>Ganesh Jaybhay</div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" targ=
et=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL =
Company<br></div>

--000000000000325f89058d41a31e--