MIME-Version: 1.0
References: 
 <CAJ9T6SuRougj0rUJai0BdSRY17kPPCi7w0cbEv6DSLeEn2e0mw@mail.gmail.com>
In-Reply-To: 
 <CAJ9T6SuRougj0rUJai0BdSRY17kPPCi7w0cbEv6DSLeEn2e0mw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 31 Mar 2021 15:23:36 +0100
Message-ID: 
 <CA+OCxoxHneaUCAyhTPa1MfiuDTr6JhUfHzyaE4NBt-y1FMOXaA@mail.gmail.com>
Subject: Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting
 server.
To: Pradip Parkale <pradip.parkale@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e92b2c05bed5dcef"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoxHneaUCAyhTPa1MfiuDTr6JhUfHzyaE4NBt-y1FMOXaA%40mail.gmail.com>
Precedence: bulk

--000000000000e92b2c05bed5dcef
Content-Type: text/plain; charset="UTF-8"

Thanks Pradip.

Before this is committed, let's change this:

gettext('Current trasaction is not commited because server is
disconnected.'),

to:

gettext('The current transaction has been rolled back because the server
was disconnected.'),

On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale <
pradip.parkale@enterprisedb.com> wrote:

> Hi Hackers,
> Please find the attached patch for #5519. Updated the existing
> confirmation message and also added a new confirmation dialog before
> closing the query tool if the server is disconnected.
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

--000000000000e92b2c05bed5dcef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Thanks Pradip.<div><br><=
/div><div>Before this is committed, let&#39;s change this:</div><div><br></=
div><div>gettext(&#39;Current trasaction is not commited because server is =
disconnected.&#39;),<br></div><div><br></div><div>to:</div><div><br></div><=
div>gettext(&#39;The current transaction has been rolled back because the s=
erver was disconnected.&#39;),<br></div></div></div></div><br><div class=3D=
"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Mar 31, 2021 at=
 3:09 PM Pradip Parkale &lt;<a href=3D"mailto:pradip.parkale@enterprisedb.c=
om">pradip.parkale@enterprisedb.com</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;=
border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr">Hi Hackers,<div>Please find the attached patch for #5519=
. Updated the existing confirmation message and also added a new confirmati=
on dialog before closing the query tool if the server is disconnected.<br c=
lear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div s=
tyle=3D"font-size:12.8px">Thanks &amp; Regards,<br></div><div style=3D"font=
-size:12.8px">Pradip Parkale<br>Software Engineer | EnterpriseDB Corporatio=
n</div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature"><div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"h=
ttp://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</=
a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"http://www.enterprisedb.com"=
 target=3D"_blank">http://www.enterprisedb.com</a><br><br></div></div>

--000000000000e92b2c05bed5dcef--