MIME-Version: 1.0
In-Reply-To: 
 <CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com>
References: 
 <CAKbCA9Rk0PKsMxC95MJhqK=WeDWoizDKiXBZar+uuRe42obq3Q@mail.gmail.com>
 <CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Fri, 15 Jun 2018 09:11:09 +0100
Message-ID: 
 <CA+OCxoxJ0DnZ1=LsDCV4aMRR8Jep3nNieng0qAE9QJjV-E6A4g@mail.gmail.com>
Subject: Re: pgadmin_page functions updated
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: Shubham Agarwal <shubham.agarwal@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000003028ce056ea9c200"
Precedence: bulk

--0000000000003028ce056ea9c200
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 15, 2018 at 6:32 AM, Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi Shubham,
>
> On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <
> shubham.agarwal@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have modified following two functions in pgadmin_page.py :-
>>
>> 1. click_tab() -> Added wait till element is clickable, test cases are
>> failing since the function attempts to click the tab which is not yet in
>> the state to be clicked.
>>
>> 2. add_server() -> Replaced the sleep statement with wait till element to
>> be clickable.
>>
>> Please find the attached patch.
>>
>> We should start using CSS selectors instead of xpath, otherwise the patch
> works fine and also changes look good to me.
>

Yes, and we should update files as and when we touch them as part of our
ongoing refactoring.

Shubham; please go through the files your patch touches, and replace any
xpath selectors with CSS selectors.  Aside from that, the patch looked to
me too, and Pivotal's patch-bot seems happy with it.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--0000000000003028ce056ea9c200
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Fri, Jun 15, 2018 at 6:32 AM, Khushboo Vashi <span dir=3D"ltr">&lt;<=
a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushbo=
o.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmai=
l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left=
:1ex"><div dir=3D"ltr">Hi Shubham,<br><div class=3D"gmail_extra"><br><div c=
lass=3D"gmail_quote"><span class=3D"">On Thu, Jun 14, 2018 at 3:25 PM, Shub=
ham Agarwal <span dir=3D"ltr">&lt;<a href=3D"mailto:shubham.agarwal@enterpr=
isedb.com" target=3D"_blank">shubham.agarwal@enterprisedb.<wbr>com</a>&gt;<=
/span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hi Team,<d=
iv><br></div><div>I have modified following two functions in pgadmin_page.p=
y :-</div><div><br></div><div>1. click_tab() -&gt; Added wait till element =
is clickable, test cases are failing since the function attempts to click t=
he tab which is not yet in the state to be clicked.</div><div><br></div><di=
v>2. add_server() -&gt; Replaced the sleep statement with wait till element=
 to be clickable.=C2=A0</div><div><br></div><div>Please find the attached p=
atch.<span class=3D"m_6525053594366076656HOEnZb"><font color=3D"#888888"><b=
r clear=3D"all"><div><br></div></font></span></div></div></blockquote></spa=
n><div>We should start using CSS selectors instead of xpath, otherwise the =
patch works fine and also changes look good to me.</div></div></div></div><=
/blockquote><div><br></div><div>Yes, and we should update files as and when=
 we touch them as part of our ongoing refactoring.</div><div><br></div><div=
>Shubham; please go through the files your patch touches, and replace any x=
path selectors with CSS selectors.=C2=A0 Aside from that, the patch looked =
to me too, and Pivotal&#39;s patch-bot seems happy with it.</div><div><br><=
/div></div><div>Thanks.</div><div><br></div>-- <br><div class=3D"gmail_sign=
ature" data-smartmail=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"htt=
p://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a>=
<br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterpr=
isedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Enterpr=
ise PostgreSQL Company<br></div>
</div></div>

--0000000000003028ce056ea9c200--