Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyruM-0006ex-Vk for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Jul 2021 08:18:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lyruL-00042g-VU for pgadmin-hackers@arkaria.postgresql.org; Thu, 01 Jul 2021 08:18:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyruL-00042Y-Lr for pgadmin-hackers@lists.postgresql.org; Thu, 01 Jul 2021 08:18:49 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lyruJ-00012v-LA for pgadmin-hackers@postgresql.org; Thu, 01 Jul 2021 08:18:48 +0000 Received: by mail-ej1-x62a.google.com with SMTP id l24so8973243ejq.11 for ; Thu, 01 Jul 2021 01:18:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qPt2BBGzfX0Hs8zFycvHinnrDkmZbQL2+3nKbzcxPdw=; b=XfCoFV58OuEslLK2tz4547fk7a3iuGi2i9oJhs575Q5DhWhkdSVF8oJiZ9ywJTxA50 I0rFI9C/YGSLzsv44NFjcIULZL9+O0FKyXpdDfeeLqlowJSRMxNJgvt5spnPJKupwzHU 8K2zKrKSDPS069IhQw99rMhIepLtkuvZ28LAPb4vqJaFLAH8LNEubqI9eLjoByhlkQz2 S3fnc+KKICT+lHV8/3U65jerZezaBHtW4Q+kbuQ+mElNlHNGjrzaesSacGyNLLN8Rv/2 Hq4oDmkrHvSH2UlKZifK22Vz8Wn35cLFCTzO96KeppyIwJqFVjHRLx33R7Ou4xh66MP1 gojw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qPt2BBGzfX0Hs8zFycvHinnrDkmZbQL2+3nKbzcxPdw=; b=mS+O8vK+kMgUJbAvyoUUrNEo/bPZQWTGJzc5EHmIyFiRX48rl4MbU/VtrMN3xUqb0h z4cdlQGtoov5ZJupShZwQY1hhs4E6BkFNM7wkZeLZI3+NkAZekD04pexlkIzkKevPxjZ TE7dG4Wg0uQX4YiiH4toHXnEKxjMYZ1Wj27AoW8HnyZrMHioZGw5zmPBQVz7a2I84Vu/ CT+xNPrjoBOEiHvYpkZSaJ6fcMRKnP1YlHvN3RGZZ7BvRJF5EJc8CIXWscU8Yypn3Dl7 ptCLcy6wwBwCAHlIZ7aUlpqX6LTjjuSZE1ZCkyA3deBU6/6pDuuFskyI+U/qLsO71sNj td/A== X-Gm-Message-State: AOAM532CjA4JPnqapZxi8scMeSGdbBv6n+Cm35TCf2VFN8OLExEhrS9z qn42OoP7Wsx9Hwnlgi3O2dRFrn9HjcRK/wardMiQXQ== X-Google-Smtp-Source: ABdhPJxpGpqv8Icri+jmKFNy/6oGQPwdiZQ2OiYIYPs0yBGKmn8aQeGJJTvkfljUauttciQoQRvK67Kdw0Hh+CxVVAI= X-Received: by 2002:a17:906:7f95:: with SMTP id f21mr14075220ejr.548.1625127526072; Thu, 01 Jul 2021 01:18:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 1 Jul 2021 09:18:34 +0100 Message-ID: Subject: Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field To: Khushboo Vashi Cc: pgadmin-hackers , Nikhil Mohite Content-Type: multipart/alternative; boundary="000000000000e81ba405c60b7c69" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e81ba405c60b7c69 Content-Type: text/plain; charset="UTF-8" Thanks, committed. On Wed, Jun 30, 2021 at 1:11 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 12:36 PM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Jun 30, 2021 at 3:35 PM Dave Page wrote: >> >>> Here's a simple patch for $SUBJECT. It will remove any leading spaces >>> from the grid cell display and replace them with '[...] '. In edit mode, >>> the data is unchanged. >>> >>> The patch looks good to me. >> > > Thanks. > > >> Do we need to specify somewhere what is [...] ? >> > > I don't think there's much point. > > >> >> The only downside I can see to this is that the tooltip will show the >>> modified data when it probably should actually show the un-modified data. >>> Unfortunately that's handled by a SlickGrid plugin, which would have to be >>> vendorised and modified (perhaps non-trivially). I don't think that's a big >>> issue though. >>> >>> -- >>> Dave Page >>> Blog: https://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: https://www.enterprisedb.com >>> >>> > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com --000000000000e81ba405c60b7c69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, committed.

On Wed, Jun 30, 2021 at 1:11 PM Dave Pag= e <dpage@pgadmin.org> wrote:=
Hi

On Wed, Jun 30, 2021 at = 12:36 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

On Wed, Jun 30, 2021 at 3= :35 PM Dave Page <dpage@pgadmin.org> wrote:
Here's a simple patch for $SUBJECT. It will remove any leading spaces= from the grid cell display and replace them with '[...] '. In edit= mode, the data is unchanged.

The pat= ch looks good to me.=C2=A0

Thanks.
=C2=A0
Do we need to specify somewhere what is [...] ?

I don't think there's= much point.
=C2=A0

The only downside I can see to this is that the tooltip will sh= ow the modified data when it probably should actually show the un-modified = data. Unfortunately that's handled by a SlickGrid plugin, which would h= ave to be vendorised and modified (perhaps non-trivially). I don't thin= k that's a big issue though.

--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitt= er: @pgsnake

EDB: https://www.enterprisedb.com



--
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake<= br>
EDB: http= s://www.enterprisedb.com



--
--000000000000e81ba405c60b7c69--