Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPkze-0002jh-6J for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 10:14:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iPkzc-0007VS-Hu for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Oct 2019 10:14:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPkzc-0007VL-5U for pgadmin-hackers@lists.postgresql.org; Wed, 30 Oct 2019 10:14:20 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iPkzW-0003TG-TD for pgadmin-hackers@postgresql.org; Wed, 30 Oct 2019 10:14:17 +0000 Received: by mail-wm1-x342.google.com with SMTP id 6so3941444wmf.0 for ; Wed, 30 Oct 2019 03:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CY5vqJb25kzxixovGwqwDVymxJdiWEl5188rUEGZRUE=; b=JXXL6fMOrDmw6ItVA7/KVH35+S1b//ybAw1VRxFGaGKa4Dh+j3igZyz9MbiVPDGM+K NUq/jfPJKPeZQT9InGZZr+vXob8Bt9C6r1rGxbnyZzfrxDklCn/Wrl2q38w3wQ4caKSS PXWnuM3ZNo60CRCL07KihC9t7vSNlBUheW4qhmexxSCEor6KYW7WsWqzcMFxPkxNC2DR IdMSdNW3B3nW4RqjJAqSWqtcMU9B99qizI4OlNHoDOr/LBQLpST+kZGf0RJ9qf0mHoS1 AH7CQFTaSsd8U88aJastMMB6zhDRLs4vqq9sE7Z4bwQfS6dcMwLRprGmfFj99AS4TFly H8Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CY5vqJb25kzxixovGwqwDVymxJdiWEl5188rUEGZRUE=; b=OrRfwU/cKWMQY4Lo0L05uW9h8M2dxDAH0C76ZNbxURbYgky8B1SmfFNJTNRz8mevE9 1pU2iZU1oDgZBJY/jqCL4XCf3Rt6HknePHxaZ1vrtn0gZLEB5isR5I1O2DsKst+xb3FU lyevian44sCWJzvAeWCHvKV3JIDDQ+LfyYXlfgEyFzZinYfPC862gaL05FUzxrKBCWjQ g85pLprNYxIrc8ytn7IROeQqwTJn+salh5ZWYdd+pJk7ymiRzj7JRyLlB0MsNtfx64zr Rj/vLBCMqVcS+0LkBJd62jtispF4wsLaLUujNLernqLedEIh5YyUKTBr8IuRxkAqCudH ZFfA== X-Gm-Message-State: APjAAAUsu58X6TTE6SADkARjlvsS2AcxVzhu6L6J3MD/CIIb3gLhV5cM RtH72NVa/FCoZIDrASDsVnKh+OIfzBoURLoEjwoH6w== X-Google-Smtp-Source: APXvYqzfPTcqdq1p0fczBicVJg1duAd+DydD74Z9hjSPXmUkwWodwipQRUjVa3LZCDubuH06JK0jw1AQfr9xfSFwvAQ= X-Received: by 2002:a1c:f401:: with SMTP id z1mr8019442wma.66.1572430453359; Wed, 30 Oct 2019 03:14:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 30 Oct 2019 10:14:00 +0000 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000009b5d2805961dfe10" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009b5d2805961dfe10 Content-Type: text/plain; charset="UTF-8" Hi On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > >> Hi >> >> I just found an, umm, embarrassing issue with this. It asks for the >> cancel confirmation even when pressing the OK button :-o >> > Tested all but missed the obvious. Bad miss :/ > Attached is the patch to fix the issue. > Thanks - applied. Should we also warn on Reset? That seems logical to me. > >> Can you fix that ASAP please? >> >> On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: >> >>> Thanks, applied. >>> >>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to warn the user before closing an unsaved >>>> properties dialog. >>>> Additionally, I have added a preference option in Browser->Display >>>> where the user can disable this. Default is enabled. >>>> Docs updated. >>>> >>>> Kindly review. >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000009b5d2805961dfe10 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal &l= t;aditya.toshniwal@ent= erprisedb.com> wrote:
Hi,
On Tue, Oct 29, 2019 at 9:01 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

I just found an, umm, embarrassing issue = with this. It asks for the cancel confirmation even when pressing the OK bu= tton :-o
Tested all but missed the obvious. Bad = miss :/
Attached is the patch to fix the issue.=C2=A0

Thanks - applied. Should w= e also warn on Reset? That seems logical to me.
=C2=A0

Can you fix that ASAP please?

On Tue, Oct 29,= 2019 at 2:35 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Tue, Oct 2= 9, 2019 at 6:40 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com&g= t; wrote:
Hi Hackers,
<= div style=3D"font-family:verdana,sans-serif">
Attached is the patch to warn the user before clo= sing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Di= splay where the=C2=A0user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks a= nd Regards,
Aditya Toshni= wal
S= r. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about = Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000009b5d2805961dfe10--