MIME-Version: 1.0
In-Reply-To: 
 <CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com>
References: 
 <CAG7mmoy7ruK=HZGOt5GTFsuSF5e4+zHnagU0hJfuMUhqjZs=mw@mail.gmail.com>
From: Dave Page <dave.page@enterprisedb.com>
Date: Mon, 11 Jun 2018 17:14:24 +0100
Message-ID: 
 <CA+OCxoxMW=NwVVSdcquXZTquxdep1cHi4DGVap=xTeTtMJXkEA@mail.gmail.com>
Subject: Re: [PATCH] pgAgent segfault
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000119917056e600b21"
Precedence: bulk

--000000000000119917056e600b21
Content-Type: text/plain; charset="UTF-8"

Thanks, patch applied.

On Mon, Jun 11, 2018 at 5:25 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com
> wrote:

> Hi Dave,
>
> While debugging the issue
> <https://www.postgresql.org/message-id/CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A%40mail.gmail.com>
> reported by Rob, I found one segfault.
> Please find the attached patch to find that fix along with another one.
>
> 1. Connection object was being accessed, which was already released.
>
> 2. Changed the logic for checking the connection object existence.
>
> We're using "if (!ms_primaryCon)", which should convert the logic as
> boolean operator explicitly, which we defined for the 'DBconn' class.
>
> I suspect some compilers (specifically windows one) may not behave that
> way, and instead of using the boolean operator, it checks for the pointer
> is NULL or not.
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>


-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

--000000000000119917056e600b21
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks, patch applied.</div><div class=3D"gmail_extra"><br=
><div class=3D"gmail_quote">On Mon, Jun 11, 2018 at 5:25 AM, Ashesh Vashi <=
span dir=3D"ltr">&lt;<a href=3D"mailto:ashesh.vashi@enterprisedb.com" targe=
t=3D"_blank">ashesh.vashi@enterprisedb.com</a>&gt;</span> wrote:<br><blockq=
uote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc =
solid;padding-left:1ex"><div dir=3D"ltr">Hi Dave,<div><br></div><div>While =
debugging the <a href=3D"https://www.postgresql.org/message-id/CAG7mmoxXB0D=
sLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A%40mail.gmail.com" target=3D"_blank"=
>issue</a> reported by Rob, I found one segfault.</div><div>Please find the=
 attached patch to find that fix along with another one.</div><div><br></di=
v><div>1. Connection object was being accessed, which was already released.=
</div><div><br></div><div>2. Changed the logic for checking the connection =
object existence.</div><div><br></div><div>We&#39;re using &quot;if (!ms_pr=
imaryCon)&quot;, which should convert the logic as boolean operator explici=
tly, which we defined for the &#39;DBconn&#39; class.</div><div><br></div><=
div>I suspect some compilers (specifically windows one) may not=C2=A0behave=
 that way, and instead of using the boolean operator, it checks for the poi=
nter is NULL or not.</div><div><br clear=3D"all"><div><div class=3D"m_-6798=
059016360799341gmail_signature" data-smartmail=3D"gmail_signature"><div dir=
=3D"ltr"><div><div dir=3D"ltr"><div style=3D"margin:0pt 0pt 8px"><p style=
=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><span sty=
le=3D"font-style:italic"><span>--</span></span></span></p><p style=3D"margi=
n:0pt"><span style=3D"font-family:courier new,monospace"><span style=3D"fon=
t-style:italic"><span>Thanks &amp; Regards,</span></span><br style=3D"font-=
style:italic"><br style=3D"font-style:italic"><span style=3D"font-style:ita=
lic">Ashesh Vashi</span><br style=3D"font-style:italic"><span style=3D"font=
-style:italic">EnterpriseDB INDIA: </span><a href=3D"http://www.enterprised=
b.com" target=3D"_blank">Enterprise PostgreSQL Company</a></span></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
br></span></p>
<p style=3D"margin:0pt"><span style=3D"font-family:courier new,monospace"><=
a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank"><i>http=
://www.linkedin.com/in/<wbr>asheshvashi</i></a></span></p></div></div></div=
></div></div></div>
</div></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dave Page<br>VP, Ch=
ief Architect, Tools &amp; Installers<br>EnterpriseDB: <a href=3D"http://ww=
w.enterprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>Th=
e Enterprise PostgreSQL Company<br><br>Blog: <a href=3D"http://pgsnake.blog=
spot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pg=
snake</div>
</div>

--000000000000119917056e600b21--