MIME-Version: 1.0
References: 
 <CAO+oWtBxAaDxdPOkcf=bTU0D6sDogX_az4SgN-5zKZt-9G=2xQ@mail.gmail.com>
 <CA+OCxozieNmgfoGFq0G0Mxy+bu2Ct6hK9goZA3xtVJm9EaK6HA@mail.gmail.com>
 <CAO+oWtA13KM+jmWm+MkGbmLps2dh3B06mEZu6-PQjZ0ip7+G6g@mail.gmail.com>
 <CA+OCxoxMdX9Lsyugx7=_CZ3Z6K9jxHVTOBu4q=5_1cwgXsP7LQ@mail.gmail.com>
 <CAM9w-_mdXSmj2xv9W2k6hdmdY+3V8rfi4gnjBA_Jy28ZYkza2Q@mail.gmail.com>
 <CA+OCxozSdrD1ziKmfd_xLh72P031vdEo60wZxniyYP9sBLoM7Q@mail.gmail.com>
 <CAM9w-_=tRn_zM6C8Pm6B5w6du8BjdtrRnb1XxX1qyEcaSx4kEg@mail.gmail.com>
 <CA+OCxoz30kYxbska9TFHDKO3kXoervwY6OYE2kcY6b-k6-iYvg@mail.gmail.com>
 <CAM9w-_kjmG0rthcqss2TL+eFtC93qn_5ts_5=Fkqes82VG_EMg@mail.gmail.com>
 <CA+OCxozJpVhOTkPMv3_+EoEto+v+EeL=p1-dxjHFEvJM1EMBEQ@mail.gmail.com>
 <CAM9w-_n9i5fZSzRRNywJiCGv7TSRbSHLv+LVEBR=qn3zczrAxg@mail.gmail.com>
 <CAM9w-_nvA83wZ8m47B3fLswAQygrg1X9tk1g9hyQZEFqoH_zog@mail.gmail.com>
 <CA+OCxowig3kDr7APS0jitjBcE=Mq_vbnUNYYApt6-7_xp9yg6w@mail.gmail.com>
 <CAA-aLv6Lp-zHhnrh-SqzSeO7L8XanNjwhBQpsaP_4SqgwUHcmw@mail.gmail.com>
 <CA+OCxoyH6SNE_T+2p=4sQHHoTzsOOVuT+HEzqZMzgbKRXn_EAA@mail.gmail.com>
 <CAA-aLv54foGwCFYgsEN=tHM=Jzf=HBdsK96X+M0AaKigXh9OTg@mail.gmail.com>
In-Reply-To: 
 <CAA-aLv54foGwCFYgsEN=tHM=Jzf=HBdsK96X+M0AaKigXh9OTg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 23 Apr 2024 13:50:37 +0100
Message-ID: 
 <CA+OCxoxN3D+tojy+67LNc702oP2JrK9035HtSROYeJErb6EXqw@mail.gmail.com>
Subject: Re: Regarding feature #6841
To: Thom Brown <thom@linux.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>,
	Anil Sahoo <anil.sahoo@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ecd3220616c3007d"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoxN3D%2Btojy%2B67LNc702oP2JrK9035HtSROYeJErb6EXqw%40mail.gmail.com>
Precedence: bulk

--000000000000ecd3220616c3007d
Content-Type: text/plain; charset="UTF-8"

On Tue, 23 Apr 2024 at 12:03, Thom Brown <thom@linux.com> wrote:

>
>> You've been able to do the "Select and run" thing for years. If you
>> select text in the editor and hit the execute button, only the selected
>> text is sent to the server. If nothing is selected, the entire string is
>> sent. This feature will complement that for convenience, but for safety
>> will have a separate button/shortcut.
>>
>
> Oh, I clearly don't use PgAdmin enough to know this already.
>

Boo!


>
> I still find the proposal somewhat unintuitive, but the foot-gun
> safeguards that have been suggested sound like any pedal injuries will
> solely be the fault of the user.
>
> I would want to see it tested in a diverse range of scenarios though,
> which will require some imagination given what users will no doubt try to
> use it on.
>

Yes, I have made that very clear to the team. Suggestions for test
scenarios are welcome of course - a good way to experiment might be to see
how the current version of pgAdmin (which uses the new CodeMirror code)
manages to mess up syntax highlighting of anything weird.

-- 
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com

--000000000000ecd3220616c3007d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Tue, 23 Apr 2024 at 12:03, Thom Br=
own &lt;<a href=3D"mailto:thom@linux.com">thom@linux.com</a>&gt; wrote:<br>=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,=
204);padding-left:1ex"><div dir=3D"auto"><div class=3D"gmail_quote" dir=3D"=
auto"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,=
204);padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div><br=
></div><div>You&#39;ve been able to do the &quot;Select and run&quot; thing=
 for years. If you select text in the editor and hit the execute button, on=
ly the selected text is sent to the server. If nothing is selected, the ent=
ire string is sent. This feature will complement that for convenience, but =
for safety will have a separate button/shortcut.</div></div></div></blockqu=
ote></div><div dir=3D"auto"><br></div><div dir=3D"auto">Oh, I clearly don&#=
39;t use PgAdmin enough to know this already.</div></div></blockquote><div>=
<br></div><div>Boo!</div><div>=C2=A0</div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:=
solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"auto=
"><div dir=3D"auto"><br></div><div dir=3D"auto">I still find the proposal s=
omewhat unintuitive, but the foot-gun safeguards that have been suggested s=
ound like any pedal injuries will solely be the fault of the user.</div><di=
v dir=3D"auto"><br></div><div dir=3D"auto">I would want to see it tested in=
 a diverse range of scenarios though, which will require some imagination g=
iven what users will no doubt try to use it on.</div></div></blockquote><di=
v><br></div><div>Yes, I have made that very clear to the team. Suggestions =
for test scenarios are welcome of course - a good way to experiment might b=
e to see how the current version of pgAdmin (which uses the new CodeMirror =
code) manages to mess up syntax highlighting of anything weird.=C2=A0</div>=
</div><div><br></div><span class=3D"gmail_signature_prefix">-- </span><br><=
div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Page<div>pg=
Admin: <a href=3D"https://www.pgadmin.org" target=3D"_blank">https://www.pg=
admin.org</a></div><div>PostgreSQL: <a href=3D"https://www.postgresql.org" =
target=3D"_blank">https://www.postgresql.org</a><br><div>EDB:=C2=A0<a href=
=3D"https://www.enterprisedb.com" target=3D"_blank">https://www.enterprised=
b.com</a></div><div><br></div></div></div></div></div>

--000000000000ecd3220616c3007d--