MIME-Version: 1.0
In-Reply-To: 
 <CAM5-9D_ebJh8VJfvhk2cR-w=QqkC2YTWhc8ft+v3a9qSTTotKw@mail.gmail.com>
References: 
 <CAM5-9D_ebJh8VJfvhk2cR-w=QqkC2YTWhc8ft+v3a9qSTTotKw@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Wed, 6 Jul 2016 13:10:35 +0100
Message-ID: 
 <CA+OCxoxNCNF9bgzJH7+-04o3-agSX8-Py4OgaKvfjfUt0vLi=w@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch]: RM#1432 - File Browser -
 File does not exist error
To: Surinder Kumar <surinder.kumar@enterprisedb.com>
Cc: Marc Linster <marc.linster@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi,

I think we need more changes than just that;

- The path at the top should not be editable (it should be greyed in fact)

- The path at the top should only show the directory path. The
filename should never be appended.

- The CSS needs to be fixed so the filename textbox at the bottom is
never hidden (as it is now if the dialogue opens at a small size).

- Double-click to navigate vs. rename should be modified to work in
part like it does on Mac - Double-click on either the icon or the name
should open the item (browser into a folder, or select and "OK" on a
file), and Click then Enter should rename. I'm hesitant to try to
implement "slow double click to rename" as that would likely need to
be tunable for accessibility reasons.

On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find the patch with issue fixed:
> File Browser - File does not exist error
>>
>> it is due to wrong path formation. strip the leftmost slash only from the
>> file name selected not from the full path.
>
>
> Please review.
>
> Reply to the comments:
> The file browser is virtually unreadable (see screen shot), it does not w=
ork
> like Mac app
> It seems to be font issue to me. I will fix it and send a patch.
>
> When I click on the folder name, it offers to change the folder name inst=
ead
> of opening it (opening works when I click on the folder logo)
> we are performing two operations on double click:
> 1) Navigate inside the folder
> double clicking on folder icon allows to navigate inside the folder.
> 2) Rename folder
> double clicking on folder name allows to rename the file/folder.
>
> When I manage to navigate to the right file and want to open it, I get a =
red
> message =E2=80=98File does not exist=E2=80=99. That message disappears af=
ter 2-3 seconds
> attached a patch with fix.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>


--=20
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--=20
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers