Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smUN0-0069ph-KL for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 08:31:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1smUMy-00A73Y-Hr for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 08:31:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smUMy-00A73Q-9V for pgadmin-hackers@lists.postgresql.org; Fri, 06 Sep 2024 08:31:04 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1smUMv-000Q54-Rn for pgadmin-hackers@postgresql.org; Fri, 06 Sep 2024 08:31:03 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-6b747f2e2b7so16197737b3.3 for ; Fri, 06 Sep 2024 01:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725611460; x=1726216260; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SEoOhd4mHa+DHcmSnjTTVsnQ2XAj0nHu+ZwAyBkppUU=; b=JT98hCgJDGUMDJz8WZRHtQ3lMg/HkqhbOzo4tS2Z15oQpkUCqIfqXoZvu3vqU/dEls WrvuI2yNO/UX9zX0WWlWHwx4ovoto/Mnr9dsfKkmzjxfOXMSvIkGj0aIW29/mfTmizjd 4njG7nYmagFRbVfH2yaHHCYiq668l54wKz62DKuS8paz0wqX1I4uDaj0NGaO+CKW5D/z ghfesRxWst3Kzrelam3pxFX6LxH/NMEVMN2yN0A/B1k6xHNgSOHu3eMl6Hztt5biriPg QWxPTZsGR9U9Wgflpgs9TkkdtxYiCN7NvaYRDB8ojquMpOaNQHv97m4tazc8fDRZ5FKE XMZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725611460; x=1726216260; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SEoOhd4mHa+DHcmSnjTTVsnQ2XAj0nHu+ZwAyBkppUU=; b=mAN5R6uO/iuM5QLIjFr9AxcSd4n7Yh6cvER8hgx9EJQulHfwfqLNOfds9NpPZq4iQl L4pCROTyKpS7bHmPfJcaiVC7bMEGgTI+2dvRpARfd2vDQTlBEbCqzD0FhPI5fX46g3pV OHEGqDTyZYZrqrkLgxtnm9461iDcUZR5wjIqZz6JsJMxR6ISS3B1E3+dy4VDAXX+TR2e /FlV2yS1tnKkmqbNBDyuChfDy4HpXaaayRb2Tgv1nzrRtOKiy2PrJvuMP9RTo1pWxOPE 7Wk4PneGvxPVH+MvVvica4/x/ZN2R9EMV9qW53GPjeOeeQuQqx6XBBYdZ1xTYYRbImcT n3Yw== X-Gm-Message-State: AOJu0Yz3fLjXaOrcgwAME6Raq3EH74rsSEzbZssh2DtCE3ukH466plJy nCdNoo7uL+MAx2KRlVv5lhcp/zeKeDppunKtxzuI2l/ol3kj3GZYptV3VTeJ6tRf9gEQYbUL24W J9hPGOGRYU/8l3t5QDLTkbT1DaDtp89B0+XmbPHpIMBtUZKM= X-Google-Smtp-Source: AGHT+IGgfIS39rEJJGlDegDFdJc2wwE6XeAxx0cX6iJxYzPnw+ZdvE/E1hGjT4uF8uYRUBYr+6TM8kAxRrXFNdwCVPU= X-Received: by 2002:a05:690c:d07:b0:6ae:6c9b:378d with SMTP id 00721157ae682-6db4516d207mr22994277b3.31.1725611460518; Fri, 06 Sep 2024 01:31:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 6 Sep 2024 09:30:48 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000001ffe4e06216f3a33" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000001ffe4e06216f3a33 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 6 Sept 2024 at 09:25, Rohit Bhati wrote: > I have made some more changes with changing background color. > Yeah, that looks weird again, specifically on the selected rows. I believe the issue is that we should not highlight the row number column when a row is selected at all. That makes sense, as we should only be highlighting the columns that would get copied in a copy/paste operation anyway. Also, the bold still doesn't look bold. I think the weight needs to be increased. > > I have attached screenshots showing how the updates look across all theme= s > . > > On Fri, Sep 6, 2024 at 1:51=E2=80=AFPM Dave Page wrot= e: > >> Hi >> >> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati >> wrote: >> >>> Hi, >>> >>> I have removed the border and background color, just made the row >>> numbers bold. >>> >>> I have attached screenshots showing how the updates look across all >>> themes. >>> >> >> That doesn't look bold at all to me - and I think we still need some >> other visual distinction, such as the column background colour. >> >> >>> >>> >>> On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> >>>> >>>> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page w= rote: >>>> >>>>> Hi >>>>> >>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati < >>>>> rohit.bhati@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> I have made changes for issue #7863 >>>>>> based on theme >>>>>> requirements. >>>>>> >>>>>> I have attached screenshots showing how the updates look across all >>>>>> themes for your reference. >>>>>> >>>>>> If the current color does not fit well with the theme or if you have >>>>>> any suggestions for improvements, please let me know. >>>>>> >>>>> >>>>> Is the colour contrast high enough on the row numbers for selected >>>>> rows in the high contrast theme? The black on grey seems like it migh= t not >>>>> be to me, but I haven't tested. >>>>> >>>>> I wonder also if we should make the row numbers bold all the time. >>>>> Thoughts? >>>>> >>>> We can check how it looks. Also the cell border doesn't look good to m= e. >>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> pgAdmin: https://www.pgadmin.org >>>>> PostgreSQL: https://www.postgresql.org >>>>> EDB: https://www.enterprisedb.com >>>>> >>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>>>> >>>>> >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >> >> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ --0000000000001ffe4e06216f3a33 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, 6 Sept 2024 at 09:25, Rohit B= hati <rohit.bhati@enterp= risedb.com> wrote:
I hav= e made some more changes with changing background color.

Yeah, that looks weird again, specifically=C2=A0on = the selected rows. I believe the issue is that we should not highlight the = row number column when a row is selected at all. That makes sense, as we sh= ould only be highlighting the columns that would get copied in a copy/paste= operation anyway.

Also, the bold still doesn'= t look bold. I think the weight needs to be increased.
=C2=A0

= I have attached screenshots showing how the updates look across all themes<= /span>.

On Fri, Sep 6, 2024 = at 1:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <rohit.bhati@ente= rprisedb.com> wrote:
Hi,<= br>
I have removed the border and background color, just=C2=A0made the=C2=A0row numbers bold.

I = have attached screenshots showing how the updates look across all themes.
=
That doesn't look bold at all to me - and I think we sti= ll need some other visual distinction, such as the column background colour= .
=C2=A0


On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khush= boo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Thu, Sep 5, 2024 at 7:11=E2= =80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterprisedb.co= m> wrote:
Hi,

I h= ave made changes for issue #7863=C2=A0based on theme requirement= s.

I have attached screenshots showing how the updates look across a= ll themes for your reference.

If the current color does not fit well= with the theme or if you have any suggestions for improvements, please let= me know.

Is the colour con= trast high enough on the row numbers for selected rows in the high contrast= theme? The black on grey seems like it might not be to me, but I haven'= ;t tested.
=C2=A0
I wonder also if we should make the r= ow numbers bold all the time. Thoughts?
= We can check how it looks. Also the cell border doesn't look good to me= .


--
Dave Page
PostgreSQL: https://www.postgresql.org

PGDay UK 2024, 11th Sept= ember, London: https:/= /2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--0000000000001ffe4e06216f3a33--