Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2bvz-0007pE-UK for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Apr 2017 11:13:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d2bvz-0005ys-Gx for pgadmin-hackers@arkaria.postgresql.org; Mon, 24 Apr 2017 11:13:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d2bvl-0005aK-IB for pgadmin-hackers@postgresql.org; Mon, 24 Apr 2017 11:13:21 +0000 Received: from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d2bvi-0000ED-Qd for pgadmin-hackers@postgresql.org; Mon, 24 Apr 2017 11:13:21 +0000 Received: by mail-io0-x233.google.com with SMTP id a103so187544440ioj.1 for ; Mon, 24 Apr 2017 04:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BAOnbGD5Zg8Sj+YdydeswQIlsUO9t4TsczWmJUNgzaY=; b=z/0Rgujg07c4zm/qvUKJCK0OagCWV6loaDV+SaryxPGGpABhhGo2Ob9auX9RPE+jZC irdvfz9KrefrLumks/iOb8hEMf6stzCgC64CYH89N/8kdl8mp9I07NyHYQvtYi4jSo6/ aYx7903z5ofpjvC0yveXha4wNQ9/bhMWQID2LPCkj9I7Yi3+uDWA3niPJnpoHH2/o0Rj gVswe93UPVlY0uRMxQqNl4DBS6wuCNTxSs2BKLAVU7EgmmN5eVvZGEw8WEU0z35/6rmk VxuOWQEL0PsEwwOeGH2Tz2LkDm3TDjBLViHg2BL/bUVMIr2SjIxqRt3Aft5tt87y05Pk 18Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BAOnbGD5Zg8Sj+YdydeswQIlsUO9t4TsczWmJUNgzaY=; b=Y0K4aqUttxCkfR/uAeazpWiZ8JM3bHqwk8bIf/OxNjvE92d7nNUS59LNutTAzq01dS c/SxyQ2UKJdv0eIPv4HxIFm8iYSJFMHBfUfZspEerpUWM7o0LLaYLQ1Y55SKmsZK2u7Q 4ds2CWmwsOLZ/aEe4Rr+Xfkl2Qrqvoykx75du2m4NvSC+2bf5Ci9Sj6hyttzTjLbWoqT 6MivtUSd+vyqcfhNev+pokrJGxJ3gtWorolddnGM70lJrcMyrN6ejdhBLoCZT2jUzz7O oVvVb6j/S8jCK88pqmySceZzk9sjrAgktS27W80t1ZdoB6Xj0H1B8TTzey/+4UtTcvwu tRlw== X-Gm-Message-State: AN3rC/6SJHaOJZWnmUtROVzahS/44gZznAowrJCVS4yVCsSdvz+X6nG+ l/DiVNisf+0hup7jeUmn+OimSHEMTQDI X-Received: by 10.107.6.219 with SMTP id f88mr4751601ioi.126.1493032396971; Mon, 24 Apr 2017 04:13:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.174.167 with HTTP; Mon, 24 Apr 2017 04:13:16 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 24 Apr 2017 12:13:16 +0100 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Joao Pedro De Almeida Pereira Cc: pgadmin-hackers , Ashesh Vashi Content-Type: multipart/alternative; boundary=001a113f8948a8e745054de7b15b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f8948a8e745054de7b15b Content-Type: text/plain; charset=UTF-8 Ashesh, can you review/commit this please? On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Hackers, > > We found out that when you are connected to a GreenPlum database and try > to get Dependents and Dependencies of an object the application was > returning a SQL error. > > This patch splits the SQL query used to retrieve the Dependents, > Dependencies, and Roles SQL file into multiple versioned files. > Add Unit Tests for each file. > Also added __init__.py files to other test directories to run the tests in > them. > Add ORDER BY into Copy Selection Feature test to ensure the results are > retrieved always in the same order > Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip it > for versions less than 9.1 > > Thanks > > Joao & Sarah > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113f8948a8e745054de7b15b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ashesh, can you review/commit this please?

On Fri, Apr 21, 2017 at 8:4= 2 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.= io> wrote:
Hi Hackers,

We found out that when you are connected to= a GreenPlum database and try to get Dependents and Dependencies of an obje= ct the application was returning a SQL error.

This= patch splits the SQL query used to retrieve the Dependents, Dependencies, = and Roles SQL file into multiple versioned files.
Add Unit Tests = for each file.
Also added __init__.py files to other test directo= ries to run the tests in them.
Add ORDER BY into Copy Selection F= eature test to ensure the results are retrieved always in the same order
Renamed the Scenario of the=C2=A0xss_checks_pgadmin_debugger_t= est and skip it for versions less than 9.1

Thanks<= /div>

Joao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
--001a113f8948a8e745054de7b15b--