Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smAjZ-003myA-Vi for pgadmin-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 11:33:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1smAjY-008VyL-Hn for pgadmin-hackers@arkaria.postgresql.org; Thu, 05 Sep 2024 11:33:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smAjY-008Vwz-69 for pgadmin-hackers@lists.postgresql.org; Thu, 05 Sep 2024 11:33:04 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1smAjV-000Gaj-S7 for pgadmin-hackers@postgresql.org; Thu, 05 Sep 2024 11:33:03 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-533463f6b16so768577e87.1 for ; Thu, 05 Sep 2024 04:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725535980; x=1726140780; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NidBD8g++SB+Dx6HeA+oJwCMZtLV64tHab3k3Gzwsmk=; b=kNQClzsSn9D4HbGiz10dNeJOjG4KUmHuNJEU9Y2qFKLTTT7Uzg42Y0/T5FlpzeE6mh Phi2xx9C2ErKakmnbPFvHGPbJyvBRpz/2Cbtp34E90TIgQ06RPCwlfCNQKgOJ33B2wKl hqh5DFSN60DdakU7ZcyBzJppTxewmJHkPs3wCpvcNnQKptOCaYTH2HwRJnKU8fltI7CL EtckqWObKat6WgyQ62FWtww/zu+eN1HjaCfiAT9Zubm+Pl4vx4AbK2O5nAYGKT0FBRIJ gceVTZFam5gbftui6NHc5ZvdOSlfufb01v6M6XB8iH6XjKxeSwuMLFmdqz9l0F3/08sx PtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725535980; x=1726140780; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NidBD8g++SB+Dx6HeA+oJwCMZtLV64tHab3k3Gzwsmk=; b=srMR1QrOEQbOpBypzBCQb3s4Et8F3InT/0FPgmwcdJZlphi+XrnVN9KHWo5q4gZ3YD EBjQBCRL0TvTn6rqRHSbs9jOnUMOI1vHYJs1ktbT2KBgVKnpJJsLvS6OOJ9VeTYdtAhM GXYw8aOFDOnZ4nHZsvlroMXWUy3SfsMBs4gLbOATt63G/mdqPNc1gkyLOEV9pzIvI0Os RsCg74T0WRxxB3FWVgPlW85VhCXrFUPco9+SX/hlA2ywS/Gqssl9jPjB+oCaX27mFBqt S5po4pRHsabsdo26KuMSG7RcBseB6+emhLy/zgZ6hhGy6CnQf7be+OYCDldeV2cDWa/C VbeQ== X-Gm-Message-State: AOJu0YzB9B/cvbV8nU+oF8MjmlhaQSiSDeacRjPvrGiUe6wowgYObVVz tbBr5g3q2sV41z677pTr0UapcQ1rP5sPq8bLJuzn/Rzfl/zo8yc/Yoia+MmJCjGXMBSYFDEE4hK 4OxwWIKNhxiJZ5MSPSxDkzvlPXxrD89CYXDM1iCgLwD1BBuQ= X-Google-Smtp-Source: AGHT+IFEMvq9vwjClyvszAlwvfo5IMJ6deQ+yrEWpCAj4iSDeDOKXZzawTdY15R8zJ1MdDqroLa/FpQQlauQbvzwDIM= X-Received: by 2002:a05:6512:304b:b0:52e:9b4f:dd8c with SMTP id 2adb3069b0e04-53565f22b01mr3807864e87.35.1725535979597; Thu, 05 Sep 2024 04:32:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Thu, 5 Sep 2024 12:32:48 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000001c918306215da74f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000001c918306215da74f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Thu, 5 Sept 2024 at 12:19, Rohit Bhati wrote: > Hi, > > Currently it is just theme based, whenever the user changes the theme > accordingly the color changes. > Not for any specific preference option for this right now, But if we want > that we can add. > Let's just go with it for now, and if people don't like it, we can add a preference. > > And if i am not wrong you are talking about this #7863 > . If this is the > issue then I can work together on both. > Yes, that's the one :-) > > > Rohit Bhati > EnterpriseDB > > On Thu, Sep 5, 2024 at 3:51=E2=80=AFPM Dave Page wrot= e: > >> Hi >> >> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati >> wrote: >> >>> Hi Hackers, >>> >>> Please check the updated attached screenshot for an alternate >>> background color of table rows. >>> The images also shows alternate row color with some selected rows color >>> from the table. >>> >>> >> I think that looks good. Are you making it a preference, so users that >> prefer non-stripey grids can keep the current look? >> >> Whilst you're hacking on that, I believe there is another ticket (which = I >> can't find right now) about changing the colour of the row number column= to >> give it better visual distinction from the data columns. Probably worth >> working on that one at the same time? >> >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >> >> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ --0000000000001c918306215da74f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Thu, 5 Sept 2024 at 12:19, Rohit Bhati <rohit.bhati@enterprisedb.com= > wrote:
Hi,

Currently= it is just theme based, whenever the user changes the theme accordingly th= e color changes.
Not for any specific preference option for this right n= ow, But if we want that we can add.

Let's just go with it for now, and if people don't like it, we c= an add a preference.
=C2=A0

And if i am not wrong you are talking about this=C2=A0 #7863=C2=A0. If this is the issue then I can work together on both.
<= /blockquote>

Yes, that's the one :-)
=C2= =A0


Rohit Bhati
Enterpris= eDB

On Thu, Sep 5, 2024 at 3:51=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, 5 Sept 2024 at 08:2= 7, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote:
Hi Hackers,

Please=C2=A0check the updated at= tached screenshot=C2=A0 for an alternate background color of table rows.The images also shows alternate row color with some selected rows color fr= om the table.


I think that lo= oks good. Are you making it a preference, so users that prefer non-stripey = grids can keep the current look?

Whilst you're= hacking on that, I believe there is another ticket (which I can't find= right now) about changing the colour of the row number column to give it b= etter visual distinction from the data columns. Probably worth working on t= hat one at the same time?

--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--0000000000001c918306215da74f--