Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fW6Ju-0005xe-7r for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jun 2018 20:36:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fW6Js-0000fG-J1 for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Jun 2018 20:36:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fW6IN-0008TG-Ut for pgadmin-hackers@lists.postgresql.org; Thu, 21 Jun 2018 20:35:08 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fW6IK-0002bB-OP for pgadmin-hackers@postgresql.org; Thu, 21 Jun 2018 20:35:07 +0000 Received: by mail-wm0-x241.google.com with SMTP id p11-v6so8386305wmc.4 for ; Thu, 21 Jun 2018 13:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=00BaQNrDDIlrIJPP2l+3Jmvj7CGyqRh6zytUNiN5NXE=; b=BwOn2ZREJ0VfQ7qZnvhIlLUeWe/jv4LAuTFdtHyyvNq8fJiOckiKiFJzAYCbrVJzDf MEIiALWQpkv+590k5cNsyLKSw+5RaeY4X7lm+EcNjngkWnq9p/J9gJ/wYogOgsD1RZTU J+vFmY8yfZU0YFecqApY1NZWOzZElr+lFBU+4jZqegxi6xw03x2kIe6BKaW2UjpR+yyx p1z2GEAZTh/PDj5Y7ZK3xmU0tYy4kaQ4N9LDpbdS3mOVXTxYl4HryeFIO7yN2O6WSfKp 0TOh6GlrIn1wrYFxY/a71H3JBIWTN7D6/otnTbAwi9L70FbIa6H4ytWK3Mxzk+xu3H0G 9IrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=00BaQNrDDIlrIJPP2l+3Jmvj7CGyqRh6zytUNiN5NXE=; b=EMu4Pj0l9r01fqzqZPa5AenaAQ7amgWBXbGxOcNi+LoK3wUd3ZTgGy13JY+wHd7RhJ XmfNcKu9U06UbZteSjj/xahK0NMobEBTKCBQXgR+tmKcQz4dz4PCVudLWVmmEb3t1xjj yfcpCh+ZZHIYLU1nI2/D25G5isQY4JPA0nxn9HuMehOFpYtS9oFvD3l/nz4mHtj7r5Kq LVWXD8O9Lu4jLgG7mJsIoJSUUZmJnJ4Z2W72QDAIEeN+tSCnJSdodlip30vYdsci1ZTS oxwFw9ZID5vNxltgCuAk8vUy0FT3K/4HgL+uwu/6ZNpVuEuq/SsWWsRXNb/qOL2VClMj b+4w== X-Gm-Message-State: APt69E00woz2oS4PbtlDhlJa2Tn9nVD07wl7rPP122jq45vdEGBO2hF9 uN4WerDYcftjLoKNq8/YCGAbNjBoOd+y4LwgvcrNZQ== X-Google-Smtp-Source: ADUXVKK6cnhJfI9L/41/X1AIjCO1GoDUhiUqqlrgqXaDUoxiTqgJEkMKQ6Gw8kUHZ2kOZhTGznG0gEsA0aicXGC6uY8= X-Received: by 2002:a1c:b7d4:: with SMTP id h203-v6mr6111557wmf.161.1529613303198; Thu, 21 Jun 2018 13:35:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:2907:0:0:0:0:0 with HTTP; Thu, 21 Jun 2018 13:35:01 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 21 Jun 2018 21:35:01 +0100 Message-ID: Subject: Re: [pgadmin4][Patch]: Fixed minor issue in auto discover server when entry is blank in the config file To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000094c8e5056f2cd9e2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000094c8e5056f2cd9e2 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi wrote: > Hi Hackers, > > I have found one minor issue in auto discovery logic. *getint* function > of ConfigParser throws exception if the value of the parameter is blank > in the config file. Example: *Port=* > > Because of that exception pgAdmin4 unable to discover all the valid > servers. Attached is the patch to fix that. Please review it. > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000094c8e5056f2cd9e2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Thu, Jun 21, 2018 at 8:32 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Hackers,

I have fo= und one minor issue in auto discovery logic. getint=C2=A0function of ConfigParser throws exception if the value of the p= arameter is blank in the config file. Example:=C2=A0Port=3D=C2=A0

Because of that exception pgAdmin4 unable to discover all the vali= d servers. Attached is the patch to fix that. Please review it.=C2=A0
=

--
<= b>Aksh= ay Joshi=
Sr.= Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--00000000000094c8e5056f2cd9e2--