Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlrWM-0005Vk-VF for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 Jul 2019 09:07:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hlrWL-0008P0-R2 for pgadmin-hackers@arkaria.postgresql.org; Fri, 12 Jul 2019 09:07:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlrWL-0008Ot-Jt for pgadmin-hackers@lists.postgresql.org; Fri, 12 Jul 2019 09:07:13 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlrWI-0001gk-Vx for pgadmin-hackers@postgresql.org; Fri, 12 Jul 2019 09:07:13 +0000 Received: by mail-wm1-x342.google.com with SMTP id g67so4088313wme.1 for ; Fri, 12 Jul 2019 02:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YPUfW07SKxltO0HSMYPob6F5qf7Iawq7/Eu19WAQjEM=; b=HJJsBW3MZC8A5tozY74LSrvexLhi86ybaSA0r6BXIKhI2ihfF/IvcrE2lCdcZ8DiuO rEjMzbgUqa/J0XK1uCPjptou81Mnb7lbogYOqD3xyBmy1IUMJwK688GTScJly2SOAwZR dJtQ5iRtUGsQtFoK5MYT4HiEGf3C7IaJQYDAcg7KFnBEtTd8HeOGvLMFksaD7VAuuYs8 AqIQW2iM5lp+lOOwX4R04rLkwPXeStAHjIFDjY2RcPnDk5RX/xqQUvz273vXaAdMY5QG 6imjudVQE4QaLI2BZthgb5vKy/mko7fc/EemdWeIQ1Obdzao7mKRMh+26ybLYKjGY9u1 bpNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YPUfW07SKxltO0HSMYPob6F5qf7Iawq7/Eu19WAQjEM=; b=dl7jamhHmp/7de3IMAT5T8Lr8VvD7yVMwQMJJsVCUGjCHsaH0oSOD6DiIllYspz0B5 To6l6GjW1tThliVDh6cC8kmA/S/yV8NN17YrP5rQfLxNNm3ofSIvZnijnQRheeHCBlsm IHlE1pAfafy4XUfadEUb11cj7KrE5J6JzqqUGolGDiMwc8l5Mil1M8HJaXPk/LQ+//0o TqNoc4HqV/KGeNUWkFygvUS6EHNCyAbpCHpBBWEDZT2fQ5YTt8hGrDyJz4UiRuz9ATfR 7S0NgJU1FIZ6SoMwloTYVStvUYCCYdYsTH262X+skgMdY90YVdGmMYssSvH2bmXe/Zta C2Tg== X-Gm-Message-State: APjAAAWcyuDdy0HfAEuPZcQAlUwLtei2KR37O7Q3PjMEEETbXE8JW9nR RhtLCyXwVkqC3/XRL9/Kxymc3nJL74JvWqHoZCp/iw== X-Google-Smtp-Source: APXvYqxIwNb5Pb5GbzJs5PTOdQ7BZkr+0r76WcVJGEjdpQw2/nuUfyMe8xSa9UKUQ/3mVYNDyCTbdWz/PF0S4Ea/pQY= X-Received: by 2002:a1c:f018:: with SMTP id a24mr8505407wmb.66.1562922429980; Fri, 12 Jul 2019 02:07:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 12 Jul 2019 10:06:57 +0100 Message-ID: Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control To: Ganesh Jaybhay Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000403cdf058d783c43" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000403cdf058d783c43 Content-Type: text/plain; charset="UTF-8" Thanks - committed as the IE fixes, with the Jasmine stuff as a bonus :-) On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay < ganesh.jaybhay@enterprisedb.com> wrote: > Hi Dave, > > Please find the attached patch for jasmine tests fix. Patch also includes > fixes for edit/delete cell focus on IE by Murtuza. > > Regards, > > Ganesh Jaybhay > > On Thu, Jul 11, 2019 at 3:49 PM Dave Page wrote: > >> Hi Ganesh, >> >> It looks like this has broken the Jasmine tests (which I admit I forgot >> to run before committing). Can you fix ASAP please? >> >> Thanks. >> >> On Thu, Jul 11, 2019 at 10:14 AM Dave Page wrote: >> >>> Thanks - patch applied with some doc tweaks. >>> >>> No need for a new ticket! >>> >>> On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay < >>> ganesh.jaybhay@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Ticket number 3919 refers to keyboard accessibility issues for sub-node >>>> control and back grid but this patch covers only sub-node control. Should I >>>> create new one? >>>> I have added the screenshot having newly added shortcut and updated >>>> keyboard shortcut rst file. Also moved the code changes from backgrid.js to >>>> backgrid.pgadmin.js. >>>> >>>> Please find the attached updated patch. >>>> >>>> Regards, >>>> Ganesh Jaybhay >>>> >>>> On Tue, Jul 9, 2019 at 9:28 PM Dave Page wrote: >>>> >>>>> Hi, >>>>> >>>>> What's the ticket number for this? That's a fair amount of code for a >>>>> one-line description. There are also no doc changes describing how to >>>>> navigate the sub-node control that I can see. >>>>> >>>>> Also; instead of changing the repo used for backgrid, can we not >>>>> un-vendorise it? >>>>> >>>>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay < >>>>> ganesh.jaybhay@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the patch for keyboard accessibility of sub-node control. >>>>>> It also covers sub-node dialog forward/backward tab navigation with >>>>>> shortcuts. >>>>>> >>>>>> Kindly review. >>>>>> >>>>>> Regards, >>>>>> Ganesh Jaybhay >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000403cdf058d783c43 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - committed as the IE fixes, with the Jasmine stuff= as a bonus :-)

On Thu, Jul 11, 2019 at 7:40 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com= > wrote:
=
Hi Dave,

Please find the attached patch= for jasmine tests fix. Patch also includes fixes for edit/delete cell focu= s on IE by Murtuza.

Regards,

<= div>Ganesh Jaybhay

On Thu, Jul 11, 2019 at 3:49 PM Dave Page <dpage@pgadmin.org>= wrote:
Hi Ganesh,

It looks like this has broken the Ja= smine tests (which I admit I forgot to run before committing). Can you fix = ASAP please?

Thanks.

On Thu, Jul 11, 2019 at = 10:14 AM Dave Page <dpage@pgadmin.org> wrote:
Thanks - patch applied with some doc t= weaks.

No need for a new ticket!

On Thu, Jul 11, 20= 19 at 7:00 AM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com> wrote:
=
Hi Dave,

Ticket number 3919 refers to k= eyboard accessibility issues for sub-node control and back grid but this pa= tch covers only sub-node control. Should I create new one?
I have= added the screenshot having newly added shortcut and updated keyboard shor= tcut rst file. Also moved the code changes from backgrid.js to backgrid.pga= dmin.js.

Please find the attached updated patch.

Regards,
Ganesh Jaybhay

On Tue, Jul = 9, 2019 at 9:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi,

What&= #39;s the ticket number for this? That's a fair amount of code for a on= e-line description. There are also no doc changes describing how to navigat= e the sub-node control that I can see.

Also; inste= ad of changing the repo used for backgrid, can we not un-vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.co= m> wrote:
Hi Hackers,

Attached = is the patch for keyboard accessibility of sub-node control. It also covers= sub-node dialog forward/backward tab navigation with shortcuts.
=
Kindly review.

Regards,
G= anesh Jaybhay


--
Dave P= age
Blog: http= ://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterpri= sedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
B= log: http://pgsna= ke.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000403cdf058d783c43--