public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: Björn Harrtell <[email protected]>
Cc: Guillaume Lelarge <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: ]GTK 3
Date: Thu, 7 Jan 2016 11:58:25 +0000
Message-ID: <CA+OCxoxS75cGyJoW6Ywd-mf9ZCZ7hbrU92qWKycc1M5zESOcAA@mail.gmail.com> (raw)
In-Reply-To: <CANhDX=aixcuBpTy0-Ciu-cPfKYJ_uZQa7ZtAK0NfnXUnR-3ZiA@mail.gmail.com>
References: <CANhDX=a8ZJUvWTDbx7eCc2bqe9i6xkZKTcRyPXpb6p3uEGaWyg@mail.gmail.com>
<CAAeC-SsGLG7_9mAsZpCZjX3TrQr_C+su3erM+vvsi=KkfatfKg@mail.gmail.com>
<CANhDX=b91i+xq1z9YWyXvGAhfHAD4gwG1QOAx3sJ7xv+p0PijQ@mail.gmail.com>
<CANhDX=bE9Wx6D2jNzDcFrMGvMiRTHfW9Svup6SAxzV2Pb=BdvQ@mail.gmail.com>
<CAECtzeXhbbCG7XPgeRpMKrnpRxJO6HsnE9v=vgxEb+ndFps7AQ@mail.gmail.com>
<CA+OCxowUQ=B3kCyKfOFiiMSkLhj+oz5os=fs=0ihEqvv4r+UZw@mail.gmail.com>
<CANhDX=YhqQtmDRo8Gb0Wrmg05bGwX690zpZxH4-F-DbCvbrXog@mail.gmail.com>
<CA+OCxoxERDMQq_0AN9-B=eGTV=T+B=JvjkNzJgaRttOvxi4SBg@mail.gmail.com>
<CANhDX=aixcuBpTy0-Ciu-cPfKYJ_uZQa7ZtAK0NfnXUnR-3ZiA@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Thu, Jan 7, 2016 at 11:56 AM, Björn Harrtell
<[email protected]> wrote:
> 2016-01-07 12:10 GMT+01:00 Dave Page <[email protected]>:
>>
>> On Thu, Jan 7, 2016 at 7:47 AM, Björn Harrtell <[email protected]>
>> wrote:
>> > Yes, sorry, I made both the comments and the patch too hastily and agree
>> > that it should not be removed based on my findings.
>> >
>> > It should be noted though that wx3 or GTK3 by themselves is not to blame
>> > here, I'm guessing it should affect wx2 and GTK2 too because it's more
>> > of a
>> > logical problem in where a user created the server node in a light theme
>> > which will save a white color for the background... then if the user
>> > switches to a dark theme, the saved white color is problematic.
>>
>> Well the same applies in a more default theme if you use a dark
>> background. I guess the answer is to say "don't do that then" - I'd
>> certainly prefer not to have pgAdmin try to second guess what colours
>> might work against whatever the theme has for the current text colour.
>
>
> Agreed. But what about saving the color only when making an active choice so
> that the current system window background color is used until the user have
> customized the color?
That seems perfectly reasonable.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: ]GTK 3
In-Reply-To: <CA+OCxoxS75cGyJoW6Ywd-mf9ZCZ7hbrU92qWKycc1M5zESOcAA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox