MIME-Version: 1.0
References: 
 <CAM9w-_=RbH2Nt9cWRf5ZaE509-a2nxvDxdNYN=BakLGvM288Lg@mail.gmail.com>
In-Reply-To: 
 <CAM9w-_=RbH2Nt9cWRf5ZaE509-a2nxvDxdNYN=BakLGvM288Lg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 17 Jun 2021 14:56:35 +0100
Message-ID: 
 <CA+OCxoxSOEBPErd-FXTHLi6gpVbo3TzkVQcZwzMg9P3+Cmnj6w@mail.gmail.com>
Subject: Re: [pgAdmin][RM6130] React based framework for properties dialog and
 port Server Group, Server and Database dialogs
To: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000130b2605c4f6946a"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoxSOEBPErd-FXTHLi6gpVbo3TzkVQcZwzMg9P3%2BCmnj6w%40mail.gmail.com>
Precedence: bulk

--000000000000130b2605c4f6946a
Content-Type: text/plain; charset="UTF-8"

Hi

On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal <
aditya.toshniwal@enterprisedb.com> wrote:

> Hi Hackers,
>
> Attached patch marks the beginning of migrating properties dialog/tab to
> React based code, which is easy to maintain, performant and testable using
> automation.
> Patch includes:
> - Framework for creating React based dynamic form view out of a
> pre-defined UI schema. Previously, it was based on Backform/Backbone.
> - The new framework and components will use MaterialUI as base.
> Previously, Bootstrap/Backform/jQuery components were used.
> - The new code uses JSS instead of CSS since material ui and most modern
> React libraries also use JSS. In future, this will allow us to change
> the theme in real-time without refresh.
> - 90% code covered by 80-85 new jasmine test cases.
> - Server group node UI Schema migration to new, with schema test cases.
> - Server node UI Schema migration to new, with schema test cases.
> - Database node UI Schema migration to new, with schema test cases.
> - Few other UI changes.
>

Nice!


>
> PS: Until all the nodes are migrated, this will not go in the main branch.
>

Yeah, how are we going to manage this? I agree with building it out in a
branch until we have full coverage of the dialogues, but I'm concerned that
it'll become a merge nightmare. Though, I guess we aren't touching the
dialogues much for other things right now, so maybe not.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--000000000000130b2605c4f6946a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote"><div dir=3D"lt=
r" class=3D"gmail_attr">On Thu, Jun 17, 2021 at 11:01 AM Aditya Toshniwal &=
lt;<a href=3D"mailto:aditya.toshniwal@enterprisedb.com">aditya.toshniwal@en=
terprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:sol=
id;border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><d=
iv style=3D"font-family:verdana,sans-serif">Hi Hackers,</div><div style=3D"=
font-family:verdana,sans-serif"><br></div><div style=3D"font-family:verdana=
,sans-serif">Attached patch marks the beginning=C2=A0of migrating propertie=
s dialog/tab to React based code, which is easy to maintain, performant and=
 testable using automation.</div><div><div style=3D"font-family:verdana,san=
s-serif">Patch includes:</div><div style=3D"font-family:verdana,sans-serif"=
>- Framework for creating=C2=A0React based dynamic  form view out of a pre-=
defined UI schema. Previously, it was based on Backform/Backbone.</div><div=
 style=3D"font-family:verdana,sans-serif">- The new framework and component=
s will use MaterialUI as base. Previously, Bootstrap/Backform/jQuery compon=
ents were used.<br></div><div style=3D"font-family:verdana,sans-serif">- Th=
e new code uses JSS instead of CSS since material ui and most modern React =
libraries also use JSS. In future, this will=C2=A0allow us to change the=C2=
=A0theme in real-time without refresh.</div><div style=3D"font-family:verda=
na,sans-serif">- 90% code covered by 80-85 new jasmine test cases.</div><di=
v style=3D"font-family:verdana,sans-serif"></div><div style=3D"font-family:=
verdana,sans-serif">- Server group node UI Schema migration to new, with sc=
hema test cases.</div><div style=3D"font-family:verdana,sans-serif">- Serve=
r node UI Schema migration to new, with schema test cases.<br></div><div st=
yle=3D"font-family:verdana,sans-serif">- Database node UI Schema migration =
to new, with schema test cases.</div><div style=3D"font-family:verdana,sans=
-serif">- Few other UI changes.</div></div></div></blockquote><div><br></di=
v><div>Nice!</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;=
border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>=
<div style=3D"font-family:verdana,sans-serif"><br></div><div style=3D"font-=
family:verdana,sans-serif">PS: Until=C2=A0all the nodes are migrated, this =
will not go in the main branch.</div></div></div></blockquote><div><br></di=
v><div>Yeah, how are we going to manage this? I agree with building it out =
in a branch until we have full coverage of the dialogues, but I&#39;m conce=
rned that it&#39;ll become a merge nightmare. Though, I guess we aren&#39;t=
 touching the dialogues much for other things right now, so maybe not.</div=
><div>=C2=A0</div></div>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><=
div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"https://pgsnake.blogspot.com"=
 target=3D"_blank">https://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br=
><br>EDB: <a href=3D"https://www.enterprisedb.com" target=3D"_blank">https:=
//www.enterprisedb.com</a><br><br></div></div></div>

--000000000000130b2605c4f6946a--