Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3MNT-00046G-WE for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 13:53:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3MNT-0003iA-1T for pgadmin-hackers@arkaria.postgresql.org; Tue, 03 Apr 2018 13:53:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3MNS-0003hz-PJ for pgadmin-hackers@lists.postgresql.org; Tue, 03 Apr 2018 13:53:34 +0000 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3MNO-00083Q-62 for pgadmin-hackers@postgresql.org; Tue, 03 Apr 2018 13:53:34 +0000 Received: by mail-wm0-x231.google.com with SMTP id g8so9990987wmd.2 for ; Tue, 03 Apr 2018 06:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=5Yc+HDzkA+EOSiGbTBs0z26IYS4Se4/ujkQW4rkV6/Q=; b=DwduFpiP7rXheLYC6pK6lx0Ql6dkl2HkZBW5warj51UUGP/wX7E7JjYITBIUHpTpTv Mb9EQeQDiMoWqxy21105X9H4wYd0Yy1Uq3XYaczMKTy+zvwEi+C7zljVPJpUo7Y9ZNCV HyH+chYGfjgtcOczxR3Oy/1LBmbmmZ9FUXVkMO+nAE4FaI9Uii3vVQRCrwNURMeZahlQ I99kyCze9YirfPmRQZQXmTxMBm7Qw5cnx0HoAlzXDqWCv8a2rZeQf68BAn6G9u3hAKqE fg2Q3GqzVDz8gHVBTB3G5AXqF8L5kOiP/2RpG7pOcw9gSf/U4CiIj48naunOBHtTUoHV xSeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=5Yc+HDzkA+EOSiGbTBs0z26IYS4Se4/ujkQW4rkV6/Q=; b=gyrjzXaJU0S9sQGCGfqf8yRpXHKL1aGCxaJUT1s6bbtSlVZTihI07DPnMy6kdhDXC8 i0+HymNQJ5f0FYeidP9MH4En/U02rbZNo2QiCv9f1hjnmXYMfaGBnZTiqrg/rnLAoEnT VzkQzrVvBAE8I5ufhkjmOds/cehhTmnBZXR2PCv8+YyxaCJXhUvq/VeE3PKgm4mrfWyd m6Zho1cYqz8c3mNjX15MFA4qoDY1S7qO3UudLQpVby9H0SwnRzJtn3Ri31Gs3DnYkUgv i7x5SvHwj5UNRQf6fvzLQS5VQb5VynhQiK1urtScAx+ruYdXuQBJMB8ZVTBITqp5M6E/ x7cg== X-Gm-Message-State: AElRT7GvoJx4qUlKA7GqQ6LjAZcx6wfE0+DNHRzaynD6CCodQUiSJl4m ZjT2bNhoFTGAdORAMsfPJKgmRB9MBIGIXEpeWzeZUQ== X-Google-Smtp-Source: AIpwx4+dr8yXGu4M7mx2MKQC4FTpH7pi05lQlGNLR4hZYxsMa/amMRQAJ1F9aaIbmwuVtZiESJ8d5DjQoZLfkVU9XQ0= X-Received: by 10.28.91.65 with SMTP id p62mr4815964wmb.140.1522763608423; Tue, 03 Apr 2018 06:53:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 3 Apr 2018 06:53:27 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 3 Apr 2018 14:53:27 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1144161af50ecc0568f20777" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1144161af50ecc0568f20777 Content-Type: text/plain; charset="UTF-8" Hi Thanks - I've committed this, however, could you send me an updated screenshot for the docs? The one you sent was a different size and colour depth from the others (and looked like a different scale). On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Thu, Mar 29, 2018 at 6:54 PM, Dave Page wrote: > >> Hi >> >> On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Mar 26, 2018 at 6:07 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi < >>>> khushboo.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix RM #1978: Add an option to allow >>>>> user to disable alertifyjs and acitree animations. >>>>> >>>> >>>> I think these really need to be per-user settings, not >>>> per-installation.. Whether or not animations are shown is really a matter >>>> of personal taste and circumstance. >>>> >>>> Right, it should be per-user settings. Please find the attached >>> updated patch. >>> >> >> I found some issues I'm afraid: >> >> - The label "Enable dialogues/notifications animation?" should read >> "Enable dialogue/notification animation?" >> >> Changed. > >> - Disabling treeview animation only seems to affect the main browser >> treeview, and not others in the application (e.g. the one on the >> Preferences panel). >> >> Fixed > >> - After disabling dialogue/notification animations, I cannot re-enable >> notification animations. If I flip the switch back on, dialogue animations >> immediately start working again, but notification animations don't even >> work following a reload. >> >> Fixed. > >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > Thanks, > Khushboo > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144161af50ecc0568f20777 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

Thanks - I've committed this, ho= wever, could you send me an updated screenshot for the docs? The one you se= nt was a different size and colour depth from the others (and looked like a= different scale).

On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the atta= ched updated patch.

On Thu, Mar 29, 2018 at 6:54 PM, Dave Page <dpage@p= gadmin.org> wrote:
Hi

On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <<= a href=3D"mailto:khushboo.vashi@enterprisedb.com" target=3D"_blank">khushbo= o.vashi@enterprisedb.com> wrote:


On Mon, Mar 26, 2018 at 6:07 PM, Dave Page <dpage@= pgadmin.org> wrote:
Hi

On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
=
Hi,
=
Please find the attached patch to fix RM #1978: Add an optio= n to allow user to disable alertifyjs and acitree animations.

I think these really need to be per-u= ser settings, not per-installation.. Whether or not animations are shown is= really a matter of personal taste and circumstance.

Right, it should be per-user setti= ngs.=C2=A0 Please find the attached updated patch.=C2=A0
<= /div>

I found some issues I'm af= raid:

- The label "Enable dialogues/notificat= ions animation?" should read "Enable dialogue/notification animat= ion?"

C= hanged.=C2=A0
<= div>- Disabling treeview animation only seems to affect the main browser tr= eeview, and not others in the application (e.g. the one on the Preferences = panel).

Fixe= d=C2=A0
= =C2=A0- After disabling dialogue/notification animations, I cannot re-enabl= e notification animations. If I flip the switch back on, dialogue animation= s immediately start working again, but notification animations don't ev= en work following a reload.

Fixed.=C2=A0<= /div>
Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter= : @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgre= SQL Company

Thanks= ,
Khushboo



--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1144161af50ecc0568f20777--