Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX6uK-0002Xb-Rz for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:17:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX6uK-00089M-AQ for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 13:17:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX6u7-0007vH-2s for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:17:11 +0000 Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX6u3-0005Vl-34 for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 13:17:10 +0000 Received: by mail-it0-x232.google.com with SMTP id u186so12121565ita.0 for ; Tue, 09 Aug 2016 06:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N0+tOWiNTfkrZRU7ai5o/yX0NO9Y2P2U2GKmempKVYE=; b=qiH4mmj/FRDe8Ymtciw0kmfcosVXCRL3qCRhFaOEdjR/ydPu+6gn+tJU4lXzYDrHi2 oDV0LNIM6rzIg8ebng2aQsKizUOWUqFJpCjS2YkV4+8FifywvPeyHL9DCEtppB2lqKVV nE58eaRvi79Iiy0IUsw69J5qe+/UisRrudfc6LPXONo7Z59GGghEXBH8sWrM85ek6FRB T9lO8/hZXressZxxp2d+djhMu/diN5RmMR/Omlrw+uNGvmQJfIKiL5swhQVzqdKhFu+K p8phjWrLvYr+slcNGOCZ8gOJdxBoeinLYKogezt/sU0aCjuI2fLG1iqh+UueZ2rzHOrh K0QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N0+tOWiNTfkrZRU7ai5o/yX0NO9Y2P2U2GKmempKVYE=; b=fKnFSa+Vt19WhAeBaz3TK4wAFS7SJBIep8mrLhLi9u+G39Sea21q/RBh8feg2FOmS2 YWgbZfnuySjYsWXbbXBBKcNJABdAt816xlYnBqSkSg2tf5uoOaegWHrV/dmnVnrhPj2Q Km8bicfuXA67/4PJl+l/CUZTfk5GkwX1/613DiRMPc2jtOzX7ZbcRD3pn46CHS1HrDLW ZFH/7kwbBiCc2vMjlWvOz0bBlMYYU+vTCiA0RquWKIbz1v1EidHR4wX6PY7RE6sly/iU hdEXOWYqfsG35cPPQns6aNcYBJQ7L6RMAsE/SFBRA5XqmeHOhDNKUmjofcNcyBDOVEVX wxwA== X-Gm-Message-State: AEkoouuku72sYMxoQqkEXwvpGVQ0sw42WeYaXTfVmRGjn5b02hx45tpnXYUk7KqwFWLPD/9EynVBLKN8+jd4yA== X-Received: by 10.36.14.20 with SMTP id 20mr24627508ite.88.1470748624721; Tue, 09 Aug 2016 06:17:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Tue, 9 Aug 2016 06:17:03 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 Aug 2016 14:17:03 +0100 Message-ID: Subject: Re: PATCH: To fix the issue where message panel was showing incomplete info (pgAdmin4) To: Ashesh Vashi Cc: Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1143840e54b19e0539a359d7 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143840e54b19e0539a359d7 Content-Type: text/plain; charset=UTF-8 On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi wrote: > On Tue, Aug 9, 2016 at 6:34 PM, Dave Page wrote: > >> >> >> On Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Tue, Aug 9, 2016 at 6:28 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala >>>> wrote: >>>> > Hi, >>>> > >>>> > PFA patch to fix the issue where message panel was showing incomplete >>>> info. >>>> > We may still miss some messages from Psycopg2 driver due to limited >>>> size of >>>> > notices queue. >>>> > (RM#1523) >>>> >>>> A few thoughts on this (mostly based on my discussions with Ashesh): >>>> >>>> 1) You seem to have removed the poll delay. I assume that is to try to >>>> avoid missing messages? Can we re-introduce the delay (to avoid >>>> excessive network requests), but collect messages while we're waiting? >>>> >>> Using thread? >>> Start a thread during the timeout? >>> >> >> Not necessarily. If we want a 2 second polling delay, we could just sleep >> for 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, >> return to client. >> > That's a very huge delay in practical. > We were hardly waiting for during poll (that was in milliseconds), but - > still we were loosing a lot of the messages. (a lot more from the current > implementation). > What was the original delay? Now there appears to be none at all. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > >> >> >>> >>>> 2) If I run VACUUM, whilst I see messages as I should now, there is no >>>> query time summary as there is for a query that returns data. >>>> >>> >>>> 3) Can we incrementally display messages? e.g. each time we poll, we >>>> add the new messages to the messages div, and scroll to the end >>>> automatically? >>> >>> Yeah - that's a good idea. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>>> >>> >>> >>> >>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1143840e54b19e0539a359d7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, Aug 9, 2016 at 2:07 PM, Ashesh Vashi <ashesh.vashi= @enterprisedb.com> wrote:
<= div dir=3D"ltr">

On Tue, Aug 9, 2016 at 6:34 PM, Dave Page <d= page@pgadmin.org> wrote:



On= Tue, Aug 9, 2016 at 2:01 PM, Ashesh Vashi <ashesh.vashi@enter= prisedb.com> wrote:

On Tue, Aug 9, 2016 at 6:28 PM, Dave Page <dpage@pgadmin.org> wrote:

Hi

On Tue, Aug 9, 2016 at 8:07 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where message panel was showing incomplete = info.
> We may still miss some messages from Psycopg2 driver due to limited si= ze of
> notices queue.
> (RM#1523)

A few thoughts on this (mostly based on my discussions with Ashesh):=

1) You seem to have removed the poll delay. I assume that is to try to
avoid missing messages? Can we re-introduce the delay (to avoid
excessive network requests), but collect messages while we're waiting?<= br>
Using thread?
Start a thread during t= he timeout?

= Not necessarily. If we want a 2 second polling delay, we could just sleep f= or 0.5 secs, collect messages, sleep for 0.5 sec, collect messages, <rep= eat...> return to client.
That's a very huge delay in practical.
We were hardly waiti= ng for during poll (that was in milliseconds), but - still we were loosing = a lot of the messages. (a lot more from the current implementation).
<= /div>

What was the original del= ay? Now there appears to be none at all.
=C2=A0

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashe= sh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi<= /span>




--
Dave Page
Blog: http://pgsnake.blogspot= .com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The= Enterprise PostgreSQL Company




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1143840e54b19e0539a359d7--