Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez0ZN-0000kG-Lb for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:47:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ez0ZM-0000fe-Lj for pgadmin-hackers@arkaria.postgresql.org; Thu, 22 Mar 2018 13:47:52 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ez0ZM-0000fU-8n for pgadmin-hackers@lists.postgresql.org; Thu, 22 Mar 2018 13:47:52 +0000 Received: from mail-wr0-x229.google.com ([2a00:1450:400c:c0c::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ez0ZH-00056M-Si for pgadmin-hackers@postgresql.org; Thu, 22 Mar 2018 13:47:51 +0000 Received: by mail-wr0-x229.google.com with SMTP id z12so8774846wrg.4 for ; Thu, 22 Mar 2018 06:47:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=P9xXeKzYqaVzoSCuMAactF3BaQhgNfffhxogEkLH0oE=; b=I1omcyyLd6j4OayS14RSaqjg+gXj5sWSdYtFLL+UOMSvksUl6FT11tFaXBZuYsGq7K 8azHD3sj5Qsli9VtzZapwaMdPcoiPAkyhnV4cgYQ671gwL7CBg7AdG8OMvJSmQGuhSVQ eo6wHMeemOHuDkZjyqMWOrpxR5v4i71DOr2ijxRoX80KLCMIi2ZkEPgY+b+fgOiOnD// NL3XmCK5ZWUGa61mgXJ7iX/LY4UnvzJnuNvigi7lFhXPy3CUxii6oXtJ1s25+6gE4gfB N06ZBe/ugei+3C4P78c/BSsNKhX3zuFpzL3inHTveEMHU6/ejFCRCb/cQdR9FAdBrwHW Pwbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=P9xXeKzYqaVzoSCuMAactF3BaQhgNfffhxogEkLH0oE=; b=BVAOAdiB0LIl+8OpCXlkt8sxFEj5F8ulOAaBzljpf8+cBtnl7uv1K3G6bQYa/kvn0H CxowNjOoGYUSJFK6oup72baqo4IOkRVEqQWs7siz4ArgM8s8cLqsEbAiJO1HPHfo5LQ7 SxPQ623gjqfisuPR0sTi+ngpGUyrDS9nQ4bYsP3QGXf7gcJIXmM22d3+82nesPLCLaAK 6ukucxcZc95HUAGbS1Hg6svgpru/JZRqpkxYZbpmfPLz7tu/itT6b74LhadI2d6vcxH+ +OsoZbQxD+ERN6zP3pbdGU/SIf3gIxEgbRr1OANoR3c+Y6tboHhd6K04Romx7OkazlrU vblw== X-Gm-Message-State: AElRT7FvepVmNJTcY3vbA/EGqkZKdU8i+EjYxY6X99ZxBDyCS3mMV5MZ uVB5okWkU8gO3/KWUigjE0mZfFzR2POIaMnargkuIA== X-Google-Smtp-Source: AG47ELvpUP7X00nX2JMriNeQ1LBlDXEUV2LOtLIG3yCFADhKBphWdGV1etK1lLNaOLYSMLe3PVsC41VklJIHltQjkf4= X-Received: by 10.223.176.98 with SMTP id g31mr19207798wra.256.1521726466207; Thu, 22 Mar 2018 06:47:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Thu, 22 Mar 2018 06:47:44 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 22 Mar 2018 13:47:44 +0000 Message-ID: Subject: Re: Little patch for Runtime build from Top Level Directory($PGADMIN_SRC) MakeFile To: Rahul Soshte Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113c9c4076c3700568008dc2" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113c9c4076c3700568008dc2 Content-Type: text/plain; charset="UTF-8" Rats, my bad. Fixed now - thanks. On Thu, Mar 22, 2018 at 1:41 PM, Rahul Soshte wrote: > there is a small typo in the target name "all" runtime-release needs to be > changed runtime too. > > On Thu, Mar 22, 2018 at 4:50 PM, Dave Page wrote: > >> Thanks - patch applied with a minor change of the target name >> "runtime-release" to "runtime" (runtime-debug remains the same). >> >> On Thu, Mar 22, 2018 at 9:28 AM, Rahul Soshte >> wrote: >> >>> This is my first time trying to make a Patch. >>> >>> I am using Ubuntu 17.10. >>> >>> This patch is in reference to the Feature Added by Dave Page >>> https://redmine.postgresql.org/issues/1305 >>> >>> I just added code to call makefile in runtime directory( >>> $PGADMIN_SRC/runtime/Makefile ) from the top level directory's MakeFile ( >>> $PGADMIN_SRC/Makefile ) >>> >>> >>> I followed the checklist for submitting a patch sent by Murutuza >>> Zabuawala >>> >>> <================================> >>> Hello, >>> >>> Here is the common checklist to follow before sending patch to >>> pgAdmin4-hackers group, >>> >>> 1) Get the latest pull from master branch. >>> >>> 2) Apply your patch and check if applies successfully on the latest code. >>> >>> 3) Check for PEP8 issues >>> - activate virtual env >>> - cd ../web >>> - yarn run pep8 >>> >>> 4) Run regression test >>> python regression/runtests.py >>> >>> - To run only UI/feature tests >>> python regression/runtests.py --pkg feature_tests >>> >>> - To run regression test (without UI/Feature tests) >>> python regression/runtests.py --exclude feature_tests >>> >>> 5) Run Jasmine tests >>> - activate virtual env >>> - cd ../web >>> yarn run test:karma-once >>> >>> 6) Make sure to add or update help docs and screenshot(s) if you have >>> added any new feature or changed any existing one. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> <===================================================> >>> >>> But I am facing some issues, >>> Step 1,2,3 and 5 had no issues >>> But when I tried step 4 it gave some errors >>> I executed the following command >>> >>> *python regression/runtests.py * >>> >>> I got the following errors: >>> 1)The screenshot attached show I wasnt able to connect to the server >>> 2) the error ouput on the command line: >>> =============Running the test cases for 'PostgreSQL 9.4'============= >>> Traceback (most recent call last): >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 128, in create_database >>> server['sslmode'] >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> OperationalError: FATAL: password authentication failed for user >>> "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> Traceback (most recent call last): >>> File "regression/runtests.py", line 350, in >>> server_information = test_utils.create_parent_server_node(server) >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 491, in create_parent_server_node >>> server_info['sslmode'] >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> psycopg2.OperationalError: FATAL: password authentication failed for >>> user "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> Traceback (most recent call last): >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 619, in _cleanup >>> connection = get_db_server(database["server_id"]) >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 593, in get_db_server >>> db_name, username, db_password, host, db_port, ssl_mode >>> File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", >>> line 36, in get_db_connection >>> sslmode=sslmode >>> File "/var/www/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__init__.py", >>> line 130, in connect >>> conn = _connect(dsn, connection_factory=connection_factory, >>> **kwasync) >>> OperationalError: FATAL: password authentication failed for user >>> "postgres" >>> FATAL: password authentication failed for user "postgres" >>> >>> I have no password authentication errors when I am connecting from the >>> application.I had also changed password for postgres manually through the >>> command line. >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113c9c4076c3700568008dc2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Rats, my bad. Fixed now - thanks.

On Thu, Mar 22, 2018 at 1:41 PM, Rahul= Soshte <rahulsoshte360@gmail.com> wrote:
there is a small typo in the target= name "all" runtime-release needs to be changed runtime too.
<= /div>
On Thu, Mar 22, 2018 at 4:50 PM, Dave Page <dp= age@pgadmin.org> wrote:
Thanks - patch applied with a minor change of the target name= "runtime-release" to "runtime" (runtime-debug remains = the same).

On Thu, Mar 22, 2018 at 9:28 AM, = Rahul Soshte <rahulsoshte360@gmail.com> wrote:
This is my= first time trying to make a Patch.

I am using Ubuntu 17.10.
This patch is in reference to the Feature Added by Dave Page
https:= //redmine.postgresql.org/issues/1305

I just added cod= e to call makefile in runtime directory( $PGADMIN_SRC/runtime/Makefile ) fr= om the top level directory's MakeFile=C2=A0 ( $PGADMIN_SRC/Makefile )

I followed the checklist for submitting a patch sent = by Murutuza Zabuawala

<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>
Hello,

Here is the common checklist to follow before s= ending patch to pgAdmin4-hackers group,

1) Get the latest pull from master bra= nch.

2) Apply your patch and check if applies successfully on the latest code.=
3)= Check for PEP8 issues
- activate virtual env
- cd ../web
- yarn run pep8

4) Run regression test
python regression/runt= ests.py=C2=A0

- To run only UI/feature tests=
python reg= ression/runtests.py --pkg feature_tests=C2=A0
=
- To run regression test (without UI/Feature tests)
python regression/runtests.py --= exclude feature_tests=C2=A0

5) Run Jasmine t= ests
- activate virtual env
- cd ../web
yarn run=C2=A0test:karma-once

6) Make = sure to add or update help docs and screenshot(s) if you have added any new= =C2=A0feature=C2=A0or changed any existi= ng one.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0ht= tp://www.enterprisedb.com
The Enterprise PostgreSQL Company
<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D>

But I am facing some issues,
Step 1,2,3 and 5 had = no issues
But when I tried step 4 it gave some errors
I executed the following command
=C2=A0
python regression/runtests.py=C2=A0

I got the following errors:
1)The = screenshot attached show I wasnt able to connect to the server
2) the error ouput on the command line:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3DRunning the test cases for 'PostgreSQL 9.4'=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D
Traceback (most recent call last):
=C2=A0 Fi= le "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 128, in create_database
=C2=A0=C2=A0= =C2=A0 server['sslmode']
=C2=A0 File "/var/www/flask/pgadmi= n4/pgadmin4/web/regression/python_test_utils/test_utils.py",= line 36, in get_db_connection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
= =C2=A0 File "/var/www/flask/pgadmin4/local/lib/python2.7/site-pac= kages/psycopg2/__init__.py", line 130, in connect
=C2=A0=C2=A0= =C2=A0 conn =3D _connect(dsn, connection_factory=3Dconnection_factory,= **kwasync)
OperationalError: FATAL:=C2=A0 password authentication faile= d for user "postgres"
FATAL:=C2=A0 password authentication fai= led for user "postgres"

Traceback (most recent call last):=
=C2=A0 File "regression/runtests.py", line 350, in <module= >
=C2=A0=C2=A0=C2=A0 server_information =3D test_utils.create_parent_= server_node(server)
=C2=A0 File "/var/www/flask/pgadmin4/pgadm= in4/web/regression/python_test_utils/test_utils.py", line 49= 1, in create_parent_server_node
=C2=A0=C2=A0=C2=A0 server_info['sslm= ode']
=C2=A0 File "/var/www/flask/pgadmin4/pgadmin4/web/re= gression/python_test_utils/test_utils.py", line 36, in get_db_con= nection
=C2=A0=C2=A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/w= ww/flask/pgadmin4/local/lib/python2.7/site-packages/psycopg2/__in= it__.py", line 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect= (dsn, connection_factory=3Dconnection_factory, **kwasync)
psycopg2.= OperationalError: FATAL:=C2=A0 password authentication failed for user &quo= t;postgres"
FATAL:=C2=A0 password authentication failed for user &q= uot;postgres"

Traceback (most recent call last):
=C2=A0 File= "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 619, in _cleanup
=C2=A0=C2=A0=C2=A0 co= nnection =3D get_db_server(database["server_id"])
=C2=A0 = File "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test= _utils/test_utils.py", line 593, in get_db_server
=C2=A0=C2=A0= =C2=A0 db_name, username, db_password, host, db_port, ssl_mode
=C2=A0 Fi= le "/var/www/flask/pgadmin4/pgadmin4/web/regression/python_test_utils/test_utils.py", line 36, in get_db_connection
=C2=A0=C2= =A0=C2=A0 sslmode=3Dsslmode
=C2=A0 File "/var/www/flask/pgadmin4/lo= cal/lib/python2.7/site-packages/psycopg2/__init__.py", line = 130, in connect
=C2=A0=C2=A0=C2=A0 conn =3D _connect(dsn, connection_fac= tory=3Dconnection_factory, **kwasync)
OperationalError: FATAL:=C2= =A0 password authentication failed for user "postgres"
FATAL:= =C2=A0 password authentication failed for user "postgres"

=
I have no password authentication errors when I am connecting fr= om the application.I had also changed password for postgres manually throug= h the command line.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsn= ake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany




--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a113c9c4076c3700568008dc2--