Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbkfu-0006YK-P0 for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 11:47:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hbkft-0001L0-KI for pgadmin-hackers@arkaria.postgresql.org; Fri, 14 Jun 2019 11:47:17 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbkfs-0001Kt-U0 for pgadmin-hackers@lists.postgresql.org; Fri, 14 Jun 2019 11:47:17 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hbkfp-0001pB-TD for pgadmin-hackers@postgresql.org; Fri, 14 Jun 2019 11:47:15 +0000 Received: by mail-io1-xd41.google.com with SMTP id h6so5109512ioh.3 for ; Fri, 14 Jun 2019 04:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yZTQxSJLWnBwi5ahBNenlZEccjc+BXSQ3hyyfzlwqY4=; b=F1Kf1OvO2la1VnEhwjHr/K6Ynw8VrqqUmW9+G12uD9ZCOtU9cRhsk0l1djyKgRdpbX T8KSUiGzyaaTGAVzqG4uBj4s+kMNDiaqx/A/fY8O0mmZfyTg/bRfgLPIpxFaqegGnsWF yZcN58wRjv7kBySECX5ZbcZxj7vSS6JLb6kVkHVSZkz7r7d7+oqQ53lCC4nCWOJ40gWs vO5MTBCqVSd+u5yfXmUVUWduFEc6eOCeSL6SwQz4M1sNITluGQ6CQ8iSV9W2K1YfNhzp Pa6q6jyOesUy73q9KWfzByZ2C9kkNnUxgtxY+jE0JIjLWWr7SyIrNIAU4hy3zmHQNawx RIfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yZTQxSJLWnBwi5ahBNenlZEccjc+BXSQ3hyyfzlwqY4=; b=qKDaYAhTYvuz1gZYK1hwcCcr/42Fkek03AQrwENRTRvwoTRcK9PbO8u+Wek5EbKSRR Nvr+Qxwmmp2fycIvVhyjHcMK9TPgEO8nC9kNHuXQ22CGjob6+dA5XAcf15nzpdu9BeHJ dprNo9LWyPm3gU3vJj4K5lOUgw3HnMdUnKblMOcetbIFxf3a2Ub22gNnRgASPzDMKZQ0 VaV7FZweSFweQAdOGlEZlhv9hrAF40+K07bjGpLyEEAVp9J/yDGlHEXORu7sE0PJDvGd DNG5kaBvGJwM8kQrS4SnpDvkwna9ni+dEqOJuR+fZHilVeDLBhq0zCU2bNE9MJ2yDueO EYsw== X-Gm-Message-State: APjAAAU3BgdebW/34eroRTq2CAAxpBQRTXCO50LqU5HIGFx+zRNsCWcP YwescUsHNTo6qJDmqoX+1tyPLqlWG7uCYqYPwyRa4Q== X-Google-Smtp-Source: APXvYqxntR9yXsGkOsmTRfRF1pLVJ0dX+qYRAt+aPGxGRykdZkSWmfdx21pwuJPjofYDYy2bRQIMn2Rg2cpRjwOV5Ns= X-Received: by 2002:a05:6602:2296:: with SMTP id d22mr58815453iod.209.1560512833100; Fri, 14 Jun 2019 04:47:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 14 Jun 2019 12:47:00 +0100 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Aditya Toshniwal Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000015a86e058b4735fc" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000015a86e058b4735fc Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > I have missed a line while implementing this. Attached is the patch to fix > that. > Although it has not caused any trouble, but still it should be changed. > Kindly review. > > On Mon, Jun 10, 2019 at 7:28 PM Dave Page wrote: > >> Thanks, patch applied. >> >> On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch with fixes. >>> >>> On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Aditya >>>> >>>> Following are the review comments: >>>> >>>> - "Set breakpoint" option not working, when click it throws an >>>> error. >>>> >>>> Fixed. >>> >>>> >>>> - Create an empty function and try to debug that. It should show >>>> proper error message. >>>> >>>> This seems to be a bug in the debugger itself. I'll raise a bug with >>> simulation steps if it is. But, not sure where to raise. >>> >>>> >>>> - Got the following backend error when closing the connection, >>>> please fix this: >>>> - File >>>> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, >>>> in close_debugger_session >>>> conn_id=dbg_obj['exe_conn_id']) >>>> >>>> Fixed. >>> >>>> >>>> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch for debugger improvements. The changes include: >>>>> 1) Change the way debug info is stored in session. Removed redundant >>>>> session related code in debugger code. All the session related handling >>>>> done at one place. >>>>> 2) Fixed a bug where debugger was not opening for EPAS package >>>>> function. >>>>> 3) If a package is defined without body and we try to debug a >>>>> proc/func, the debugger opened a blank window. Changes made so that it will >>>>> throw error as "XYZ is not defined in package body." >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect* >>>> *EnterpriseDB Software India Private Limited* >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --00000000000015a86e058b4735fc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Fri, Jun 14, 2019 at 10:38 AM Aditya To= shniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi Hackers,

I have missed a line w= hile implementing this. Attached is the patch to fix that.
Although it has= not caused any trouble, but still it should be changed.
Kindly review.

On Mon, Jun 10, 2019 at 7:28 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch= applied.

On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal <aditya.toshniwal@= enterprisedb.com> wrote:
Hi Hackers,

Attached is t= he updated patch with fixes.

On Mon, Jun 10, 2019 at 12:58 PM Akshay J= oshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya

Following are the review comments:
  • "Set breakp= oint" option not working, when click it throws an error.
Fixed.=C2=A0
  • Create an empty functio= n and try to debug that. It should show proper error message.
This seems to be a bug in the debugger itself. I'= ll raise a bug with simulation steps if it is. But, not sure where to raise= .
  • Got the following backend error when closing the conn= ection, please fix this:
    • =C2=A0 =C2=A0 File "E:\Projects\p= gadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, in close_d= ebugger_session
      =C2=A0 =C2=A0 conn_id=3Ddbg_obj['exe_conn_id'])<= /li>
Fixed.=C2=A0

On Fri, Jun 7, 2019 at 12:21 PM Aditya To= shniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

At= tached is the patch for debugger improvements. The changes include:
1) Change the way debug info is= stored in session. Removed redundant session related code in debugger code= . All the session related handling done at one place.
2) Fixed a bug where debugger was not opening= for EPAS package function.
3)= If a package is defined without body and we try to debug a proc/func, the = debugger opened a blank window. Changes made so that it will throw error as= "XYZ is not defined in package body."

-- =
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don'= ;t Complain about Heat, Plant a TREE"


--
Thanks &= ; Regards
Akshay Joshi
Sr. Software Architect
<= /font>
EnterpriseDB Software India Private Li= mited
Mobile: +91 976-788-8246
=


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Com= plain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--00000000000015a86e058b4735fc--