Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVKfw-0005pl-Rw for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 15:35:12 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bVKfw-00043I-EO for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 15:35:12 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bVKfj-0003mO-Cx for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 15:34:59 +0000 Received: from mail-io0-x234.google.com ([2607:f8b0:4001:c06::234]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bVKfg-00057A-AR for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 15:34:58 +0000 Received: by mail-io0-x234.google.com with SMTP id 38so274278742iol.0 for ; Thu, 04 Aug 2016 08:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FeXzTWG6LTjor73r+sTsXEASNCwCPI+8jc2w5yTLRB0=; b=1V9xDdRftEWKbT6rwjJHNbKkwrh/7AXUEYeiiuEuRLlnWutxFzKXuSWGyvvY5lbSRy xM16FYCOQF+UTwHaNzfAtNFGo57fSZlhx+r8xgTQ6GFkdPVgswKplCsXnuxSxV14eMo+ zKbvHYCNsK/TNIDi//oVNKIlDtG3sqwPFhPZ+Z240uGzl1QvoFeSrc4KR3iRbRzg4Rj8 u0CQtte/0WW5j6mtnMVI6020E+xBSiK1Xp+ikqAlInsZvPBbde/ZaF7WTZMzlF4HbQCT dvHp1IsJ4OsKO7m06f8mnoUVAnvGNtqy2pPndX91Mp/sJRof9LY+BsXBqfjlqMsxMAKk 4iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FeXzTWG6LTjor73r+sTsXEASNCwCPI+8jc2w5yTLRB0=; b=TBFIIj+twUSj2ImoOmav8pDzFUlK82W7QBnN2xgZukBz6oN67wJ4Mbq8v1gdrlygAX D5I4oCoS8j9tWjmCBTATSGm/f5fW4EOb5GI8TFJR1FOwfZ4eP/lc+H6M8VSxPuBfxYJ7 YvEcOguTK7YE28yPPrx+GhkhzyLa7KVr6TVm8sRY3xpz0OVRDRney4P5rPfCd6o4jSxD 0HiS7/Izp/XjG+qwM2aTyVFuWZBWuaZZdl1Xa7rBGu/qknKUVMwh9K/17XJxnGbnPY7s yKvtCWinWzXcMu53+/sa4bDonPPyD8rdxKaLev53a7mrsY0ycYa0P09bXqMm2YGHXGvP Tr5A== X-Gm-Message-State: AEkooutdYOMtrUda9E1xWqZ29dwUoJIt/jvZK1El8J5zLoVmaKfmr98X4fcwaeo9RVF1MNlLz3qvD+lON37qLQ== X-Received: by 10.107.201.138 with SMTP id z132mr76230012iof.156.1470324895422; Thu, 04 Aug 2016 08:34:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Thu, 4 Aug 2016 08:34:54 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Thu, 4 Aug 2016 16:34:54 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1397 - File upload not working in File Manager in pgAdmin4 Runtime To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Thu, Aug 4, 2016 at 1:59 PM, Surinder Kumar wrote: > Hi > > Issue: > When a file is uploaded via FileManager it gets storage directory path from > STORAGE_DIR config variable. but in case of pgAdmin4 Runtime it is set to > None, that means STORAGE_DIR path should be the root directory. > > The path formed to file was "None/filename.ext'. but it should be > '/filename.txt' which is now fixed. > Please find attached patch and review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers