public inbox for [email protected]  

help / color / mirror / Atom feed

From: Dave Page <[email protected]>
To: Andreas 'ads' Scherbaum <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Remove "unsupported version" warning for Greenplum
Date: Tue, 19 Jan 2016 15:03:03 +0000
Message-ID: <CA+OCxoxZQzjb5OMRGJp+WiYLhEpvGqer-QLLhutRivea575KvA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi

On Mon, Jan 18, 2016 at 1:44 AM, Andreas 'ads' Scherbaum
<[email protected]> wrote:
>
> Hello,
>
> we tested pgAdminIII 1.22 internally and found that it works sufficient with
> Greenplum. A few minor problems are identified and we plan to work on them
> as well, but nothing serious. We however know that there are a number more
> serious problems with HAWQ (SQL on Hadoop), we plan to work on this as well.
>
> As a first step, attached is a patch which removes the "unsupported version"
> warning for Greenplum. The patch copies a bit infrastructure and prepares us
> to support later versions of Greenplum when we bump our version number after
> merging with later PostgreSQL versions. One remaining question is if the
> supported versions should stay in pgConn.cpp or move to pgAdmin3.h.

Your patch won't apply again. I have no idea why - I'm trying to do it
on my Mac, which is a *nix under the hood (they don't use Mac line
endings any more - that was the old Mac OS 9 and earlier from a decade
or so ago iirc). How are you creating them? The normal way is to do
something like:

git pull --rebase
git diff > foo.diff

My git config for the repo is basically what you get on a fresh
installation of git, with a git clone, e.g.

[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
        ignorecase = true
        precomposeunicode = true
[remote "origin"]
        url = ssh://[email protected]/pgadmin3.git
        fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
        remote = origin
        merge = refs/heads/master

Anyway - patch issues aside, isn't your patch essentially the same as
the one I was looking for feedback on just before release?

http://www.postgresql.org/message-id/flat/[email protected]...


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove "unsupported version" warning for Greenplum
  In-Reply-To: <CA+OCxoxZQzjb5OMRGJp+WiYLhEpvGqer-QLLhutRivea575KvA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox