Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0l8q-00039a-Sz for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 09:43:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f0l8p-0008R9-ES for pgadmin-hackers@arkaria.postgresql.org; Tue, 27 Mar 2018 09:43:43 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f0l8p-0008Qz-5t for pgadmin-hackers@lists.postgresql.org; Tue, 27 Mar 2018 09:43:43 +0000 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f0l8k-0001G1-KL for pgadmin-hackers@postgresql.org; Tue, 27 Mar 2018 09:43:42 +0000 Received: by mail-wr0-x244.google.com with SMTP id p53so14185701wrc.10 for ; Tue, 27 Mar 2018 02:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3+fpxDiqKDZIP7V7Cly0o0OBg8RLsxPdFE3Wuy7nOVg=; b=S6t+XQHsXc+iC2aLtZ8XB5pR2eFRsKZ3ZFNzAbMuz5uPWiPpxnyPjnEiI5Nfr0MhJQ 5gp4moFP9y6td4KXg2df+EiJcku5xiS8Z3aZPupA+iZca1/XQbFAnttHl6Ci/d/t81hv FMWkGt87DCZk4vZvQWRPkm851YqKdOpE1k4wHEBZkfe4rATX/HSpqhBkc0SN3yoXB5we eKtK71VyFHIhDUaQU/XBbzKt5fxntobn1VF64QGXWrsHVbS6QVbUeAD2gIS5nSxYsLvi MfxItGDjkc63nNObNd0d+wPnXCYHzSSUNu/Lw7PI6E8reI/VljLOnHySROeYOm+ju4ko pO4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3+fpxDiqKDZIP7V7Cly0o0OBg8RLsxPdFE3Wuy7nOVg=; b=U67qRCs422dXBUP+F4JBiDvZW3dbjLHKi0ojsQ/0TQbytULCXHTwepdtXMUU6YDKjA tRpCVcN1HcvZrb2Kctt0akwh9poYynNxYyFp9GyPkBX+H73X452Aqak/dYparimruhoa E2JE9imdaYL8ENQqU4mM2a9kMQW4Jhu8ssF0dyafugXnmKSlDQckE1/V/hpOgxeHLCXe k3HCFMBaFQPN/bUfvMXJsB7c+K0FOPugfu2mciF4pbG2zCwBdwaDAGS9b/HjPC0kOeQM oQv9+p8GlWWhEG61Axnf5r5jmmllfI4QK62yC/lBXz7Y65cjc0UEg4IW9CA1b+iG0P5Q SCeQ== X-Gm-Message-State: AElRT7EFp5ooNvAORDT2xwZ/gpftA/h7houmNEb1MaR2TN2e8PCX5ng0 FiMeuO7H0isEpGP5snBtyg7gxUgDgZx1xhVcrjtXFQ== X-Google-Smtp-Source: AG47ELuaEc7XB9sNvy+P483tBqRtKTAmXWhiNxMk7i0ek+T/iiUDz7B/HbwmV+LvZx4LcSBFwPlXt/qxCwqSli65xno= X-Received: by 10.223.196.212 with SMTP id o20mr33281728wrf.144.1522143816134; Tue, 27 Mar 2018 02:43:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Tue, 27 Mar 2018 02:43:35 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 27 Mar 2018 10:43:35 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode To: Robert Eckhardt Cc: Joao De Almeida Pereira , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary="f403045f7dbc7547b4056861b93d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --f403045f7dbc7547b4056861b93d Content-Type: text/plain; charset="UTF-8" On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt wrote: > > > On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Hackers, >> >> @Murtuza: The patch codewise looks good. Nice to see that we are using >> axios instead of jquery ajax calls and that there is some coverage for the >> change. >> Nevertheless the Javascript testing looks a bit slim and could be >> improved. Also the DataSorting class could have some other member functions >> like the model validation could be extracted out so that it is easily >> tested. >> >> >> @Hackers: This was how we tried to test this feature: >> 1 - Started pgAdmin >> 2 - Opened the query tool for a specific server >> 3 - Executed a SQL statment >> 4 - Pressed the column header to try to order, nothing happened >> 5 - Right clicked the column header to see if it was there the option, >> nothing >> >> This is the behavior that we were expecting, not to have to open Data >> View and then press the icon that is not even near the grid in order to >> sort the column. Is this really the way we want people to use the grid in >> pgAdmin? Should it be more intuitive? >> > > Have we considered making the grid behave more like excel or other grids? > I think that having the ascending and descending inside the column header, > we could similarly provide filtering. Something that would give users a > more intuitive place to look. > Doing the sorting via header clicks is convenient but very restrictive. How do you specify multiple columns to sort by for example? The current design allows you to select columns and the sort order as you see fit. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --f403045f7dbc7547b4056861b93d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt <= reckhardt@pivotal= .io> wrote:


On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

@Murtuza: The pa= tch codewise looks good. Nice to see that we are using axios instead of jqu= ery ajax calls and that there is some coverage for the change.
Ne= vertheless the Javascript testing looks a bit slim and could be improved. A= lso the DataSorting class could have some other member functions like the m= odel validation could be extracted out so that it is easily tested.=C2=A0


@Hackers: This was how we tried to t= est this feature:
1 - Started pgAdmin
2 - Opened the qu= ery tool for a specific server
3 - Executed a SQL statment
<= div>4 - Pressed the column header to try to order, nothing happened
5 - Right clicked the column header to see if it was there the option, n= othing

This is the behavior that we were expecting= , not to have to open Data View and then press the icon that is not even ne= ar the grid in order to sort the column. Is this really the way we want peo= ple to use the grid in pgAdmin? Should it be more intuitive?

Have we considered making the grid beh= ave more like excel or other grids? I think that having the ascending and d= escending inside the column header, we could similarly provide filtering. S= omething that would give users a more intuitive place to look.
<= /div>

Doing the sorting via header cl= icks is convenient but very restrictive. How do you specify multiple column= s to sort by for example? The current design allows you to select columns a= nd the sort order as you see fit.
=C2=A0
--
--f403045f7dbc7547b4056861b93d--