Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1br2iD-0002g6-Qf for pgadmin-hackers@arkaria.postgresql.org; Mon, 03 Oct 2016 12:51:17 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1br2iD-0001w3-DF for pgadmin-hackers@arkaria.postgresql.org; Mon, 03 Oct 2016 12:51:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1br2iC-0001uY-UR for pgadmin-hackers@postgresql.org; Mon, 03 Oct 2016 12:51:17 +0000 Received: from mail-it0-x235.google.com ([2607:f8b0:4001:c0b::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1br2i6-00058l-0T for pgadmin-hackers@postgresql.org; Mon, 03 Oct 2016 12:51:15 +0000 Received: by mail-it0-x235.google.com with SMTP id r192so114006650ita.0 for ; Mon, 03 Oct 2016 05:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YniAJcoNd/yshfY1PwivPTbbGJjHq7rNqkCyQy/qAww=; b=WFVYjPIWVHTOkRG3JZDxrYvQ9D3K3r+pFPvkdDXh5S6gXc1LzLmI87D5HLNdG3+IhR ORrgNlBi0Eu/kHsuAxrpfs8mPgY157ItTPz2qd4dm+cKRtVYrD8fwUQKeZowH46E/2Yy uiKtODyE8XqBR7uD6X7eihhKPQIvHq5YGp/A9c4Y0j4Yk2ZCkUyw98+uAS+O9Tq2lxCi Gj7BEJzGJ0zzEpI9ftNcT1thl2oobzCatUvgibS+CGzJBLRWpY2UFOQlWfF08EURgxId wwsio05PMvdbCD8airWcyQx9860ahAH3yDD00sDmP+2obnQaTNh6JtVGUcnSamK0ipKj jyDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YniAJcoNd/yshfY1PwivPTbbGJjHq7rNqkCyQy/qAww=; b=PCC/JewiNqc8shMuvRQRzxo15NMwAmzej2ISdTHajys+/vFXXqInMsDoL05oG93rmg KC7QXkm/9h3ktIPOc521xlNlhkUghIr/EsEHAaTjLTJ1ZMqCuzZX0G8ljin/vtC/rjUr th62XDQa5iTxq8E2XZOew0PbAJK84df+fRAqEEb1szeVaEgNER6sELxnHOHE40/b1tGl xXaYKE1gkw81kaB15jUa1jYAVCDQCX4EedvZIs+Kp/okBxkhJsCVyi7DhB3hmYpBV+Qo BysGY7uzWRXhsyQHyqIHA4kToavXHMJZhD4BuGl5Z8O8pGovC0J51ArtjCGuWbMJpcNU Odmw== X-Gm-Message-State: AA6/9RkjfpnFV4+4IPzDxX0hZ+RDgooQgLEHbActF+89nfHTg3Kh+KR8SPwbcmQHxC8fEirMgSx/LjxjNAntSw== X-Received: by 10.36.208.3 with SMTP id m3mr17667523itg.113.1475499068885; Mon, 03 Oct 2016 05:51:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Mon, 3 Oct 2016 05:51:08 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 3 Oct 2016 13:51:08 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: Ensure errorModel unset property properly in Server To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, committed. On Fri, Sep 30, 2016 at 2:24 PM, Dave Page wrote: > Thanks. > > On Fri, Sep 30, 2016 at 2:08 PM, Surinder Kumar > wrote: >> Dave, I have created RM #1786 >> >> On Fri, Sep 30, 2016 at 6:32 PM, Dave Page wrote: >>> >>> Is there an RM for this? If not, can you create one please? I want to >>> be sure we capture all notable changes in Redmine. >>> >>> Thanks! >>> >>> On Fri, Sep 30, 2016 at 1:53 PM, Surinder Kumar >>> wrote: >>> > Hi >>> > >>> > When we add new server and enter an invalid port, it validates and >>> > display >>> > error message, but sometimes it doesn't unset errorModel when a valid >>> > value >>> > is entered. >>> > >>> > Please find attached patch and review. >>> > >>> > >>> > Thanks, >>> > Surinder Kumar >>> > >>> > >>> > -- >>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> > To make changes to your subscription: >>> > http://www.postgresql.org/mailpref/pgadmin-hackers >>> > >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >> >> > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers