Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boRri-0003Ap-Qb for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 09:06:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1boRri-0005aD-DJ for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 09:06:22 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1boRrU-0005Lz-SI for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 09:06:09 +0000 Received: from mail-it0-x22a.google.com ([2607:f8b0:4001:c0b::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1boRrQ-0004Ak-TK for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 09:06:07 +0000 Received: by mail-it0-x22a.google.com with SMTP id j69so38707044itb.0 for ; Mon, 26 Sep 2016 02:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aL+qPjdnrFJb95jxqNH6H+Lm2aWDLziV6qGIhIeHrUo=; b=bP1AcETIy9AwkSsKD6y3SBGATnOCHUUcGEJb0L+Bihiw+E7ZYWTOOoERj3HyCRviEL t1LOyM883fpfVbaYK1Sz7PHBMiU8sQ7A9Z6cOlbaoFP84EmXIPwByzfCqAzkvFq5/S3P HKlSMVpWlf8RXCIDpbGirnnyUczVGFh/CR+yFHXY6MiH4CJp0/TTEg+WtPetr8BN1aos Ex1fUYFRtlL+vy8icTelkvL4fY4qr9CkibY1Z2Yx+ROf5E6RjykZGYJhbfDWQMHftI/2 L713yWzFAKBmrZpb03IVd2TncoH2kJ8xb+VTH27r2SQ/CoQOL+Q+t8ZhgOOkwo6fvdHg 15VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aL+qPjdnrFJb95jxqNH6H+Lm2aWDLziV6qGIhIeHrUo=; b=FME6UFBTVIrNOGZtct0AOiNC3gXIwFxRNeec/m+83KvBpefNjmW2zIN+Oxlu8hQUaE O8nBuSuyY1jg7XXyKTwmbWKcGV2Lr6OJoWLCjOdUi2m+ifmPt1Wgq8535hAT93VQfZJ6 dqFP1hERXUOSwxASPQEKzNj4aNkBBJYfgiMWDQDEHyWd7iQnOqB46i2aee68v1KeeHed BUZ+ZkRgJlWLCH8VWlTixQeVjOztFi2IjTpZ/x0qwEYu/JD/Ds+9jek6KdepdGwsh6WS r5A8FG+g/SowQbUPzkR4VzJhi3mwzd6/xd4gvDSswFzKJeYJGUUF2Vw+Ku9NjrAh2wys 1BuA== X-Gm-Message-State: AA6/9RkxeA2nXEXuZ3fCTr7OOesUpmPf8xas8nuxGq2HcvGIOpAlivFfqEcL5SGkEN5+rrC4FP7o2Yj5iOQ0Ng== X-Received: by 10.36.246.2 with SMTP id u2mr15056138ith.103.1474880764105; Mon, 26 Sep 2016 02:06:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Mon, 26 Sep 2016 02:06:03 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Mon, 26 Sep 2016 10:06:03 +0100 Message-ID: Subject: Re: PATCH: pgAgent support To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=94eb2c11ca2407f032053d657037 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c11ca2407f032053d657037 Content-Type: text/plain; charset=UTF-8 Hi I've applied the misc changes patch, but it looks like you forgot the --binary option for the pgAgent patch. Can you recreate it please? Thanks. On Fri, Sep 23, 2016 at 9:34 PM, Ashesh Vashi wrote: > Hi Dave, > > > On Thu, Sep 22, 2016 at 8:27 PM, Dave Page wrote: > >> Thanks. From the pgAgent patch: >> >> - The date/time format is different again. Should be locale or ISO >> (consistent across the app) >> > Using ISO now. > >> >> - I think we need to add hints under the less obvious options - e.g. >> Job class and host agent >> > I added few string. > Will need your feedback on that. > >> >> - On the job step subnode control, lets move the Script to it's own >> tab (called Code). We should alter the label based on the Kind option >> - either "SQL query" or "Script" >> > Done > >> >> - Why can't we use the Date/time picker for Exceptions? I assume we >> just need to either disable Date or Time selection? >> > Done. > > I was avoiding to show date time picker for multiple reasons: > 1. It needed a special effort to show datetime picker in the backgrid cell. > 2. The datetime picker did not fit in the subnode control. > > A special DatetimePickerCell was needed to be created the cell with > datetime picker. > And, I had to specify the min-height in the exceptions tab as a hack. > >> >> - The SQL tab doesn't use the available space. See screenshot. >> > Fixed. > > This was a general issue for the properties dialog having more than 550px. > We have hardcoded the height to 500px of CodeMirror in the SQL tab. > >> >> - The SQL should have blank lines between sections, e.g. before -- >> Steps and -- Schedules >> > Done. > > Also - fixed an issue of setting the helpMessage in SwitchControl. > > Again - attaching two patches. > 1. Misc changes > - Setting the CodeMirror height when panel is resized, which you had > mentioned. > - Added a new CellEditor (DatetimePickerEditor) for datetime picker. > 2. pgAgent support (updated) > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c11ca2407f032053d657037 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi

I've applied the misc changes pa= tch, but it looks like you forgot the --binary option for the pgAgent patch= . Can you recreate it please?

Thanks.
<= div class=3D"gmail_extra">
On Fri, Sep 23, 20= 16 at 9:34 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com= > wrote:

Hi Dave,


On Thu= , Sep 22, 2016 at 8:27 PM, Dave Page <dpage@pgadmin.org> wro= te:
Thanks. From the p= gAgent patch:

- The date/time format is different again. Should be locale or ISO
(consistent across the app)
Using ISO now.

- I think we need to add hints under the less obvious options - e.g.
Job class and host agent
I added few string.
Will need your feedback on that.=C2=A0

- On the job step subnode control, lets move the Script to it's own
tab (called Code). We should alter the label based on the Kind option
- either "SQL query" or "Script"
Done=C2=A0

- Why can't we use the Date/time picker for Exceptions? I assume we
just need to either disable Date or Time selection?
=
Done.
=C2=A0
I was avoiding to show date time pick= er for multiple reasons:
1. It needed a special effort to show da= tetime picker in the backgrid cell.
2. The datetime picker did no= t fit in the subnode control.

A special DatetimePi= ckerCell was needed to be created the cell with datetime picker.
= And, I had to specify the min-height in the exceptions tab as a hack.=C2=A0=

- The SQL tab doesn't use the available space. See screenshot.
Fixed.
=C2=A0
This was a general is= sue for the properties dialog having more than 550px.
We have har= dcoded the height to 500px of CodeMirror in the SQL tab.=C2=A0

- The SQL should have blank lines between sections, e.g. before --
Steps and -- Schedules
Done.=C2=A0
Also - fixed an issue of setting the helpMessage in SwitchCont= rol.

Again - attaching two patches.
1. M= isc changes
- Setting the CodeMirror height when panel is resized= , which you had mentioned.
- Added a new CellEditor (Datetime= PickerEditor) for datetime picker.
2. pgAgent support (updated)

--

Than= ks & Regards,

Ashesh Vashi
EnterpriseDB INDIA= :=C2=A0En= terprise PostgreSQL Company


http://www.linkedin.com/= in/asheshvashi




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c11ca2407f032053d657037--