Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evrVa-0008R5-Nh for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 21:30:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1evrVZ-0007TR-MT for pgadmin-hackers@arkaria.postgresql.org; Tue, 13 Mar 2018 21:30:57 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1evrVZ-0007TH-Df for pgadmin-hackers@lists.postgresql.org; Tue, 13 Mar 2018 21:30:57 +0000 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1evrVV-0003JV-Fd for pgadmin-hackers@postgresql.org; Tue, 13 Mar 2018 21:30:56 +0000 Received: by mail-wr0-x236.google.com with SMTP id v65so2342802wrc.11 for ; Tue, 13 Mar 2018 14:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yrFSFGStwgy9C59LRXDOJDGbeZ28W0iOQnnKH4V0zWo=; b=eqi1HYNTPcm9WyqHflcvhVbCdwGKRekyEkA05dzSwS4kcrPJqTXJHwR+oby57+IyeI maPx5Dq9fOgDZYDzFrJ2XEfUyPO4ShXDZZ51C/f0//OjzRY4wsDLQ/W0Ow4xDMn6HHSs bHb+3v20XjhK9jHllO9R/NiUb0Rq0HAnjIc/TQ2Rswa4b430yEIfS0JUwdXUOcnnMERY GCdcP8I79WScq9QP2uZE1zLGNIBdmq/D9LFOcHTHRdyzhooxvKHWIT3EwLHFZMozVZPz yp7iOo/odXlEDrLMchUqfH39B52qhJLr+fCpRKfN301W88MMba+xCfRiUlRLQB3ccJPV cRAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yrFSFGStwgy9C59LRXDOJDGbeZ28W0iOQnnKH4V0zWo=; b=ujSPcKz1KvTDgn5ZFWawcHR0eEnxa2eVgOuC0be0pT8CR2F0bytbpM1X+CBUnR5tQ6 Y+R+rzXzwf8ts28kEUo8f6d92tcqhB2lBX2w7FGH5fZVDqqRlzTTiVD1EMgOr+OGltED dgTK+Cm0Fr5Cm2P6iHiPr915Ck9xW/LXgblZg6g+/Mnck2mln1Oph/GN2HmsJlvsuqPT 640Z2S1qjeNpMwesoP3vYFU+TISHiXhPSQa/b2Ah1YTAL5Ij9P+l/W6QHodXcZzTCxjZ fEcUsXNO/Fxrnehc8ePto0ut/cLr4aBvH92hwLzVtix2pKHv0kks3HcjjZ7XgpfuQLFR 1GeA== X-Gm-Message-State: AElRT7GBGYCX5fi8Swhrh2jDwh0sA3CWtiIAazeKt/uHDjs454uNIJ5I 3fIQVsmJk1yir3eDqnst9vLQtc6HFkcUYOZKJRYgnw== X-Google-Smtp-Source: AG47ELsNpGP+yHIUui8Cuq+WYW4UloxVITCaCrw7dBJ/9JDdY6pJboqAp+zDhV50+u6+PhDzfAJk+kER+ejBmpEDMs8= X-Received: by 10.223.129.80 with SMTP id 74mr1687217wrm.190.1520976650586; Tue, 13 Mar 2018 14:30:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.109.7 with HTTP; Tue, 13 Mar 2018 14:30:49 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 13 Mar 2018 17:30:49 -0400 Message-ID: Subject: Re: pgAdmin 4 commit: Fix unicode handling in the external process tools an To: Joao De Almeida Pereira Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c05f2e4f85e4f056751f815" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c05f2e4f85e4f056751f815 Content-Type: text/plain; charset="UTF-8" Thanks - fixed. That begs the question of why Jenkins didn't catch it though :-/ On Tue, Mar 13, 2018 at 4:54 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hi Dave, Khushboo > > Looks like there is a linting issue with this commit: > > Successfully installed pycodestyle-2.3.1 > > /tmp/build/4a5630c2/pgadmin-master/web /tmp/build/4a5630c2 > > ./pgadmin/misc/bgprocess/processes.py:186: [E225] missing whitespace around operator > > ./pgadmin/tools/backup/__init__.py:113: [E303] too many blank lines (2) > > 1 E225 missing whitespace around operator > > 1 E303 too many blank lines (2) > > 2 > > > Best Regards, > Victoria & Joao > > On Tue, Mar 13, 2018 at 4:45 PM Dave Page wrote: > >> Fix unicode handling in the external process tools and show the complete >> command in the process viewer. Fixes #2963. Fixes #3157. >> >> Branch >> ------ >> master >> >> Details >> ------- >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h= >> 802269910c37a52aa57479bbcc1d8d078f6a88e1 >> Author: Khushboo Vashi >> >> Modified Files >> -------------- >> web/pgadmin/misc/bgprocess/processes.py | 36 >> +++++++++++++++++++++-- >> web/pgadmin/misc/bgprocess/static/js/bgprocess.js | 6 ++-- >> web/pgadmin/tools/backup/__init__.py | 5 ++-- >> 3 files changed, 38 insertions(+), 9 deletions(-) >> >> -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --94eb2c05f2e4f85e4f056751f815 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks - fixed. That begs the question of why Jenkins didn= 't catch it though :-/

On Tue, Mar 13, 2018 at 4:54 PM, Joao De Almeida Pereira <= span dir=3D"ltr"><jdealmeidapereira@pivotal.io> wrote:
Hi Dave, Khushboo

Looks like there is a linting issue with this commit:

= 
<=
div>Successfully installe=
d pycodestyle-2.3.1
/tmp/build/= 4a5630c2/pgadmin-master/web /tmp/build/4a5630c2
./pgadmin/m= isc/bgprocess/processes.py:186: [E225] missing whitespace around opera= tor
./pgadmin/t= ools/backup/__init__.py:113: [E303] too many blank lines (2)
1 E22= 5 missing whitespace around operator
1 E3= 03 too many blank lines (2)
2

Best Regards,
Victoria & = Joao

On Tue, Mar= 13, 2018 at 4:45 PM Dave Page <dpage@pgadmin.org> wrote:
Fix unicode handling in the external process tools and show t= he complete command in the process viewer. Fixes #2963. Fixes #3157.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;h=3D802269910c37a52aa57479bbcc1d8d078f6a88e1
Author: Khushboo Vashi <khushboo.vashi@enterprisedb.com>

Modified Files
--------------
web/pgadmin/misc/bgprocess/processes.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0| 36 +++++++++++++++++++++--
web/pgadmin/misc/bgprocess/static/js/bgprocess.js |=C2=A0 6 ++--
web/pgadmin/tools/backup/__init__.py=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 |=C2=A0 5 ++--
3 files changed, 38 insertions(+), 9 deletions(-)




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--94eb2c05f2e4f85e4f056751f815--