Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smUDi-0068Pc-AB for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 08:21:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1smUDg-009z57-8R for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Sep 2024 08:21:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1smUDf-009z4Y-A1 for pgadmin-hackers@lists.postgresql.org; Fri, 06 Sep 2024 08:21:28 +0000 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1smUDc-000Q1B-HR for pgadmin-hackers@postgresql.org; Fri, 06 Sep 2024 08:21:26 +0000 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-e1d0e74f484so2158677276.2 for ; Fri, 06 Sep 2024 01:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; t=1725610882; x=1726215682; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2TrfyugqayA3bRud2BjlHN4TMYrtQe3JvUuaeIKHdcw=; b=UdXUHYOzBHCV2S3W0BlQyZF07gra/RyL+TCh7TeX5AITSg75u+EmgCWeCUflJb0+3l 2bedoVpGh46BhnuGU2+PeVLU6AYiu60omhceNj+nJ2c4TjEtoxZjHojWdiZLStqlJvyN YrYrt/NCEnBhnNtBMdPiBhaDV0BjEuFLa5ZvnFZvn05EDpJ3xca8qZFrCEFn+adaPG7z lVpzGihEi+pAxTkaLZyTfeVuFZqRva2RvW5QWsjyTMWIApz75mOLcF92EI9hwowBeZ1I /Ya7dCRFCJZh/F5UPh1do3Mnp9aQKcUXq9lL+dZ1/PE/dULpueXQaCt4T3M/671zvpth XW3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725610882; x=1726215682; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2TrfyugqayA3bRud2BjlHN4TMYrtQe3JvUuaeIKHdcw=; b=I4IJqxgw++qUiBu6rRmyCZTY80xpw8Adb2lIRNZNPVpgONVybQ1pGe4K4TbRd+ow9N msEpFcDJbZbBWYAvouJConEcDJc8Gd0/I7Fwb+9Zl48xufkZtCvWTuAnv5sS9z5bWwbl ithfHTY6wRs/9GEAu05Nkeo5fj4QplqcFf8WCl03X2fs+r6LzI79MT/UvsDUAoGYBiuK jHzoaYKd+oPbEsnZ20RPJIdgknZRbNEf2pw9bwH+ga1fWQcUgL3WwJSvqNuOP4+29VNQ 01X3QdcHiwFQaRtknvfF9ctqaSLOuWeKGMC3PKj59D8PJdAdP3JOUsd0kxLIoBjMk+/q geEw== X-Gm-Message-State: AOJu0YxlzodLj1Og8nuQ6Dzn5AL9LFgdGT9u5BC/I9XC+LuKS8/eNdQB 8uM+5vmX7a2/xPIfq1l624wV4ocupKUZ8kcnA+MBQpSDW8bFFT2smP2R/vIrhd04vyn9ZPtBGOa JFSRnMS7GDR4+1PirzHTOJECTLzMiKS34shF8 X-Google-Smtp-Source: AGHT+IFs24VprFrr4csWwh8saOH2OH/Qvi/r9ReIVcaqPJiUwnFbUb+cQQiLvU2hkHIeIuZnPUj1cHiZwTOi7kDRP00= X-Received: by 2002:a05:6902:2508:b0:e1a:824f:120f with SMTP id 3f1490d57ef6-e1d3489d423mr1611863276.30.1725610882443; Fri, 06 Sep 2024 01:21:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 6 Sep 2024 09:21:09 +0100 Message-ID: Subject: Re: Require suggestions for Issue #2874 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="000000000000ab4dab06216f1775" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000ab4dab06216f1775 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi On Fri, 6 Sept 2024 at 09:19, Rohit Bhati wrote: > Hi, > > I have removed the border and background color, just made the row numbers > bold. > > I have attached screenshots showing how the updates look across all theme= s > . > That doesn't look bold at all to me - and I think we still need some other visual distinction, such as the column background colour. > > > On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi < > khushboo.vashi@enterprisedb.com> wrote: > >> >> >> On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page wro= te: >> >>> Hi >>> >>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati >>> wrote: >>> >>>> Hi, >>>> >>>> I have made changes for issue #7863 >>>> based on theme >>>> requirements. >>>> >>>> I have attached screenshots showing how the updates look across all >>>> themes for your reference. >>>> >>>> If the current color does not fit well with the theme or if you have >>>> any suggestions for improvements, please let me know. >>>> >>> >>> Is the colour contrast high enough on the row numbers for selected rows >>> in the high contrast theme? The black on grey seems like it might not b= e to >>> me, but I haven't tested. >>> >>> I wonder also if we should make the row numbers bold all the time. >>> Thoughts? >>> >> We can check how it looks. Also the cell border doesn't look good to me. >> >>> >>> >>> -- >>> Dave Page >>> pgAdmin: https://www.pgadmin.org >>> PostgreSQL: https://www.postgresql.org >>> EDB: https://www.enterprisedb.com >>> >>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >>> >>> --=20 Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ --000000000000ab4dab06216f1775 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi

On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <rohit.bhati@enterprisedb.com= > wrote:
Hi,

I have re= moved the border and background color, just=C2=A0made the=C2=A0row number= s bold.

I have attached sc= reenshots showing how the updates look across all themes.

= That doesn't look bold at all to me - and I think we still need some ot= her visual distinction, such as the column background colour.
=C2= =A0


On Fri, Sep 6, 2024 at 12:35=E2=80=AFPM Khushboo Vashi <= khushb= oo.vashi@enterprisedb.com> wrote:


On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave P= age <dpage@pgadmi= n.org> wrote:
Hi
On T= hu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterprisedb.com> wrote= :
Hi,

I have made change= s for issue #7863=C2=A0based on theme requirements.

I hav= e attached screenshots showing how the updates look across all themes for y= our reference.

If the current color does not fit well with the theme= or if you have any suggestions for improvements, please let me know.

Is the colour contrast high enou= gh on the row numbers for selected rows in the high contrast theme? The bla= ck on grey seems like it might not be to me, but I haven't tested.
=C2=A0
I wonder also if we should make the row numbers bold= all the time. Thoughts?
We can check ho= w it looks. Also the cell border doesn't look good to me.


--
Dave PagepgAdmin: https://www= .pgadmin.org
PostgreSQL: https://www.postgresql.org

PGDay UK 2024, 11th September, London:= https://2024.pgday.uk= /



--
Dave Page
PostgreSQL: https://www.postgresql.or= g

PGDay UK = 2024, 11th September, London: https://2024.pgday.uk/

--000000000000ab4dab06216f1775--