Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwqYN-0000XK-Pz for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Oct 2016 13:05:08 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bwqYN-0006Ff-52 for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Oct 2016 13:05:07 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bwqY8-00061L-OA for pgadmin-hackers@postgresql.org; Wed, 19 Oct 2016 13:04:53 +0000 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bwqY0-000887-PC for pgadmin-hackers@postgresql.org; Wed, 19 Oct 2016 13:04:51 +0000 Received: by mail-io0-x22b.google.com with SMTP id f5so30471909ioj.2 for ; Wed, 19 Oct 2016 06:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6ekE8ZrWdoeaYhJBRCNYrY14btE6XtuucdPqyD/XxBE=; b=NqKvTx36Eew7okuTCha0yP71uKe3wjPmpx1Ae2GwnRlAOUqRRuVDWBgnP5cjvDLFSl ICtab3XnoVAJ5PhLX+CW9Rdz/RL25neMwDHUyiPDSC2dFoaUZJEqERGMBeuv25i6J2R4 WeOe9O/XVO2WVh4A43Sak6/LX2sZkBuJ4XSe2mbrbCq2k0DOjEpaKuFGM6w95aiTjMgZ eG7HQgYD0nUIIzmLlysxHEF3XxG8SYS6DXI+BMamSud0Nq9wX7PlLIgUStEIpdUhy27O Ulp4F/xJcGu6zafrS8DECdSpgXqQuyWI1IgtC6H8qBfHSoVX6zgfJRWu0gD/VxP1w1ap 934Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ekE8ZrWdoeaYhJBRCNYrY14btE6XtuucdPqyD/XxBE=; b=kwpDdHjdxVZ2508KFxu1ioG1sF+maIF9ZvwqaIrGylzuicqIooNVHXHi2IzEcSvVne C3LgK/8GW+y+y6tCRZCLdJS0PcejRRZaHe+h67JWVs3rpcHByCtqr8AFwND9d7fB4RAz AWAu+3NunITWjBbbpqfAEXd+ZvYfSCotPoX7Ebm/FNtDqtbaEbhfKDxx4+P11JLJc2Qk 1XKGAZmmd1gM/S1jMqT3tlhs1ZFRhWDtGv1qLJPkc/N9kOYdWsapUrSGR5d7JJg0I2Bm pGojsV07OcgkgR/DakCSL+HFajBrflDLRCzuJzznp20fXd2aKQhaUs5zNQwrwoB30AJz p+7A== X-Gm-Message-State: AA6/9RnXnchNEjhCLFTL9q16uwKlJDuvdRvYxk3HRam88uAmrdYOE9lECMZGKWTq/ytm64/7YWHM7x4RYUoLSA== X-Received: by 10.107.28.148 with SMTP id c142mr6125925ioc.45.1476882283912; Wed, 19 Oct 2016 06:04:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.82.130 with HTTP; Wed, 19 Oct 2016 06:04:41 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 19 Oct 2016 14:04:41 +0100 Message-ID: Subject: Re: RM1849: Auto-generating security keys To: Ashesh Vashi Cc: Fahar Abbas , pgadmin-hackers , Josh Berkus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= , Magnus Hagander , Sandeep Thakkar , Hamid Quddus Akhtar Content-Type: multipart/alternative; boundary=001a113fd4b8e875ec053f377352 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113fd4b8e875ec053f377352 Content-Type: text/plain; charset=UTF-8 Patch applied. On Wed, Oct 19, 2016 at 11:55 AM, Ashesh Vashi < ashesh.vashi@enterprisedb.com> wrote: > Hi Fahar, > > Please log the case on redmine. > Please find the attached patch, please apply it locally, and test it. > > And, please update the case, and this mail chain accordingly. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Wed, Oct 19, 2016 at 3:47 PM, Fahar Abbas > wrote: > >> Here is the output of if we copy config_local.py and execute python >> setup.py >> pgAdmin 4 - Application Initialisation >> ====================================== >> >> >> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does not >> exist. >> Entering initial setup mode... >> NOTE: Configuring authentication for SERVER mode. >> >> >> Enter the email address and password to use for the initial pgAdmin >> user account: >> >> Email address: fahar.abbas@enterprisedb.com >> Password: >> Retype password: >> Traceback (most recent call last): >> File "setup.py", line 449, in >> do_setup(app) >> File "setup.py", line 96, in do_setup >> password = encrypt_password(p1) >> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >> line 150, in encrypt_password >> signed = get_hmac(password).decode('ascii') >> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >> line 108, in get_hmac >> 'set to "%s"' % _security.password_hash) >> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >> python setup.py >> pgAdmin 4 - Application Initialisation >> ====================================== >> >> User can not do any setup for web based now. >> >> >> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does not >> exist. >> Entering initial setup mode... >> NOTE: Configuring authentication for SERVER mode. >> >> >> Enter the email address and password to use for the initial pgAdmin >> user account: >> >> Email address: fahar.abbas@enterprisedb.com >> Password: >> Retype password: >> Traceback (most recent call last): >> File "setup.py", line 449, in >> do_setup(app) >> File "setup.py", line 96, in do_setup >> password = encrypt_password(p1) >> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >> line 150, in encrypt_password >> signed = get_hmac(password).decode('ascii') >> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >> line 108, in get_hmac >> 'set to "%s"' % _security.password_hash) >> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >> >> On Wed, Oct 19, 2016 at 3:03 PM, Fahar Abbas < >> fahar.abbas@enterprisedb.com> wrote: >> >>> Dave, >>> >>> Testing Environment >>> >>> Ubuntu 16.04 Linux 64: >>> -------------------------------- >>> >>> pg-AdminIV Development Environment Setup for Ubuntu : >>> >>> >>> 1) Install GIT >>> >>> sudo apt-get install git >>> >>> 2) Install pip3 >>> >>> sudo apt-get install python3-pip >>> >>> 3) Install virtualenv >>> >>> sudo pip3 install virtualenv >>> >>> 4) install below dependency as it is required for psycopg2 & pycrypto >>> module >>> >>> sudo apt-get install libpq-dev >>> >>> sudo apt-get install python3-dev >>> >>> 5) Create virtual environment >>> >>> virtualenv -p python3 venv >>> >>> 6) Create mkdir Projects >>> >>> 7) Clone git repo in Projects >>> >>> git clone http://git.postgresql.org/git/pgadmin4.git >>> >>> 8) activate virtual environment >>> >>> source venv/bin/activate >>> >>> 9) Install modules >>> >>> pip3 install -r requirements_py3.txt >>> >>> *10) Edit the config.py file to config_local.py resides in >>> Projects\pgAdmin4\web * >>> >>> 11)Now run setup.py file (\Projects\pgAdmin4\web) >>> python setup.py >>> >>> If user does not create config_local.py and do Python setup.py for new >>> Development then SECURITY_PASSWORD_SALT message is also displayed: >>> >>> Here is the output: >>> ------------------------- >>> >>> python setup.py >>> pgAdmin 4 - Application Initialisation >>> ====================================== >>> >>> >>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>> not exist. >>> Entering initial setup mode... >>> NOTE: Configuring authentication for SERVER mode. >>> >>> >>> Enter the email address and password to use for the initial pgAdmin >>> user account: >>> >>> Email address: fahar.abbas@enterprisedb.com >>> Password: >>> Retype password: >>> Traceback (most recent call last): >>> File "setup.py", line 449, in >>> do_setup(app) >>> File "setup.py", line 96, in do_setup >>> password = encrypt_password(p1) >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 150, in encrypt_password >>> signed = get_hmac(password).decode('ascii') >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 108, in get_hmac >>> 'set to "%s"' % _security.password_hash) >>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >>> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >>> (venv) fahar@fahar-virtual-machine:~/Projects/pgadmin4/web$ >>> >>> >>> Is this expected? >>> >>> On Wed, Oct 19, 2016 at 1:37 PM, Fahar Abbas < >>> fahar.abbas@enterprisedb.com> wrote: >>> >>>> Sure, >>>> >>>> Will test this thoroughly after complete investigation. >>>> >>>> Kind Regards, >>>> >>>> On Wed, Oct 19, 2016 at 1:27 PM, Dave Page wrote: >>>> >>>>> Patch applied. >>>>> >>>>> Fahar, can you please test this thoroughly in desktop and server >>>>> modes, with both fresh and upgraded installations? >>>>> >>>>> https://redmine.postgresql.org/issues/1849 >>>>> >>>>> Packagers: This change means that packages are no longer forced to >>>>> create a config_local.py file, and there is no longer any need to >>>>> explicitly set SECURITY_PASSWORD_SALT, SECURITY_KEY >>>>> and CSRF_SESSION_KEY in the config (in fact, they should be removed for new >>>>> installations, if you have included them in 1.0) >>>>> >>>>> Thanks. >>>>> >>>>> >>>>> On Wed, Oct 19, 2016 at 6:46 AM, Ashesh Vashi < >>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> On Sat, Oct 15, 2016 at 8:02 AM, Dave Page wrote: >>>>>> >>>>>>> Hi >>>>>>> >>>>>>> >>>>>>> On Friday, October 14, 2016, Dave Page wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> On Thursday, October 13, 2016, Ashesh Vashi < >>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> On Tue, Oct 11, 2016 at 9:10 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Ashesh, >>>>>>>>>> >>>>>>>>>> Can you please review the attached patch, and apply if you're >>>>>>>>>> happy with it? >>>>>>>>>> >>>>>>>>> Overall the patch looked good to me. >>>>>>>>> But - I encounter an issue in 'web' mode, which wont happen with >>>>>>>>> 'runtime'. >>>>>>>>> >>>>>>>>> Steps for reproduction on existing pgAdmin 4 environment with >>>>>>>>> 'web' mode. >>>>>>>>> - Apply the patch >>>>>>>>> - Start the pgAdmin4 application (stand alone application). >>>>>>>>> - Open pgAdmin home page. >>>>>>>>> - Log out (if already login). >>>>>>>>> >>>>>>>>> And, you will see an exception. >>>>>>>>> >>>>>>>>> I have figure out the issue with the patch. >>>>>>>>> We were setting the SECURITY_PASSWORD_SALT, after initializing the >>>>>>>>> Security object. >>>>>>>>> Hence - it could not set the SECURITY_KEY, and >>>>>>>>> SECURITY_PASSWORD_SALT properly. >>>>>>>>> >>>>>>>> >>>>>>>> Hmm. >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> I had moved the Security object initialization after fetching >>>>>>>>> these configurations from the database. >>>>>>>>> I have attached a addon patch for the same. >>>>>>>>> >>>>>>>> >>>>>>>> OK, thanks. >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Now - I run into another issue. >>>>>>>>> Because - the existing password was hashed using the old >>>>>>>>> SECURITY_PASSWORD_SALT, I am no more able to login to pgAdmin 4. >>>>>>>>> >>>>>>>>> I think - we need to think about different strategy for upgrading >>>>>>>>> the configuration file in the 'web' mode. >>>>>>>>> I was thinking - we can store the existing security configurations >>>>>>>>> in the database during upgrade process in 'web' mode. >>>>>>>>> >>>>>>>> >>>>>>>> My concern with that is that we'll likely be storing the default >>>>>>>> config values in many cases, thus for those users, perpetuating the problem. >>>>>>>> >>>>>>>> I guess what we need to do is re-encrypt the password during the >>>>>>>> upgrade - however, that makes me think; we then have both the key and the >>>>>>>> encrypted passwords in the same database which is clearly not a good idea. >>>>>>>> Sigh... Needs more thought. >>>>>>>> >>>>>>> >>>>>>> OK, so I've been thinking about this and experimenting for a couple >>>>>>> of hours, as well as annoying the crap out of Magnus by thinking out loud >>>>>>> in his general direction, and it looks like this isn't a major problem as >>>>>>> from what I can see, SECURITY_PASSWORD_SALT is (aside from really being a >>>>>>> key not a salt) not the only salting that's done. >>>>>>> >>>>>>> It looks like it's used system-wide as the key to generate an HMAC >>>>>>> of the users password, which is then passed to passlib which salts and >>>>>>> hashes it. I did some testing, and found that two users with the same >>>>>>> password end up with different hashes in the database, so clearly there is >>>>>>> also per-user salting happening. I also created two users, then dropped the >>>>>>> database and created the same user accounts with the same passwords again, >>>>>>> and found that the resulting hashes were different in both databases - thus >>>>>>> there is something else ensuring the hashes are unique across different >>>>>>> installations/databases. >>>>>>> >>>>>>> So, I believe we can do as you suggest and migrate existing values >>>>>>> for SECURITY_PASSWORD_SALT, given that there's clearly some other per user >>>>>>> and per installation/database salting going on anyway. New installations >>>>>>> can have the random value for SECURITY_PASSWORD_SALT. >>>>>>> >>>>>> We do not need to generate the random SECURITY_PASSWORD_SALT during >>>>>> upgrade mode, which was wrong added in my addon patch. >>>>>> >>>>>> Please find the updated patch. >>>>>> >>>>>> Otherwise - looks good to me. >>>>>> Please commit the new patch (if you're ok with the change). >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & Regards, >>>>>> >>>>>> Ashesh Vashi >>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>>> >>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>> >>>>>> >>>>>>> >>>>>>> I don't believe SECURITY_KEY and CSRF_SESSION_KEY are issues either, >>>>>>> as they're used for purposes that are essentially ephemeral, and thus can >>>>>>> be changed during an upgrade. >>>>>>> >>>>>>> Adding Magnus as I'd appreciate any thoughts he may have. >>>>>>> >>>>>>> Patch attached - please review (Ashesh, but others too would be >>>>>>> appreciated)! >>>>>>> >>>>>>> Thanks. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Syed Fahar Abbas >>>> Quality Management Group >>>> >>>> EnterpriseDB Corporation >>>> Phone Office: +92-51-835-8874 >>>> Phone Direct: +92-51-8466803 >>>> Mobile: +92-333-5409707 >>>> Skype ID: syed.fahar.abbas >>>> Website: www.enterprisedb.com >>>> >>> >>> >>> >>> -- >>> Syed Fahar Abbas >>> Quality Management Group >>> >>> EnterpriseDB Corporation >>> Phone Office: +92-51-835-8874 >>> Phone Direct: +92-51-8466803 >>> Mobile: +92-333-5409707 >>> Skype ID: syed.fahar.abbas >>> Website: www.enterprisedb.com >>> >> >> >> >> -- >> Syed Fahar Abbas >> Quality Management Group >> >> EnterpriseDB Corporation >> Phone Office: +92-51-835-8874 >> Phone Direct: +92-51-8466803 >> Mobile: +92-333-5409707 >> Skype ID: syed.fahar.abbas >> Website: www.enterprisedb.com >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a113fd4b8e875ec053f377352 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Patch applied.

On Wed, Oct 19, 2016 at 11:55 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Please= log the case on redmine.
Please find the attached patch, please apply = it locally, and test it.

And, please update the ca= se, and this mail chain accordingly.
=

--

Thanks & Reg= ards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Po= stgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Oct 19= , 2016 at 3:47 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Here is the output of if we copy config_local.py and execute python setup.= py
pgAdmin 4 - Application Initialisation
=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D


The configuration database - '/home= /fahar/.pgadmin/pgadmin4.db' does not exist.
Entering initial s= etup mode...
NOTE: Configuring authentication for SERVER mode.

=C2=A0=C2=A0=C2=A0 Enter the email address and password to use for the in= itial pgAdmin user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email address: <= a href=3D"mailto:fahar.abbas@enterprisedb.com" target=3D"_blank">fahar.abba= s@enterprisedb.com
Password:
Retype password:
Traceback (most= recent call last):
=C2=A0 File "setup.py", line 449, in <m= odule>
=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "setup.py= ", line 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encrypt_pas= sword(p1)
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-pac= kages/flask_security/utils.py", line 150, in encrypt_password
= =C2=A0=C2=A0=C2=A0 signed =3D get_hmac(password).decode('ascii'= ;)
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/f= lask_security/utils.py", line 108, in get_hmac
=C2=A0=C2=A0=C2= =A0 'set to "%s"' % _security.password_hash)
RuntimeEr= ror: The configuration value `SECURITY_PASSWORD_SALT` must not be None when= the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512"<= br>python setup.py
pgAdmin 4 - Application Initialisation
=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

User can not do any= setup for web based now.


The configuration database = - '/home/fahar/.pgadmin/pgadmin4.db' does not exist.
Enteri= ng initial setup mode...
NOTE: Configuring authentication for SERVER mod= e.


=C2=A0=C2=A0=C2=A0 Enter the email address and password to us= e for the initial pgAdmin user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Emai= l address: fahar.abbas@enterprisedb.com
Password:
Retype password:
Tra= ceback (most recent call last):
=C2=A0 File "setup.py", line 4= 49, in <module>
=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File &q= uot;setup.py", line 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D= encrypt_password(p1)
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", line 150, in encrypt_= password
=C2=A0=C2=A0=C2=A0 signed =3D get_hmac(password).decode('as= cii')
=C2=A0 File "/home/fahar/venv/lib/python3.5/sit= e-packages/flask_security/utils.py", line 108, in get_hmac
=C2= =A0=C2=A0=C2=A0 'set to "%s"' % _security.password_hash)<= br>RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not = be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_s= ha512"

<= div class=3D"gmail_quote">On Wed, Oct 19, 2016 at 3:03 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Dave,

Testi= ng Environment
=C2=A0
Ubuntu 16.04 Linux 64:
---------= -----------------------

pg-AdminIV Development Environment Setup for Ubuntu=C2=A0 :


1) Install GIT

sudo apt-get install git

2) Install pip3

sudo apt-get install python3-pip

3) Install virtualenv

sudo pip3 ins= tall virtualenv

4) install below dependency as it is required for psycopg2 & pycryp= to module

su= do apt-get install libpq-dev

sudo apt-get install python3-dev

5) Create virtual environment

virtualenv -p pyt= hon3 venv

6) Create mkdi= r Projects

7) Clone git repo in Projects

git clone http://git.postgresql.org/git/pgadmin4.git

8) activate virtual environment

source venv/bin/activate

9) Install modules

pip3 install = -r requirements_py3.txt

10) Edit the config.py file to = config_local.py =C2=A0resides in Projects\pgAdmin4\web=C2=A0=C2=A0

11)= Now run setup.py file =C2=A0(\Projects\<= span>pgAdmin4\web)

=C2=A0 =C2=A0 pytho= n setup.py

If user does not cre= ate config_local.py and do Python setup.py for new Development then SECURIT= Y_PASSWORD_SALT message is also displayed:

Here is the ou= tput:
-------------------------

python setup.py
pg= Admin 4 - Application Initialisation
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D


The configuration database - '/home/fahar/.pgad= min/pgadmin4.db' does not exist.
Entering initial setup mode...=
NOTE: Configuring authentication for SERVER mode.


=C2=A0=C2= =A0=C2=A0 Enter the email address and password to use for the initial pgAdm= in user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email address: fahar.abbas@enterpris= edb.com
Password:
Retype password:
Traceback (most recent cal= l last):
=C2=A0 File "setup.py", line 449, in <module>=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "setup.py", lin= e 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encrypt_password(p1)=C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/flask= _security/utils.py", line 150, in encrypt_password
=C2=A0=C2= =A0=C2=A0 signed =3D get_hmac(password).decode('ascii')
=C2= =A0 File "/home/fahar/venv/lib/python3.5/site-packages/flask_secu= rity/utils.py", line 108, in get_hmac
=C2=A0=C2=A0=C2=A0 '= set to "%s"' % _security.password_hash)
RuntimeError: The = configuration value `SECURITY_PASSWORD_SALT` must not be None when the valu= e of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512"
(venv)= fahar@fahar-virtual-machine:~/Projects/pgadmin4/web$


Is this expec= ted?

On Wed, Oct= 19, 2016 at 1:37 PM, Fahar Abbas <fahar.abbas@enterprisedb.com= > wrote:
<= div>
Sure,

Will test this thoroughly after complete invest= igation.

Kind Regards,

On Wed, Oct 19, 2016 at 1:27 PM, D= ave Page <dpage@pgadmin.org> wrote:
Patch applied.

Fahar, can yo= u please test this thoroughly in desktop and server modes, with both fresh = and upgraded installations?


Packagers: This change= means that packages are no longer forced to create a config_local.py file,= and there is no longer any need to explicitly set=C2=A0SECURITY_PASSWORD_SALT,=C2=A0SECURITY_KEY and=C2=A0CSRF_SESSION_KEY in the config (in fact,= they should be removed for new installations, if you have included them in= 1.0)

Thanks.


On Wed, = Oct 19, 2016 at 6:46 AM, Ashesh Vashi <ashesh.vashi@enterprise= db.com> wrote:
Hi Dave,

On Sat, Oct 15, 2016 at 8:02 AM, Dave Page <dpage@pgadmi= n.org> wrote:
Hi


On Friday, October 14, 2016, Dave Page <dpage@pgadmin.org&= gt; wrote:
Hi

O= n Thursday, October 13, 2016, Ashesh Vashi <ashesh.vashi@enterprisedb= .com> wrote:
Hi Dave,

On Tue, Oct 11, 2016 at 9:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi Ashesh,

Can you ple= ase review the attached patch, and apply if you're happy with it?
=
Overall the patch looked good to me.
But - I en= counter an issue in 'web' mode, which wont happen with 'runtime= '.

Steps for reproduction on existing pgAdmin = 4 environment with 'web' mode.
- Apply the patch
- Start the pgAdmin4 application (stand alone application).
- O= pen pgAdmin home page.
- Log out (if already login).
And, you will see an exception.

I hav= e figure out the issue with the patch.
We were setting the SECURI= TY_PASSWORD_SALT, after initializing the Security object.
Hence -= it could not set the SECURITY_KEY, and SECURITY_PASSWORD_SALT properly.

Hmm.
=C2=A0=

I h= ad moved the Security object initialization after fetching these configurat= ions from the database.
I have attached a addon patch for the sam= e.

OK, thanks.
=C2=A0

Now - I run into another issue.
Because - the existing p= assword was hashed using the old SECURITY_PASSWORD_SALT, I am no more able = to login to pgAdmin 4.

I think - we need to think = about different strategy for upgrading the configuration file in the 'w= eb' mode.
I was thinking - we can store the existing security= configurations in the database during upgrade process in 'web' mod= e.

My concern with = that is that we'll likely be storing the default config values in many = cases, thus for those users, perpetuating the problem.

=
I guess what we need to do is re-encrypt the password during the upgra= de - however, that makes me think; we then have both the key and the encryp= ted passwords in the same database which is clearly not a good idea. Sigh..= . Needs more thought.=C2=A0

OK, so I've been thinking about this and experimenting for a couple = of hours, as well as annoying the crap out of Magnus by thinking out loud i= n his general direction, and it looks like this isn't a major problem a= s from what I can see, =C2=A0SECURITY_PASSWORD_SALT is (aside from really b= eing a key not a salt) not the only salting that's done.=C2=A0

It looks like it's used system-wide as the key to gene= rate an HMAC of the users password, which is then passed to passlib which s= alts and hashes it. I did some testing, and found that two users with the s= ame password end up with different hashes in the database, so clearly there= is also per-user salting happening. I also created two users, then dropped= the database and created the same user accounts with the same passwords ag= ain, and found that the resulting hashes were different in both databases -= thus there is something else ensuring the hashes are unique across differe= nt installations/databases.

So, I believe we can d= o as you suggest and migrate existing values for SECURITY_PASSWORD_SALT, gi= ven that there's clearly some other per user and per installation/datab= ase salting going on anyway. New installations can have the random value fo= r SECURITY_PASSWORD_SALT.
We do not need= to generate the random SECURITY_PASSWORD_SALT during upgrade mode, which w= as wrong added in my addon patch.

Please find the = updated patch.

Otherwise - looks good to me.
=
Please commit the new patch (if you're ok with the change).
<= p style=3D"margin:0pt">
= --

Thanks & Regards,<= br style=3D"font-style:italic">
Ashesh Vashi
<= /span>EnterpriseDB INDIA:=C2=A0Enterprise PostgreS= QL Company



I don't believ= e SECURITY_KEY and=C2=A0CSRF_SESSION_KEY are issues either, as they're = used for purposes that are essentially ephemeral, and thus can be changed d= uring an upgrade.

Adding Magnus as I'd appreci= ate any thoughts he may have.

Patch attached - ple= ase review (Ashesh, but others too would be appreciated)!

Thanks.


--
Dave Page
Blog= : http://pgsnake.= blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company



--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Ph= one Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: <= a href=3D"tel:%2B92-333-5409707" value=3D"+923335409707" target=3D"_blank">= +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com



--
Syed Fahar Abbas
=
Quality Management Group

EnterpriseDB CorporationPhone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobil= e: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com=



--
Syed Fahar Abbas
Quality Ma= nagement Group

EnterpriseDB Corporation
Phone Office: +92-5= 1-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com




--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a113fd4b8e875ec053f377352--