MIME-Version: 1.0
References: <24e2e9bd9a5be7cca8ac39344ed53e4a@coginternet.net>
In-Reply-To: <24e2e9bd9a5be7cca8ac39344ed53e4a@coginternet.net>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 20 Apr 2021 11:23:39 +0100
Message-ID: 
 <CA+OCxoxeo21YAfGiWBPxon2DNnNFYK4=qHWBgsGjctx6g8dq2w@mail.gmail.com>
Subject: Re: Feature #6395 - Basic Log Rotation
To: Thomas Greenwood <tom@coginternet.net>
Cc: pgadmin-hackers <pgadmin-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000ae460b05c064d7e3"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxoxeo21YAfGiWBPxon2DNnNFYK4%3DqHWBgsGjctx6g8dq2w%40mail.gmail.com>
Precedence: bulk

--000000000000ae460b05c064d7e3
Content-Type: text/plain; charset="UTF-8"

Hi

On Mon, Apr 19, 2021 at 5:17 PM Thomas Greenwood <tom@coginternet.net>
wrote:

> Hi,
>
> I've opened feature issue #6395 to enable log rotation in pgAdmin4 v5.
>
> Please find the attached basic patch as a starter for 10. It's the same
> patch attached to the feature issue.
>

Nice! My only suggestions would be that the config options be added to
config.py, with default values of zero for log size, and say, 5 for the
number of backups (should that be 'archives'?), and that we test to see if
the log size is > 0 before enabling rotation. The reason for that is that
we keep all config options in config.py to ensure it's self-documenting.

-- 
Dave Page
Blog: https://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: https://www.enterprisedb.com

--000000000000ae460b05c064d7e3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Mon, Apr 19, 2021 at 5:17 PM Thomas =
Greenwood &lt;<a href=3D"mailto:tom@coginternet.net">tom@coginternet.net</a=
>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-co=
lor:rgb(204,204,204);padding-left:1ex"><div style=3D"font-size:10pt;font-fa=
mily:Verdana,Geneva,sans-serif">
<div id=3D"gmail-m_-4380095411301954023editbody1">
<div style=3D"font-size:10pt;font-family:Verdana,Geneva,sans-serif">
<div id=3D"gmail-m_-4380095411301954023v1editbody1">
<div style=3D"font-size:10pt;font-family:Verdana,Geneva,sans-serif">
<div id=3D"gmail-m_-4380095411301954023v1v1editbody1">
<div style=3D"font-size:10pt;font-family:Verdana,Geneva,sans-serif">
<p>Hi,</p>
<p>I&#39;ve opened feature issue #6395 to enable log rotation in pgAdmin4 v=
5.</p>
<p>Please find the attached basic patch as a starter for 10. It&#39;s the s=
ame patch attached to the feature issue.</p></div></div></div></div></div><=
/div></div></blockquote><div><br></div><div>Nice! My only suggestions would=
 be that the config options be added to config.py, with default values of z=
ero for log size, and say, 5 for the number of backups (should that be &#39=
;archives&#39;?), and that we test to see if the log size is &gt; 0 before =
enabling rotation. The reason for that is that we keep all config options i=
n config.py to ensure it&#39;s self-documenting.</div></div><div><br></div>=
-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Pag=
e<br>Blog: <a href=3D"https://pgsnake.blogspot.com" target=3D"_blank">https=
://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EDB: <a href=3D"htt=
ps://www.enterprisedb.com" target=3D"_blank">https://www.enterprisedb.com</=
a><br><br></div></div></div>

--000000000000ae460b05c064d7e3--