Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bX8by-0006tj-LY for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 15:06:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bX8by-00010b-7B for pgadmin-hackers@arkaria.postgresql.org; Tue, 09 Aug 2016 15:06:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bX8bk-0000mP-Rk for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 15:06:20 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bX8bc-0007M9-7H for pgadmin-hackers@postgresql.org; Tue, 09 Aug 2016 15:06:20 +0000 Received: by mail-it0-x233.google.com with SMTP id x130so16860456ite.1 for ; Tue, 09 Aug 2016 08:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Xf5CC2+v7Z6D0haB/qbewt/6oujMR7qm4bhBGTufWeY=; b=UPNcQpNYmyqFfxzoxaTJR8bb8La98wZ/PWeFhHDzruXTdHP2ANCD9/fSxN6f4Uy+IO 5ZdUTJLSe+h/Jo1GBLMv0lHiRsLuH/XDNecEeCMT39GecM9ukj1R1FhOGw1obK+i3xYY NPDOw4nDX06zyedBEzsMO7bPklZBjBfTXVA3xkgvcu8AS6J3+PkpuHqpO896aLxEwrjc Sezl2rAIwjqgpQSf1XgiopiTAsvS33jy+FO6ZLaC3gbRtsWP4gdwaQCAP5myv0BxQ7WQ xRxllrlOHRt6zWRl5I1i0YA6u501B/dh3WM9aL4X+VP4lmwzdo0lRLOL2ZkjzvHlcHiX LS4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Xf5CC2+v7Z6D0haB/qbewt/6oujMR7qm4bhBGTufWeY=; b=UTb0LvGWabzDYwgUfYAPlpryNx/4XzJzSDYCkdzCHKkQlP1rdsJTqK4Jl4cV1EZa/D fAAizmF/ePMAShoRgAKKUQ5k+bH/DPdeGwkS/Lcirt2CZXqQnC7F3eCxe4uvHZEzgIkT nToGk4e+ng0XRkJgTyFbuK9H87lnLarAYvEMY/wimJb//8tLOQY8v6WZI1nBvq0pAj3X WEfueYSL6s1iaSleVnHp9QiQBV7Ukn+odnQvWrYad9Zm0UvgXDQ2OvYZhx+MsWQ/gkw5 wjxEKqMYxogx7nOp/ixLhci3d6/Sl5h7nL9MA2hMghyPODNVB0kh5420BgeIHhJj90rS GGVQ== X-Gm-Message-State: AEkoouv6NyC+YBHVn4eTF9AHCgG2fImXhzGUH1SxYVJO6p4fF++2XHTlDLNlNKlYaiLI4hfO1Avw+XLLyBYa1EmM45jT47ox5jRBm5fNos/lDdpP9wZwDFAjG70UeVYU5UojQvWC+s/k6HsLQl0wx5ge7PrqQmryJnukJmYHwNjHldes1LhtGMWcrhscwDDmtAaw8oqnKw== X-Received: by 10.36.135.68 with SMTP id f65mr22139777ite.1.1470755169748; Tue, 09 Aug 2016 08:06:09 -0700 (PDT) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com. [209.85.214.41]) by smtp.gmail.com with ESMTPSA id j129sm16739550iof.35.2016.08.09.08.06.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Aug 2016 08:06:09 -0700 (PDT) Received: by mail-it0-f41.google.com with SMTP id x130so16859901ite.1 for ; Tue, 09 Aug 2016 08:06:09 -0700 (PDT) X-Received: by 10.36.238.138 with SMTP id b132mr12025498iti.37.1470755165553; Tue, 09 Aug 2016 08:06:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.25.136 with HTTP; Tue, 9 Aug 2016 08:06:04 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Tue, 9 Aug 2016 16:06:04 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pgAdmin IV : Unittest modular patch To: Navnath Gadakh Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks - applied with some minor wording and README tweaks. On Tue, Aug 9, 2016 at 10:19 AM, Navnath Gadakh wrote: > Hi Dave, > > On Mon, Aug 8, 2016 at 9:15 PM, Dave Page > wrote: >> >> Hi >> >> I guess you need to test if tablespace_path is omitted, not just empty? > > Yes, thats right.. Please find the updated patch. >> >> >> This function test the add tablespace scenario (Check Tablespace Node) .= .. >> ERROR >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> ERROR: setUpClass >> >> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_put.= TableSpaceUpdateTestCase) >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/test_tbspc_put.py", >> line 48, in setUpClass >> cls.server_group, cls.server_ids) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 122, in add_table_space >> data =3D get_tablespace_data(server_connect) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 41, in get_tablespace_data >> config_test_data['spc_location'] =3D server_config['tablespace_path'] >> KeyError: 'tablespace_path' >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> ERROR: setUpClass >> >> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_dele= te.TableSpaceDeleteTestCase) >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/test_tbspc_delete.py", >> line 46, in setUpClass >> cls.server_group, cls.server_ids) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 122, in add_table_space >> data =3D get_tablespace_data(server_connect) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 41, in get_tablespace_data >> config_test_data['spc_location'] =3D server_config['tablespace_path'] >> KeyError: 'tablespace_path' >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> ERROR: setUpClass >> >> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_get.= TablespaceGetTestCase) >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/test_tbspc_get.py", >> line 45, in setUpClass >> cls.server_group, cls.server_ids) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 122, in add_table_space >> data =3D get_tablespace_data(server_connect) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 41, in get_tablespace_data >> config_test_data['spc_location'] =3D server_config['tablespace_path'] >> KeyError: 'tablespace_path' >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> ERROR: runTest >> (pgadmin.browser.server_groups.servers.tablespaces.tests.test_tbspc_add.= TableSpaceAddTestCase) >> This function test the add tablespace scenario (Check Tablespace Node) >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/test_tbspc_add.py", >> line 47, in runTest >> self.server_ids) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 122, in add_table_space >> data =3D get_tablespace_data(server_connect) >> File >> "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/tab= lespaces/tests/utils.py", >> line 41, in get_tablespace_data >> config_test_data['spc_location'] =3D server_config['tablespace_path'] >> KeyError: 'tablespace_path' >> >> ---------------------------------------------------------------------- >> Ran 14 tests in 9.326s >> >> FAILED (errors=3D4) >> >> On Mon, Aug 8, 2016 at 3:07 PM, Navnath Gadakh >> wrote: >> > Hi Dave, >> > Please find the updated patch for API unit test cases for Roles and >> > Tablespaces nodes >> > As we finalized >> > Now, >> > 1. The user will specify the tablespace path in test_config.json.in >> > 2. If tablespace path not found, skip the test cases for that >> > server(Only tablespace test cases) >> > 3. Add the skipped test summary in the test result. (Now it's >> > showing on >> > console + in log file, but need to update in a final enhanced test >> > summary >> > report. Which is research point we will work on that after finishing a= ll >> > nodes API test cases) >> > 4. Removed the test_ prefix from the values in the config files. >> > >> > Thanks! >> > >> > >> > On Thu, Aug 4, 2016 at 5:55 PM, Dave Page >> > wrote: >> >> >> >> On Thu, Aug 4, 2016 at 1:02 PM, Navnath Gadakh >> >> wrote: >> >> > Hi Dave, >> >> > >> >> > On Thu, Aug 4, 2016 at 4:04 PM, Dave Page >> >> > >> >> > wrote: >> >> >> >> >> >> Hi >> >> >> >> >> >> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh >> >> >> wrote: >> >> >> >> >> >> >> Oh - does the per-server config override the main config? That's >> >> >> >> useful. So anything that's in test_advanced_config.py can be >> >> >> >> overridden on a per-server basis in test_config.py? >> >> >> > >> >> >> > No. >> >> >> > per-server i.e advance config(test_advanced_config.json.in) >> >> >> > and >> >> >> > main >> >> >> > config(test_config.json) both are different files. In main config >> >> >> > we >> >> >> > just >> >> >> > mention the server=E2=80=99s credentials.(We can also mention pe= r server >> >> >> > credentails) and in test_advanced_config.json.in(here we say >> >> >> > per-server >> >> >> > config) >> >> >> > we mention the advanced configurations i.e. test data for each >> >> >> > node. >> >> >> >> >> >> OK. >> >> >> >> >> >> > So, let's summarize the discussion: >> >> >> > - Let user specify the tablespace path in >> >> >> > test_advanced_config.json.in >> >> >> >> >> >> No - test_config.py. It should be per-server. >> >> > >> >> > We don't have a file named 'test_config.py' but we have a >> >> > server's >> >> > credential file named 'test_config.json'. >> >> > So, you are saying the tablespace path to be added in >> >> > 'test_config.json'. >> >> > Am I correct? >> >> >> >> Yeah, sorry. It should be a property of the server configuration. >> >> >> >> >> >> -- >> >> Dave Page >> >> VP, Chief Architect, Tools & Installers >> >> EnterpriseDB: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> >> >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> > >> > >> > >> > >> > -- >> > Thanks, >> > Navnath Gadakh >> > Software Engineer >> > EnterpriseDB Corporation >> > Mobile: +91 9975389878 >> > >> > >> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake > > > > > -- > Thanks, > Navnath Gadakh > Software Engineer > EnterpriseDB Corporation > Mobile: +91 9975389878 > > --=20 Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --=20 Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers