MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZTzsN7Duyb5KpVuVHBK9pGHXLNvrp7JRVJ1uetAEYhuKg@mail.gmail.com>
References: 
 <CAKKotZTzsN7Duyb5KpVuVHBK9pGHXLNvrp7JRVJ1uetAEYhuKg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 26 Mar 2018 13:22:49 +0100
Message-ID: 
 <CA+OCxoxj2Jp0iaJw4TmRWE4Yz3ZwpF47n7agoeq8rR5MaNhyig@mail.gmail.com>
Subject: Re: [pgAdmin4][RM#3055] Allow user to sort the data in View data mode
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f403045c4e221872cc05684fd5fb"
Precedence: bulk

--f403045c4e221872cc05684fd5fb
Content-Type: text/plain; charset="UTF-8"

Hi

On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala <
murtuza.zabuawala@enterprisedb.com> wrote:

> Hi,
>
> PFA patch which allow user to sort the data in View data mode.
>

The patch looks good in general, however I'm not sure about the UI, in
particular that the closely-linked dialogue for filtering is a completely
different design. I think it would be better to combine the Sort/Filter
options and use a single dialogue for both, as pgAdmin 3 did (though, maybe
not using separate tabs for each part, but the top and bottom of the same
dialogue.

That would certainly fix the consistency of the dialogues (obviously, as
there would only be one!), and I think would perhaps be a more simple
overall UI, particularly for those that want to sort and filter.

Thoughts?

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--f403045c4e221872cc05684fd5fb
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><div class=3D"gmail_extra"><br><div class=3D"gmail_q=
uote">On Sun, Mar 25, 2018 at 7:13 PM, Murtuza Zabuawala <span dir=3D"ltr">=
&lt;<a href=3D"mailto:murtuza.zabuawala@enterprisedb.com" target=3D"_blank"=
>murtuza.zabuawala@enterprisedb.com</a>&gt;</span> wrote:<br><blockquote cl=
ass=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;p=
adding-left:1ex"><div dir=3D"ltr"><div style=3D"font-family:verdana,sans-se=
rif;color:#444444">Hi,</div><div style=3D"font-family:verdana,sans-serif;co=
lor:#444444"><br></div><div style=3D"font-family:verdana,sans-serif;color:#=
444444">PFA patch which allow user to sort the data in View data mode.</div=
></div></blockquote><div><br></div><div>The patch looks good in general, ho=
wever I&#39;m not sure about the UI, in particular that the closely-linked =
dialogue for filtering is a completely different design. I think it would b=
e better to combine the Sort/Filter options and use a single dialogue for b=
oth, as pgAdmin 3 did (though, maybe not using separate tabs for each part,=
 but the top and bottom of the same dialogue.</div><div><br></div><div>That=
 would certainly fix the consistency of the dialogues (obviously, as there =
would only be one!), and I think would perhaps be a more simple overall UI,=
 particularly for those that want to sort and filter.</div><div><br></div><=
div>Thoughts?</div><div><br></div><div>Thanks.=C2=A0</div></div><div><br></=
div>-- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature=
">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_bla=
nk">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseD=
B UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.=
enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--f403045c4e221872cc05684fd5fb--