MIME-Version: 1.0
In-Reply-To: 
 <CAKKotZQz6mGEiky_Szo91tzm_RFvwJTYGriTmuxVYrhcWi5nJg@mail.gmail.com>
References: 
 <CAKKotZQz6mGEiky_Szo91tzm_RFvwJTYGriTmuxVYrhcWi5nJg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 26 Sep 2016 12:38:09 +0100
Message-ID: 
 <CA+OCxoxkphr1YF6F53j3sTreTMvoBOKqV+wjF6CnxoQ-SA+rzA@mail.gmail.com>
Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4)
To: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

Hi

On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where it was not disabling buttons after
> execution gets finished.
> RM#1227
>
> Issue:
> If user clicks on buttons after execution is complete then it was throwing
> error, expected behaviour was all button should gets disabled except execute
> button.

This is an improvement I think, but not complete:

- The info messages are now shown, but:
  - Not until execution ends, which limits their usefulness for
additional debugging. Not sure if that's easily changeable though.
  - The line breaks in messages are displaying like this: "INFO:
Employee 1 not found <br>SELECT 1"

- The first execution of the function worked OK, but following the
second execution, I again saw: "Debugger: Step into execution error"
as I stepped out of the RETURN statement on line 18.

Thanks.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers