MIME-Version: 1.0
In-Reply-To: 
 <CANxoLDe9Yh58zEP8=ZQOAwk=RszUrBwYqxXiR+wmd4pP8i5ZJg@mail.gmail.com>
References: 
 <CANxoLDe9Yh58zEP8=ZQOAwk=RszUrBwYqxXiR+wmd4pP8i5ZJg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 21 Jun 2018 01:50:52 +0100
Message-ID: 
 <CA+OCxoxkuv7863HAB10fxUeJUezDBSNW4awos6-eDgK9-_UZkw@mail.gmail.com>
Subject: Re: [pgadmin4][Patch]: Feature #3273 Add ability to sort in the
 Select File window when opening a saved query
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000aa89bb056f1c4ebd"
Precedence: bulk

--000000000000aa89bb056f1c4ebd
Content-Type: text/plain; charset="UTF-8"

Hi

On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <akshay.joshi@enterprisedb.com
> wrote:

> Hi Hackers,
>
> Attached is the patch for Feature #3273 Add ability to sort in the Select
> File window when opening a saved query.
>
> I haven't seen any refactoring possibility, patch contains feature test
> with *time.sleep(0.05). *I have spend lot of time to not introduce
> "time.sleep()" and tried couple of different ways of WebDriveWait, but
> didn't get success.
>
> Please review it.
>

I get the following running the feature tests:

invalid syntax (xss_checks_file_manager_test.py, line 60)

make: *** [check-feature] Error 1

Also; should that file be renamed now, to reflect that it tests more than
just XSS?


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--000000000000aa89bb056f1c4ebd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<div class=3D"gmail_extra"><br><div class=3D"gmail_quote=
">On Wed, Jun 20, 2018 at 3:13 PM, Akshay Joshi <span dir=3D"ltr">&lt;<a hr=
ef=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.joshi@=
enterprisedb.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><d=
iv dir=3D"ltr"><span style=3D"font-size:12.8px;text-decoration-style:initia=
l;text-decoration-color:initial;float:none;display:inline">Hi Hackers,</spa=
n><div style=3D"font-size:12.8px;text-decoration-style:initial;text-decorat=
ion-color:initial"><br></div><div style=3D"text-decoration-style:initial;te=
xt-decoration-color:initial"><span style=3D"font-size:12.8px">Attached is t=
he patch for Feature #3273 Add ability to sort in the Select File window wh=
en opening a saved query.</span></div><div style=3D"text-decoration-style:i=
nitial;text-decoration-color:initial"><span style=3D"font-size:12.8px"><br>=
</span></div><div style=3D"text-decoration-style:initial;text-decoration-co=
lor:initial"><span style=3D"font-size:12.8px">I haven&#39;t seen any refact=
oring possibility, patch contains feature test with <b>time.sleep(0.05). </=
b>I have spend lot of time to not introduce &quot;time.sleep()&quot; and tr=
ied couple of different ways of <span id=3D"m_3629997752139096009:2om.1">We=
bDriveWait</span>, but didn&#39;t get success.=C2=A0</span></div><span styl=
e=3D"font-size:12.8px;text-decoration-style:initial;text-decoration-color:i=
nitial;float:none;display:inline"><div><span style=3D"font-size:12.8px;text=
-decoration-style:initial;text-decoration-color:initial;float:none;display:=
inline"><br></span></div>Please review it.</span></div></blockquote><div><b=
r></div><div>I get the following running the feature tests:</div><div><br><=
/div><div>


<span></span>


<p class=3D"gmail-p1" style=3D"margin:0px;font-variant-numeric:normal;font-=
variant-east-asian:normal;font-weight:normal;font-stretch:normal;font-size:=
12px;line-height:normal;font-family:&quot;Andale Mono&quot;;color:rgb(40,25=
4,20);background-color:rgba(0,0,0,0.9)"><span class=3D"gmail-s1" style=3D"f=
ont-variant-ligatures:no-common-ligatures">invalid syntax (xss_checks_file_=
manager_test.py, line 60)</span></p>
<p class=3D"gmail-p1" style=3D"margin:0px;font-variant-numeric:normal;font-=
variant-east-asian:normal;font-weight:normal;font-stretch:normal;font-size:=
12px;line-height:normal;font-family:&quot;Andale Mono&quot;;color:rgb(40,25=
4,20);background-color:rgba(0,0,0,0.9)"><span class=3D"gmail-s1" style=3D"f=
ont-variant-ligatures:no-common-ligatures">make: *** [check-feature] Error =
1</span></p>


<div><br></div>Also; should that file be renamed now, to reflect that it te=
sts more than just XSS?=C2=A0</div></div><br clear=3D"all"><div><br></div>-=
- <br><div class=3D"gmail_signature" data-smartmail=3D"gmail_signature">Dav=
e Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D"_blank">h=
ttp://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK:=
 <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http://www.enter=
prisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</div></div>

--000000000000aa89bb056f1c4ebd--