Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyZHs-0001Gc-QH for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 08:40:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1eyZHr-0007Q6-M1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 21 Mar 2018 08:39:59 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eyZHq-0007Pw-RA for pgadmin-hackers@lists.postgresql.org; Wed, 21 Mar 2018 08:39:59 +0000 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1eyZHk-0007E9-Rj for pgadmin-hackers@postgresql.org; Wed, 21 Mar 2018 08:39:57 +0000 Received: by mail-wm0-x22d.google.com with SMTP id e194so8065971wmd.3 for ; Wed, 21 Mar 2018 01:39:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cPCRR5s8HdyosRbHGONTq4cFKn3f83n8oaefe9TA4UQ=; b=2DQ8nKwpWg/LGhmnkRiGNTyoQk4mm+TKojad6z/SpkRIU+xVZLqXS61HusLA/B78Ns wTeBTvwNvNhVfAyUaY6f/0utzbz3DBs/3vOi21dOUfsvFDGybQerdFqLK0GUqFF4JPFi nIweGHhlVuAMjOmRf7kD7w9JkQTprlNjs4AzGoqXuHlJOatgJarN0Jd3GZoZWv3eiZwg RCMBcwUONegi9zGdFWUS0zjhOjrUWkMm+xflLG5OpdvWAXvXuQoBxR8YzQOCjHlliujY 2+qfSBCgl9OgYmCN/FSRme4zctOdxahOCwMEdsUVwmAX/MRjqNDyhfDBi/Myz5+tQDO7 PzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cPCRR5s8HdyosRbHGONTq4cFKn3f83n8oaefe9TA4UQ=; b=kOqQ3QksmU2r5W2pkVGJFzSBqkKUo4SEa7+NpJpBcRBplzXwisuOI3M5cnyOV0MTwU APEU1NDLYj1R1sm1ZsXAGQ16B+yqvaUVBXWDE7psFKM3OXKGK5YYXkoPJGWOkHaSqFBT RC7PTudYbYILt+Xve1Vl5xZ4vTUS3Yqnr7o8gIfhqYeOHhdUC3Lyf3s+m3ddwDuUwbSU l7k7H3hKhsXIqAKDz6NrRflPdxJ4Z3kSHj+9ngHtWPZRebCzGD+U+ux2GoBh41pijG1M NfxZZr+IjkqhFg8RoRnWPUu/yqfa+y0pSA4sx/8nnwaLYToha6qFEaj5xXpWKf6lgdpi Ooeg== X-Gm-Message-State: AElRT7FKskk/9yhif/nKPKMMfM/QT1xlvqCkNm6ckWOXE5qorSeeY8eC PkGE26uKQ4y4Ayy9VhHJdg1psF9l2CnM+HIMP8qIeetvnODE2ITcKX0owQmx5u+laGQE0/3EjqJ GyfouEIOWBGXltr0pKWJQOIr1ViGb3zKmgc/I5icvmhKHMx2rd/5QI2vdOumea3VzpQ7LjMmzzd MBwgnd7g== X-Google-Smtp-Source: AG47ELsR4pMTKbfbvyavnDmujnkW6UqfLeKMrXG0gaywGUiOyjvg+vO2w1flxpCeIUZ/sNtw+3sEig== X-Received: by 10.80.186.203 with SMTP id x69mr21019158ede.151.1521621589399; Wed, 21 Mar 2018 01:39:49 -0700 (PDT) Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id 26sm3167963eds.26.2018.03.21.01.39.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Mar 2018 01:39:47 -0700 (PDT) Received: by mail-wr0-f170.google.com with SMTP id o8so4291894wra.1 for ; Wed, 21 Mar 2018 01:39:47 -0700 (PDT) X-Received: by 10.223.196.74 with SMTP id a10mr10566135wrg.190.1521621587146; Wed, 21 Mar 2018 01:39:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 21 Mar 2018 01:39:46 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 21 Mar 2018 08:39:46 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [pgadmin][patch] [GreenPlum] When user press Explain Plan and Explain analyze plan an error is displayed To: Akshay Joshi Cc: Victoria Henry , Joao Pedro De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="089e082813042f51400567e8224f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --089e082813042f51400567e8224f Content-Type: text/plain; charset="UTF-8" Thanks, applied. All tests pass on my machine, now waiting for Jenkins to run. Assuming all is good, I'll build the release packages. On Wed, Mar 21, 2018 at 7:27 AM, Akshay Joshi wrote: > Hi Victoria, > > In "is_new_transaction_required.js" file I have modified the code and > handled both "responseJSON" and "axios" responses, but in your patch you > have removed "responseJSON" part which is required because "i > *s_new_transaction_required*()" function is also called from sqleditor.js > with normal javascript response. > > I have re-added that code and also found one issue where "from pgadmin. > utils.exception import ConnectionLost" statement is missing from "web/ > pgadmin/utils/driver/psycopg2/server_manager.py" file, so I added that > too. > > Attached is the modified patch. > > On Wed, Mar 21, 2018 at 2:09 AM, Victoria Henry wrote: > >> Hi Hackers, >> >> We fixed the tests and refactored some of the code. All tests pass now. >> Attached is the reviewed patch. >> >> Sincerely, >> >> Joao and Victoria >> >> On Tue, Mar 20, 2018 at 10:05 AM, Dave Page >> wrote: >> >>> Hi >>> >>> This doesn't pass the Javascript tests for me. Please investigate ASAP: >>> >>> webpack: Compiled successfully. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 152 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 153 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 154 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 155 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 156 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 157 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 158 of 486 SUCCESS (0 >>> secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is not required >>> should highlight the error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> error in JSON' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11753:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 285 of 486 (1 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is not required >>> should highlight the error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> error in JSON' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is not required >>> should add new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some error in JSON' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11760:60 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 286 of 486 (2 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is not required >>> should add new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some error in JSON' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is required >>> should login is displayed FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11840:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 296 of 486 (3 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when JSON response is available when login is required >>> should login is displayed FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is not >>> required should highlight the error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> plain text error' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11875:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 299 of 486 (4 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is not >>> required should highlight the error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> plain text error' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is not >>> required should add new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some plain text error' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11882:60 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 300 of 486 (5 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is not >>> required should add new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some plain text error' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is required >>> should login is displayed FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> at regression/javascript/sqleditor/execute_query_spec.js:11964:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 310 of 486 (6 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when no JSON response is available when login is required >>> should login is displayed FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when cannot reach the Python Server should add new entry to >>> history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12002:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 314 of 486 (7 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is the query tool when an error occur when the connection to the >>> server was lost when cannot reach the Python Server should add new entry to >>> history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when JSON response is available should highlight the >>> error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> error in JSON' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12232:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 334 of 486 (8 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when JSON response is available should highlight the >>> error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> error in JSON' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when JSON response is available should add new entry to >>> history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some error in JSON' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12239:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 335 of 486 (9 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when JSON response is available should add new entry to >>> history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some error in JSON' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when no JSON response is available should highlight the >>> error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> plain text error' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12282:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 340 of 486 (10 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when no JSON response is available should highlight the >>> error in the SQL panel FAILED >>> Expected spy SqlEditor._highlight_error to have been called with [ 'Some >>> plain text error' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when no JSON response is available should add new entry >>> to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some plain text error' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12289:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 341 of 486 (11 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when no JSON response is available should add new entry >>> to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Some plain text error' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when cannot reach the Python Server should add new >>> entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12340:58 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 347 of 486 (12 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when >>> SQLEditor is NOT the query tool when an error occur when the connection to >>> the server was lost when cannot reach the Python Server should add new >>> entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when cannot reach the Python Server should add >>> new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12645:54 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 376 of 486 (13 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when cannot reach the Python Server should add >>> new entry to history and update the Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'Not connected to the server or the connection to the server has >>> been closed.' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is not required should add new entry to history and update the Messages tab >>> FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12693:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 381 of 486 (14 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is not required should add new entry to history and update the Messages tab >>> FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should add new entry to history and update the Messages tab >>> FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12751:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 388 of 486 (15 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should add new entry to history and update the Messages tab >>> FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should save the state FAILED >>> Expected spy SqlEditor.save_state to have been called with [ 'execute', >>> [ '' ] ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12774:48 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 391 of 486 (16 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should save the state FAILED >>> Expected spy SqlEditor.save_state to have been called with [ 'execute', >>> [ '' ] ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should display pga login FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12780:52 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 392 of 486 (17 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when login >>> is required should display pga login FAILED >>> Expected spy UserManagement.pga_login to have been called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is not required should add new entry to history and update the >>> Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12809:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 395 of 486 (18 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is not required should add new entry to history and update the >>> Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should add new entry to history and update the >>> Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12874:56 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 403 of 486 (19 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should add new entry to history and update the >>> Messages tab FAILED >>> Expected spy SqlEditor.update_msg_history to have been called with [ >>> false, 'some error message' ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should save the state FAILED >>> Expected spy SqlEditor.save_state to have been called with [ 'execute', >>> [ '' ] ] but it was never called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12897:48 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 406 of 486 (20 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should save the state FAILED >>> Expected spy SqlEditor.save_state to have been called with [ 'execute', >>> [ '' ] ] but it was never called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should initialize a new transaction FAILED >>> Expected spy SqlEditor.init_transaction to have been called. >>> at regression/javascript/sqleditor/execute_query_spec.js:12909:54 >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 408 of 486 (21 FAILED) >>> (0 secs / 0 secs) >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the >>> SQL statement is not empty when error is returned by the server when a new >>> transaction is required should initialize a new transaction FAILED >>> Expected spy SqlEditor.init_transaction to have been called. >>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 486 of 486 (21 FAILED) >>> (7.05 secs / 0 secs) >>> error Command failed with exit code 1. >>> info Visit https://yarnpkg.com/en/docs/cli/run for documentation about >>> this command. >>> make: *** [check-js] Error 1 >>> >>> >>> On Tue, Mar 20, 2018 at 1:12 PM, Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Hackers >>>> >>>> Attached is the patch file to fix the RM #2815. >>>> >>>> On Tue, Mar 20, 2018 at 3:24 PM, Dave Page >>>> wrote: >>>> >>>>> >>>>> >>>>> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Tue, Mar 20, 2018 at 3:06 PM, Dave Page >>>>> .com> wrote: >>>>>> >>>>>>> I'm a little concerned that noone mentioned this earlier; I'm >>>>>>> supposed to be building the release this afternoon, and I expect this >>>>>>> change to at the very least be complex to fully test and verify. What's the >>>>>>> ETA on the patch? What steps are being taken to ensure it's correct and >>>>>>> doesn't cause regressions? >>>>>>> >>>>>> >>>>>> Harshal has already mentioned in the RM. Currently I am changing >>>>>> the logic, but it may take time to complete, fully test and verify. I'll >>>>>> try my best to do it asap. >>>>>> >>>>> >>>>> Sure, but how many of us are watching every comment on every RM? I >>>>> know I'm not (I currently average ~400 emails/day). >>>>> >>>>> >>>>>> >>>>>>> On Tue, Mar 20, 2018 at 7:51 AM, Akshay Joshi < >>>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Joao >>>>>>>> >>>>>>>> It seems that this fix broke the functionality of RM #2815. It is >>>>>>>> mentioned in the RM what needs to be fixed now and I am currently working >>>>>>>> on it. >>>>>>>> While fixing the issue following problem that I found >>>>>>>> >>>>>>>> - In "start_running_query.py" file, we need to remove check "if >>>>>>>> conn.connected()" from "__execute_query" function as we >>>>>>>> required exception to be thrown while executing the query to identify the >>>>>>>> ConnectionLost. >>>>>>>> - In "execute_query.js" we have used *axios* to execute the >>>>>>>> query and in case of exception, object is different then normal javascript >>>>>>>> response object. >>>>>>>> - We call following functions when exception or error comes and >>>>>>>> send the "*.response.data*" as parameter >>>>>>>> - wasConnectionLostToServer(): Check for the readyState >>>>>>>> parameter, which is not the part of ".response.data". >>>>>>>> - extractErrorMessage(): Check for the "responseJSON" and " >>>>>>>> responseJSON.info", which is not the part of >>>>>>>> ".response.data". >>>>>>>> - is_pga_login_required(): Check for the "responseJSON" and " >>>>>>>> responseJSON.info", which is not the part of >>>>>>>> ".response.data". >>>>>>>> - is_new_transaction_required(): Check for the "responseJSON" >>>>>>>> and "responseJSON.info", which is not the part of >>>>>>>> ".response.data". >>>>>>>> >>>>>>>> From the above list, some of the function calls are generic where >>>>>>>> they need "responseJSON" and "responseJSON.info", so we can't >>>>>>>> change that. Possible solution could be pass one extra flag as parameter to >>>>>>>> identify the object is a axios response or javascript response to >>>>>>>> above functions and change the logic accordingly. >>>>>>>> >>>>>>>> Please let me know your thoughts or any other suggestion. >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Feb 9, 2018 at 8:17 PM, Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Thanks, applied. >>>>>>>>> >>>>>>>>> On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira < >>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>> >>>>>>>>>> Hello, >>>>>>>>>> Attached you can find the fix for the current pronlem >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Feb 9, 2018 at 7:29 AM Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Joao, >>>>>>>>>>> >>>>>>>>>>> It looks like Jenkins has taken umbrage to this change, at least >>>>>>>>>>> with Python 3.x. Can you take a look please? >>>>>>>>>>> >>>>>>>>>>> https://jenkins.pgadmin.org/ >>>>>>>>>>> >>>>>>>>>>> Thanks. >>>>>>>>>>> >>>>>>>>>>> On Fri, Feb 9, 2018 at 11:54 AM, Dave Page >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Thanks, patches applied. >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira < >>>>>>>>>>>> jdealmeidapereira@pivotal.io> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Hackers, >>>>>>>>>>>>> This is quite a big patch in order to solve the problem with >>>>>>>>>>>>> the Explain Plan. >>>>>>>>>>>>> >>>>>>>>>>>>> We sent 2 patches that have the following: >>>>>>>>>>>>> *- update-javascript-packages.diff * >>>>>>>>>>>>> Add package: >>>>>>>>>>>>> is-docker to select a specific setting when running the >>>>>>>>>>>>> Chrome tests in >>>>>>>>>>>>> Docker >>>>>>>>>>>>> >>>>>>>>>>>>> Upgrade the version of: >>>>>>>>>>>>> - babel-loader >>>>>>>>>>>>> - extract-text-webpack-plugin >>>>>>>>>>>>> - jasmine-core >>>>>>>>>>>>> - jasmine-enzyme >>>>>>>>>>>>> - moment >>>>>>>>>>>>> *- explain-plan-greenplum.diff* >>>>>>>>>>>>> Extract SQLEditor.execute and SQLEditor._poll into their own >>>>>>>>>>>>> files and add test around them >>>>>>>>>>>>> Extract SQLEditor backend functions that start executing >>>>>>>>>>>>> query to their own files and add tests around it >>>>>>>>>>>>> Move the Explain SQL from the front-end and now pass the >>>>>>>>>>>>> Explain plan parameters as a JSON object in the start query call. >>>>>>>>>>>>> Extract the compile_template_name into a function that can >>>>>>>>>>>>> be used by the different places that try to select the version of the >>>>>>>>>>>>> template and the server type >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> Joao >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Dave Page >>>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>>> >>>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Dave Page >>>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>>> Twitter: @pgsnake >>>>>>>>>>> >>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Akshay Joshi* >>>>>>>> >>>>>>>> *Sr. Software Architect * >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> VP, Chief Architect, Tools & Installers >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Akshay Joshi* >>>>>> >>>>>> *Sr. Software Architect * >>>>>> >>>>>> >>>>>> >>>>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>>>> 976-788-8246 <+91%2097678%2088246>* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> VP, Chief Architect, Tools & Installers >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>> >>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 >>>> 976-788-8246 <+91%2097678%2088246>* >>>> >>> >>> >>> >>> -- >>> Dave Page >>> VP, Chief Architect, Tools & Installers >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >> >> > > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake --089e082813042f51400567e8224f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied. All tests pass on my machine, now waiting= for Jenkins to run. Assuming all is good, I'll build the release packa= ges.



On Wed, Mar 21, 2018 at 7:27 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Victoria,

In "is_new_transaction_required.js" file I have modified the code and handled both = "responseJSON" = and "axios" res= ponses, but in your patch you have removed "responseJSON" part which is required because &= quot;is_new_transaction_required()" function is also calle= d from sqleditor.js with normal javascript respons= e.

I have re-added that code and also found one issue where &q= uot;from pgadmin.utils.exception import ConnectionLost" statement is= missing from "web/pgadmin<= /span>/utils/driver/= psycopg2/server_manager.py" file, so I added that too.

Attached is the modified pa= tch.=C2=A0 =C2=A0

On Wed, Mar 21, 2018 at = 2:09 AM, Victoria Henry <vhenry@pivotal.io> wrote:
Hi Hackers,

We= fixed the tests and refactored some of the code.=C2=A0 All tests pass now.= =C2=A0 Attached is the reviewed patch.

Sincerely,<= /div>

Joao and Victoria

On Tue, Mar 20, 2018 at 10:= 05 AM, Dave Page <dave.page@enterprisedb.com> wrote= :
Hi

= This doesn't pass the Javascript tests for me. Please investigate ASAP:=

webpack: Compiled successfully.
He= adlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 152 of 486 SUCCESS (0 secs = / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 153 o= f 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10= .12.6): Executed 154 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChr= ome 0.0.0 (Mac OS X 10.12.6): Executed 155 of 486 SUCCESS (0 secs / 0 secs)=
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 156 of 486 SUC= CESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): E= xecuted 157 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0= (Mac OS X 10.12.6): Executed 158 of 486 SUCCESS (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor= is the query tool when an error occur when the connection to the server wa= s lost when JSON response is available when login is not required should hi= ghlight the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been = called with [ 'Some error in JSON' ] but it was never called.
=
=C2=A0 =C2=A0 at regressi= on/javascript/sqleditor/execute_query_spec.js:11753:58
= HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 285 of 486 (1 FAILED) (0 = secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQue= ry #poll when SQLEditor is the query tool when an error occur when the conn= ection to the server was lost when JSON response is available when login is= not required should highlight the error in the SQL panel FAILED
= Expected spy SqlEditor._highli= ght_error to have been called with [ 'Some error in JSON' ] but it = was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Execute= Query #poll when SQLEditor is the query tool when an error occur when the c= onnection to the server was lost when JSON response is available when login= is not required should add new entry to history and update the Messages ta= b FAILED
Expected sp= y SqlEditor.update_msg_history to have been called with [ false, 'Some = error in JSON' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:11760:60
HeadlessChrome 0.0.0 (Ma= c OS X 10.12.6): Executed 286 of 486 (2 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor = is the query tool when an error occur when the connection to the server was= lost when JSON response is available when login is not required should add= new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_hist= ory to have been called with [ false, 'Some error in JSON' ] but it= was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Execut= eQuery #poll when SQLEditor is the query tool when an error occur when the = connection to the server was lost when JSON response is available when logi= n is required should login is displayed FAILED
Expected spy UserManagement.pga_login to have be= en called.
=C2=A0 = =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:11840:= 56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 296 of = 486 (3 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 1= 0.12.6) ExecuteQuery #poll when SQLEditor is the query tool when an error o= ccur when the connection to the server was lost when JSON response is avail= able when login is required should login is displayed FAILED
Expected spy UserManagement.pga_lo= gin to have been called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) = ExecuteQuery #poll when SQLEditor is the query tool when an error occur whe= n the connection to the server was lost when no JSON response is available = when login is not required should highlight the error in the SQL panel FAIL= ED
Expected spy SqlE= ditor._highlight_error to have been called with [ 'Some plain text erro= r' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute= _query_spec.js:11875:58
HeadlessChrome 0.0.0 (Mac OS X 10.12= .6): Executed 299 of 486 (4 FAILED) (0 secs / 0 secs)
HeadlessChr= ome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query= tool when an error occur when the connection to the server was lost when n= o JSON response is available when login is not required should highlight th= e error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been called wit= h [ 'Some plain text error' ] but it was never called.
He= adlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is = the query tool when an error occur when the connection to the server was lo= st when no JSON response is available when login is not required should add= new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_hist= ory to have been called with [ false, 'Some plain text error' ] but= it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.= js:11882:60
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Execute= d 300 of 486 (5 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (M= ac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is the query tool when a= n error occur when the connection to the server was lost when no JSON respo= nse is available when login is not required should add new entry to history= and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been call= ed with [ false, 'Some plain text error' ] but it was never called.=
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when = SQLEditor is the query tool when an error occur when the connection to the = server was lost when no JSON response is available when login is required s= hould login is displayed FAILED
Expected spy UserManagement.pga_login to have been called.
=C2=A0 =C2=A0 at regress= ion/javascript/sqleditor/execute_query_spec.js:11964:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 310 of 486 (6 FAILED) (0= secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQu= ery #poll when SQLEditor is the query tool when an error occur when the con= nection to the server was lost when no JSON response is available when logi= n is required should login is displayed FAILED
Expected spy UserManagement.pga_login to have be= en called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #= poll when SQLEditor is the query tool when an error occur when the connecti= on to the server was lost when cannot reach the Python Server should add ne= w entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history= to have been called with [ false, 'Not connected to the server or the = connection to the server has been closed.' ] but it was never called.
=C2=A0 =C2=A0 at regr= ession/javascript/sqleditor/execute_query_spec.js:12002:58
<= div>HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 314 of 486 (7 FAILED)= (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Execut= eQuery #poll when SQLEditor is the query tool when an error occur when the = connection to the server was lost when cannot reach the Python Server shoul= d add new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg= _history to have been called with [ false, 'Not connected to the server= or the connection to the server has been closed.' ] but it was never c= alled.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll= when SQLEditor is NOT the query tool when an error occur when the connecti= on to the server was lost when JSON response is available should highlight = the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been called w= ith [ 'Some error in JSON' ] but it was never called.
=C2=A0 =C2=A0 at regression/javas= cript/sqleditor/execute_query_spec.js:12232:56
Headless= Chrome 0.0.0 (Mac OS X 10.12.6): Executed 334 of 486 (8 FAILED) (0 secs / 0= secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll= when SQLEditor is NOT the query tool when an error occur when the connecti= on to the server was lost when JSON response is available should highlight = the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have been called w= ith [ 'Some error in JSON' ] but it was never called.
Hea= dlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is N= OT the query tool when an error occur when the connection to the server was= lost when JSON response is available should add new entry to history and u= pdate the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called wit= h [ false, 'Some error in JSON' ] but it was never called.
=C2=A0 =C2=A0 at regression/= javascript/sqleditor/execute_query_spec.js:12239:58
Hea= dlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 335 of 486 (9 FAILED) (0 sec= s / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery = #poll when SQLEditor is NOT the query tool when an error occur when the con= nection to the server was lost when JSON response is available should add n= ew entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_histor= y to have been called with [ false, 'Some error in JSON' ] but it w= as never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQ= uery #poll when SQLEditor is NOT the query tool when an error occur when th= e connection to the server was lost when no JSON response is available shou= ld highlight the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error to have = been called with [ 'Some plain text error' ] but it was never calle= d.
=C2=A0 =C2=A0 at = regression/javascript/sqleditor/execute_query_spec.js:12282:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 340 of 486 (10 FA= ILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) E= xecuteQuery #poll when SQLEditor is NOT the query tool when an error occur = when the connection to the server was lost when no JSON response is availab= le should highlight the error in the SQL panel FAILED
Expected spy SqlEditor._highlight_error t= o have been called with [ 'Some plain text error' ] but it was neve= r called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #p= oll when SQLEditor is NOT the query tool when an error occur when the conne= ction to the server was lost when no JSON response is available should add = new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_histo= ry to have been called with [ false, 'Some plain text error' ] but = it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.j= s:12289:58
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed= 341 of 486 (11 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (M= ac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the query tool wh= en an error occur when the connection to the server was lost when no JSON r= esponse is available should add new entry to history and update the Message= s tab FAILED
Expecte= d spy SqlEditor.update_msg_history to have been called with [ false, 'S= ome plain text error' ] but it was never called.
HeadlessChro= me 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor is NOT the qu= ery tool when an error occur when the connection to the server was lost whe= n cannot reach the Python Server should add new entry to history and update= the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called with [ f= alse, 'Not connected to the server or the connection to the server has = been closed.' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:12340:58
HeadlessChrome 0.0.0 (Mac= OS X 10.12.6): Executed 347 of 486 (12 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #poll when SQLEditor = is NOT the query tool when an error occur when the connection to the server= was lost when cannot reach the Python Server should add new entry to histo= ry and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been ca= lled with [ false, 'Not connected to the server or the connection to th= e server has been closed.' ] but it was never called.
Headles= sChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL stateme= nt is not empty when cannot reach the Python Server should add new entry to= history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have b= een called with [ false, 'Not connected to the server or the connection= to the server has been closed.' ] but it was never called.
<= span style=3D"white-space:pre-wrap"> =C2=A0 =C2=A0 at regression/jav= ascript/sqleditor/execute_query_spec.js:12645:54
Headle= ssChrome 0.0.0 (Mac OS X 10.12.6): Executed 376 of 486 (13 FAILED) (0 secs = / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #e= xecute when the SQL statement is not empty when cannot reach the Python Ser= ver should add new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.u= pdate_msg_history to have been called with [ false, 'Not connected to t= he server or the connection to the server has been closed.' ] but it wa= s never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQu= ery #execute when the SQL statement is not empty when error is returned by = the server when login is not required should add new entry to history and u= pdate the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been called wit= h [ false, 'some error message' ] but it was never called.
=C2=A0 =C2=A0 at regression/= javascript/sqleditor/execute_query_spec.js:12693:56
Hea= dlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 381 of 486 (14 FAILED) (0 se= cs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery= #execute when the SQL statement is not empty when error is returned by the= server when login is not required should add new entry to history and upda= te the Messages tab FAILED
= Expected spy SqlEditor.update_msg_history to have been called with [= false, 'some error message' ] but it was never called.
H= eadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL s= tatement is not empty when error is returned by the server when login is re= quired should add new entry to history and update the Messages tab FAILED
Expected spy SqlEdito= r.update_msg_history to have been called with [ false, 'some error mess= age' ] but it was never called.
=C2=A0 =C2=A0 at regression/javascript/sqleditor/execu= te_query_spec.js:12751:56
HeadlessChrome 0.0.0 (Mac OS X 10.= 12.6): Executed 388 of 486 (15 FAILED) (0 secs / 0 secs)
Headless= Chrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statemen= t is not empty when error is returned by the server when login is required = should add new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.updat= e_msg_history to have been called with [ false, 'some error message'= ; ] but it was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12= .6) ExecuteQuery #execute when the SQL statement is not empty when error is= returned by the server when login is required should save the state FAILED=
Expected spy SqlEdi= tor.save_state to have been called with [ 'execute', [ '' ]= ] but it was never called.
= =C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query= _spec.js:12774:48
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): E= xecuted 391 of 486 (16 FAILED) (0 secs / 0 secs)
HeadlessChrome 0= .0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not= empty when error is returned by the server when login is required should s= ave the state FAILED
Expected spy SqlEditor.save_state to have been called with [ 'execute&= #39;, [ '' ] ] but it was never called.
HeadlessChrome 0.= 0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not = empty when error is returned by the server when login is required should di= splay pga login FAILED
Expected spy UserManagement.pga_login to have been called.
=C2=A0 =C2=A0 at regression/javas= cript/sqleditor/execute_query_spec.js:12780:52
Headless= Chrome 0.0.0 (Mac OS X 10.12.6): Executed 392 of 486 (17 FAILED) (0 secs / = 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #exe= cute when the SQL statement is not empty when error is returned by the serv= er when login is required should display pga login FAILED
Expected spy UserManagement.pga_login= to have been called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Exe= cuteQuery #execute when the SQL statement is not empty when error is return= ed by the server when a new transaction is not required should add new entr= y to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to ha= ve been called with [ false, 'some error message' ] but it was neve= r called.
=C2=A0 =C2= =A0 at regression/javascript/sqleditor/execute_query_spec.js:12809:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 395 of 486= (18 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.= 12.6) ExecuteQuery #execute when the SQL statement is not empty when error = is returned by the server when a new transaction is not required should add= new entry to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_hist= ory to have been called with [ false, 'some error message' ] but it= was never called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) Execut= eQuery #execute when the SQL statement is not empty when error is returned = by the server when a new transaction is required should add new entry to hi= story and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have been= called with [ false, 'some error message' ] but it was never calle= d.
=C2=A0 =C2=A0 at = regression/javascript/sqleditor/execute_query_spec.js:12874:56
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 403 of 486 (19 FA= ILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) E= xecuteQuery #execute when the SQL statement is not empty when error is retu= rned by the server when a new transaction is required should add new entry = to history and update the Messages tab FAILED
Expected spy SqlEditor.update_msg_history to have= been called with [ false, 'some error message' ] but it was never = called.
HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #exe= cute when the SQL statement is not empty when error is returned by the serv= er when a new transaction is required should save the state FAILED
Expected spy SqlEditor.save_= state to have been called with [ 'execute', [ '' ] ] but it= was never called.
= =C2=A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js= :12897:48
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed = 406 of 486 (20 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Ma= c OS X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty w= hen error is returned by the server when a new transaction is required shou= ld save the state FAILED
Expected spy SqlEditor.save_state to have been called with [ 'exec= ute', [ '' ] ] but it was never called.
HeadlessChrom= e 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the SQL statement is = not empty when error is returned by the server when a new transaction is re= quired should initialize a new transaction FAILED
Expected spy SqlEditor.init_transaction to ha= ve been called.
=C2= =A0 =C2=A0 at regression/javascript/sqleditor/execute_query_spec.js:12= 909:54
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 408= of 486 (21 FAILED) (0 secs / 0 secs)
HeadlessChrome 0.0.0 (Mac O= S X 10.12.6) ExecuteQuery #execute when the SQL statement is not empty when= error is returned by the server when a new transaction is required should = initialize a new transaction FAILED
Expected spy SqlEditor.init_transaction to have been called= .
HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 486 of 486 (2= 1 FAILED) (7.05 secs / 0 secs)
error Command failed with exit cod= e 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documenta= tion about this command.
make: *** [check-js] Error 1
=

<= div class=3D"gmail_extra">
On Tue, Mar 20, 20= 18 at 1:12 PM, Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
= Hi Hackers

Attached is the patch file to fix the RM #281= 5.

On Tue, Mar 20, 2018 at 3:24 PM, Dave Page <dave= .page@enterprisedb.com> wrote:


On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi <a= kshay.joshi@enterprisedb.com> wrote:


On Tue, Mar 20, 2018 at 3:06 PM, Dave Page <enterprisedb.com> wrote:
I'm a little concerned that noon= e mentioned this earlier; I'm supposed to be building the release this = afternoon, and I expect this change to at the very least be complex to full= y test and verify. What's the ETA on the patch? What steps are being ta= ken to ensure it's correct and doesn't cause regressions?

=C2=A0 =C2=A0 Harshal has already = mentioned in the RM. Currently I am changing the logic, but it may take tim= e to complete, fully test and verify. I'll try my best to do it asap.

Sure, but how= many of us are watching every comment on every RM? I know I'm not (I c= urrently average ~400 emails/day).
<= div>=C2=A0

On Tue, Mar 20, 2018 at 7:51 AM, Aks= hay Joshi <akshay.joshi@enterprisedb.com> w= rote:
Hi Joao

It seems that this= fix broke the functionality of RM #2815. It is mentioned in the RM what ne= eds to be fixed now and I am currently working on it.
While fixin= g the issue following problem that I found
  • In "start_running_query.py" file, we need to remove check "if conn.connected()" from "__exec= ute_query" function as we required exception to be thrown while execut= ing the query to identify the Conn= ectionLost.=C2=A0=C2=A0
  • In "execute_query.js" we have used axios to execute the query and = in case of exception, object is different then normal javascript response o= bject.=C2=A0
  • We call following functions when exception or error co= mes and send the "<object>.response.data" as paramet= er=C2=A0
    • wasConnection= LostToServer(): Check for the readyState parameter, which is not the part of "<object&g= t;.response.data".=C2=A0
    • extractErrorMessage(): Check for the &= quot;responseJSON" an= d "responseJSON.info&= quot;,=C2=A0which is not the part of "= <object>.response.data".
    • is_pga_l= ogin_required(): Check for the=C2=A0"response= JSON" and "respo= nseJSON.info",=C2=A0whic= h is not the part of "<object>.response.data".
      • <= li>is_new_transaction_required():=C2=A0Check = for the=C2=A0&quo= t;responseJSON" and &= quot;responseJSON.info&quo= t;,=C2=A0which is not the part of &q= uot;<object>.response.data".
From the above= list, some of the function calls are generic where they need "responseJSON" and "responseJSON.info", so we= can't change that. Possible solution could be pass one extra flag as p= arameter to identify the object is a axios response or javascript response to above functions and cha= nge the logic accordingly.

Please let me know your= thoughts or any other suggestion.=C2=A0
=C2=A0 =C2=A0 =C2=A0=C2= =A0

On Fri, Feb 9, 2018 at 8:17 PM, Dave Page <dpage@pgad= min.org> wrote:
Thanks, applied.

On Fri, Feb 9, 2018 at 2:35 PM, Joao De Almeida Pereira <= span dir=3D"ltr"><jdealmeidapereira@pivotal.io> wrote:
Hello,
Attached you can find the= fix for the current pronlem


On Fri, Feb 9, 2018 at 7:29 AM Dave Page <dpage@pgadmin.org> wrote:
Hi Joao,

=
It looks like Jenkins has taken umbrage to this change, at least with = Python 3.x. Can you take a look please?


Thanks.

On Fri, Feb 9, 2018 at 11:54 AM, Dave= Page <dpage@pgadmin.org> wrote:
Thanks, patches applied.

On Fr= i, Feb 2, 2018 at 10:50 PM, Joao De Almeida Pereira <<= a href=3D"mailto:jdealmeidapereira@pivotal.io" target=3D"_blank">jdealmeida= pereira@pivotal.io> wrote:
=
Hi Hackers,
This is quite a big patch in order to solv= e the problem with the Explain Plan.

We sent 2 pat= ches that have the following:
-=C2=A0update-javascript-package= s.diff=C2=A0
=C2=A0 =C2=A0 Add package:
=C2=A0 =C2=A0 =C2=A0is-docker to select a specific setting when running = the Chrome tests in
=C2=A0 =C2=A0 =C2=A0Docker

=C2=A0 =C2=A0 Upgrade the version of:
=C2=A0 =C2=A0 - babe= l-loader
=C2=A0 =C2=A0 - extract-text-webpack-plugin
= =C2=A0 =C2=A0 - jasmine-core
=C2=A0 =C2=A0 - jasmine-enzyme
=
=C2=A0 =C2=A0 - moment
-=C2=A0explain-plan-greenplu= m.diff
=C2=A0 Extract SQLEditor.execute and SQLEditor._poll i= nto their own files and add test around them
=C2=A0 Extract SQLEd= itor backend functions that start executing query to their own files and ad= d tests around it
=C2=A0 Move the Explain SQL from the front-end = and now pass the Explain plan parameters as a JSON object in the start quer= y call.
=C2=A0 Extract the compile_template_name into a function = that can be used by the different places that try to select the version of = the template and the server type


Th= anks
Joao



-= -
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



--
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



<= /div>--
Akshay Joshi
Sr. Software Architect
<= br>



--
Dave Page
VP, Chi= ef Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The= Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com<= /a>
Twitter: @pgsnake



--
Dave Page
VP, C= hief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake



--
Akshay Joshi
Sr. Software Architect
<= /font>

=

Phone: +91 2= 0-3058-9517
Mobile: +91 976-788-8246
<= /div>



--
=
Dave Page
VP, Ch= ief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
Th= e Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pg= snake




--
<= span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;= border-collapse:collapse">Akshay Joshi
Sr. Software Architect


Phone: <= a href=3D"tel:+91%2020%203058%209517" value=3D"+912030589517" target=3D"_bl= ank">+91 20-3058-9517
Mobile: +91 976-788-8246



--
=
Dave Page=
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake
--089e082813042f51400567e8224f--