Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghzXr-0000hD-H7 for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Jan 2019 16:20:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ghzXq-00028i-8U for pgadmin-hackers@arkaria.postgresql.org; Fri, 11 Jan 2019 16:20:30 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghzXp-00028b-VR for pgadmin-hackers@lists.postgresql.org; Fri, 11 Jan 2019 16:20:30 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ghzXn-0002CQ-6Q for pgadmin-hackers@postgresql.org; Fri, 11 Jan 2019 16:20:28 +0000 Received: by mail-wr1-x443.google.com with SMTP id l9so15756247wrt.13 for ; Fri, 11 Jan 2019 08:20:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cTfSxscnO8KKB+nZ8N9Bf7olI1V3yc46QNhsboGfDxY=; b=ep0IFC/kcWQJGdSlY+zx+ZSEBLvDlH8v+GNzXUjcQIhih07cBecgHQS9LFEddvcXcK RaUL404HihxaJL15AyUAF87FEsBDEWe+Pug5JLXfN1Z+69SfL4B7W9pa4SnduNQLJJ2l rKQCnfwSRk6PCz8qnpgm+4sZ1OSZ0CJTGqB6vDFYIsHmHA/YymusoTvkGUZ+hrqgYy2a e8vHzqSwEfFyIudQ7nK4DLpiDl4XaN8QnS76BdEy2xLi+Cp5uGrXsei8wJfkqglbUiWd mKtvLEGr30gQkB/qLpdj9vj8pH7oAfLOOy2Ku952F/h5p+Klh86cHagRlzFb77n3vfW1 AeiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cTfSxscnO8KKB+nZ8N9Bf7olI1V3yc46QNhsboGfDxY=; b=OpLtL8tBen+Ux4E4HnjRi+zYzlXaKVN4XJ+MqI2ohkYSQNauGpHZAtqAvfE/UWFUNj g7eaKQco50CblPxjq/RC//oA60GOTbwWOz4O+QsMFNm5kXXpT7VLEQaviCzScwOqHlX5 jTxTSIwuPDETjUIvFZ5uvgEuIFVX5Jwb5hN5IjtIFPKQ4EGPMUZ3lqKy2Y2ykURSvFpB 8KNW7f/oqXuEtaO1qc/POct43UK8Z2BIkZZwAll14QbeaL5zDfuwe7t1nUP84/fo9FL7 LJwOIaqz2LLslraqwA5U49/QYMeWIXNkhhi3DaeeBBS3g+fVfV47MKt1uWLvt3lpTm99 S8Rw== X-Gm-Message-State: AJcUukeBdbLSzwsrey7s5QrVLxlMxiBGr1I/sPeQT/kuFTAljZcJgVpH sxupP1PneokRm41WSkURHavu8OuRvTEJ8czrxv7wlg== X-Google-Smtp-Source: ALg8bN4G65u3FLw8UoyJFu5FItqscq/HW2+EqMCgnnQp+VVue0wmYzBpj0HkMkMmG7H4jlW6evxsqP1060+87bibBVg= X-Received: by 2002:adf:97d1:: with SMTP id t17mr14198999wrb.283.1547223625584; Fri, 11 Jan 2019 08:20:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Fri, 11 Jan 2019 21:50:14 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - RM 3505 Incorrect SQL generated for tables created using inherited columns To: Akshay Joshi Cc: pgadmin-hackers Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thanks, patch applied. On Thu, Jan 10, 2019 at 2:56 PM Akshay Joshi wrote: > > Hi Hackers, > > Attached is the patch to fix RM #3505 Incorrect SQL generated for tables created using inherited columns. > > Please review it. > > -- > Akshay Joshi > Sr. Software Architect > > > Phone: +91 20-3058-9517 > Mobile: +91 976-788-8246 -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company