Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f2u-0002kg-CR for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:49:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f3f2s-000553-Kz for pgadmin-hackers@arkaria.postgresql.org; Wed, 04 Apr 2018 09:49:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f3f2s-00054t-E6 for pgadmin-hackers@lists.postgresql.org; Wed, 04 Apr 2018 09:49:34 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f3f2o-0001Jx-7h for pgadmin-hackers@postgresql.org; Wed, 04 Apr 2018 09:49:33 +0000 Received: by mail-wm0-x22e.google.com with SMTP id p9so39076721wmc.3 for ; Wed, 04 Apr 2018 02:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DEe5DCZPCqpLYlvzaa5YY2M47aIj7sxTm3te9ejABgA=; b=JNUbNOvCOddVuvEbV0nG3lUtIQAhbc/bJOTYb3kQTB25CgYtpYvOOZvd03WyTey8sx gchlv1rpmB4Ld7gGd1KF+7VN8DyqXEobcsS5iEbTVxpdvJreCxL7YIjVyxc+ZSQdnp6n MfJEDpQa8G7ROd4tjRYSx+Yjk+UhDeroS0XIpAQlAbUu+5oBpL4yoT2VVWTLbXVQlut0 ULThhe9DlF3TQxGN2CUv11fFQOXhekHMeo3sQ7LakfYg1Ox69dxofWHGxgvoJtmmCOlo HjigOErVh+3S+rSmFDPsKZFQyDqXmdz6KyVlXUxO27W1W9YpUK1aPxsUONl8djhX+JGa +KLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DEe5DCZPCqpLYlvzaa5YY2M47aIj7sxTm3te9ejABgA=; b=m7arxszJ5YT9+uNZ/GLcqd5gIkSvsLCG/byzyMMh4tQFzoHQhei2cMEaSPLXId52NT GTf5chijD4C0KsndfqbrSWajxqZappg3YHz+vwKZDxgC7pbgNyPVC9rPkde347Uy81hI cO9t0/p/Mu4PfbTYNM33o+lh6B4kAQk3khDuR3a/8pBR+XQ4VButn9HaaHze0E5leu/N NREDA0Vi0cSWcXsuy5KzU0OgpqBmPK1j/OAdf3557mavRO7XVexjHubvHPlUuKCBgFmj /SVv+wvSSRZiaWk+VkupRRRFVpGVNLzVH+n9wfVujv/U6fXRQ7nKePX6duQPWd9/C7/W F/xw== X-Gm-Message-State: AElRT7EaEJz4F4OqqsmYkVqejxYeCbCOT/6glBLtFh9qNrU4qWQFcFUI luWZwquyqYilr9nFWU6tfNFWIBN9R7c4g+ny3mC9YHF5 X-Google-Smtp-Source: AIpwx48KtAE7IM2U/wZG/uW1c1enXzhsWatXYDSkRdc6EiZrCLHvSsLl9IrKlGGLBgP8vKc3yMXO/eTuluCwn4Mi4Ag= X-Received: by 10.28.91.65 with SMTP id p62mr7548731wmb.140.1522835369238; Wed, 04 Apr 2018 02:49:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.69.220 with HTTP; Wed, 4 Apr 2018 02:49:28 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 4 Apr 2018 10:49:28 +0100 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Murtuza Zabuawala Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a1144161a3c379f056902bdb8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a1144161a3c379f056902bdb8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi Joao, > > Yes it bundles latest version but I doubt that is not using it, If we > upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. > I have tried that and I started getting jQuery related errors when trying > to run query tool or when running jasmine tests. > Can you spend some time trying to figure it out please? We need to get on to 3.x as older versions are no longer receiving updates which could pose a security risk. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Murtuza, >> >> The patches look good and they pass all tests in CI. >> One think that we realized was the SlickGrid as a npm package now: >> https://www.npmjs.com/package/slickgrid >> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully >> supported or not...... >> >> Thanks >> Victoria & Joao >> >> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> =E2=80=8BHi Dave, >>> >>> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >>> Please find updated patch. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Please hold on my previous patch. >>>> >>>> We can't use latest jQuery version as SlickGrid has dependancy on olde= r >>>> version. >>>> I'll send updated patch again. >>>> >>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hi Dave, >>>>> >>>>> Please find updated patches, there are two patches attached one is fo= r >>>>> the story and another is for changes required as per new modules. >>>>> >>>>> >>>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA patch to update the modules to latest version. >>>>>>> >>>>>>> >>>>>> - Why isn't jQuery updated to 3.3.1? >>>>>> >>>>> =E2=80=8BDone=E2=80=8B >>>>> >>>>> >>>>>> =E2=80=8B >>>>>> >>>>>> >>>>> >>>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2 >>>>>> and pycrypto etc? >>>>>> >>>>> =E2=80=8BDone=E2=80=8B >>>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>>> We are not able to update some of the modules to latest version due >>>>>>> to dependancy on other modules, For example >>>>>>> - Python: Flask-Security has dependancy on flask-babelex which >>>>>>> causes conflict with flask_babel >>>>>>> >>>>>> >>>>>> Hmm, flask-babelex might be a better option anyway; in particular, i= t >>>>>> avoids loading catalogs with every request which seems desirable giv= en the >>>>>> size of ours. On the other hand, it hasn't been updated so recently. >>>>>> >>>>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.= =E2=80=8B >>>>> >>>>> >>>>>> >>>>>> >>>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>>> >>>>>> >>>>>> OK. >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a1144161a3c379f056902bdb8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <= ;mu= rtuza.zabuawala@enterprisedb.com> wrote:
Hi Joao,

Yes it bundles latest version but I doubt that is not using it, I= f we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid.
I have tried t= hat and I started getting jQuery related errors when trying to run query to= ol or when running jasmine tests.

Can you spend some time trying to figure it out please? We need to get o= n to 3.x as older versions are no longer receiving updates which could pose= a security risk.
=C2=A0

--
Regards,
Murtuza Zabuaw= ala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The En= terprise PostgreSQL Company
=

On Wed, Apr 4,= 2018 at 1:39 AM, Joao De Almeida Pereira <jdealmeidapereira@pi= votal.io> wrote:
Hi Murtuza,

The patches look good and they pass= all tests in CI.
One think that we realized was the SlickGrid as= a npm package now:=C2=A0https://www.npmjs.com/package/slickgrid=C2=A0<= /div>
Also Slickgrid comes packaged with jquery 3.1 not sure if it is f= ully supported or not......

Thanks
Victo= ria & Joao

On Tue,= Apr 3, 2018 at 11:50 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=E2= =80=8BHi Dave,

Reverted back jQuery version to 1.x because of SlickGrid depend= ancy.
Please find updated patch.

= --
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.ent= erprisedb.com
The Enterprise PostgreSQL Company


On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Please hold on my previou= s patch.=C2=A0

= We can't use latest jQuery version as SlickGrid has dependancy on older= version.
= I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

Please find updated patches, there are tw= o patches attached one is for the story and another is for changes required= as per new modules.

=

On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany







--
Dave Page
Blog: = http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company
--001a1144161a3c379f056902bdb8--