Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bk6a1-0008Ic-H8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Sep 2016 09:34:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bk6a1-0000xm-3R for pgadmin-hackers@arkaria.postgresql.org; Wed, 14 Sep 2016 09:34:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bk6Zn-0000cA-MA for pgadmin-hackers@postgresql.org; Wed, 14 Sep 2016 09:33:55 +0000 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bk6Zk-0000fa-Jc for pgadmin-hackers@postgresql.org; Wed, 14 Sep 2016 09:33:55 +0000 Received: by mail-it0-x229.google.com with SMTP id r192so35156573ita.0 for ; Wed, 14 Sep 2016 02:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2QSe6uk1TH25LdR4vn1GWAZpge1gF9ctgiwt0BK4Sw4=; b=gUB4+n2XwFma1qFxoItQFaVtxopWOfK6XZ3ZWyZUjeEV7j2m2HXfg1sJW4n3sYxsC5 edyB2bFEsxIVJZiiGtd6uVE+W8g/XL6maJQ5LYtVragLhDLnaSWQeVlJRD5Eff5Mluj4 ZF4l3tuMOKc7AqzkcnuygNZW7df9StErMIhoih9h1i6rAoC3UonXdyAtHeMyoc7kktJY 1oZUi3igIn2G1xYeKtiVlOGWNK1Vc4Rw0D/Lsch6hU2IOYDaXasFcjs+8c3ObjZHvvSk Ab54GRFPIXrBFB5ODA+cxKv/Q4fkwpSgqPTqsDR67HpbOimb+kNoRdUtaqlwxTcSbo2Q YClQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2QSe6uk1TH25LdR4vn1GWAZpge1gF9ctgiwt0BK4Sw4=; b=mDRniWkJrJxjz8bY9qujRtE9FTgGN+R7/lrVDJDeL4MfS7DcQIVCTvI4ABogC9S8yz vqoeTFOt/gWrJNeRHmi11yxj8NvnjOC48JJFxhs6dvREunGeFgOZeAWqHj4vBA8354q1 9zU94GXKAM9G0pgkM8LFCOCt3S9NXcTd/MAh5fLKt2lucjHUDBCSYEs/DSXaPjm/37TH niRJBpIVMmfo73I1hon+/fTVGQ4iZ+QZJbKpBwJdYO9QBhJREd87bxft7xdw7rFvcIKU MbDcwG4s0ATj5M8ObIYIc9Rp4fkpcEAKM9pEUf02MHTid/TeMm6OeJu962DjGG7IOV67 DysQ== X-Gm-Message-State: AE9vXwO6jCkk4lqXG8l+qXMKflFU0pb0ta2LnUNqmg7eIS3BajrshPBOW1OUyitdbFh6/iDfsFfx4omqHrapdw== X-Received: by 10.107.201.140 with SMTP id z134mr4293829iof.156.1473845630783; Wed, 14 Sep 2016 02:33:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.1.203 with HTTP; Wed, 14 Sep 2016 02:33:50 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Wed, 14 Sep 2016 10:33:50 +0100 Message-ID: Subject: Re: PATCH: To fix the issue on Table collection node refresh (pgAdmin4) To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied. On Tue, Sep 13, 2016 at 8:58 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user tries to refresh on Table collection > node it was throwing error. > RM#1686 > > Issue: Nodes method was not implemented properly to handle such request in > Table node. > > Also attaching a separate patch for typo in browser.js file due to which > this error was displaying on console and not on GUI. > > @Ashesh, Would you please review this minor patch (File: > misc_typo_fix.patch), I hope it does not affect anything else :) > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers