Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnj0A-00050X-8P for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 Jul 2019 12:25:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hnj09-0005tW-4N for pgadmin-hackers@arkaria.postgresql.org; Wed, 17 Jul 2019 12:25:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnj08-0005tP-I2 for pgadmin-hackers@lists.postgresql.org; Wed, 17 Jul 2019 12:25:40 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hnj06-0000k0-01 for pgadmin-hackers@postgresql.org; Wed, 17 Jul 2019 12:25:40 +0000 Received: by mail-wr1-x442.google.com with SMTP id g17so24613438wrr.5 for ; Wed, 17 Jul 2019 05:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=amZW9nEn2kcYm5OV3oNWiFJeCDUvvi2rjmxEspFAbcU=; b=BatYKYyMP/NVbz/ibgfCj8Apy4C0qv2T5e74jef8yhbCLsVu0ERxRPM3bFiGZZKUHn QAHX7sJttlqZQEOb3K7QjdvFRWC4MxF04jwxKar7AVdeBFcu87QGC7U4FX7vb1aO5Rjh 8C13i4GgHaTt1W24RBiQ/I9cV51kp0TaYnIqIfv65UOeGoC3jZTeAi+GEjEJLuSmymJV vUIv0wvJcFUs8EoXqd1GSi0jURFMNBU2U1sUKmYW6/33mk9UBBLgqLOE3sEBmbtjN7j9 gMzNC6c3EedpwT1sGnxk2s0u41AePSgnjiuVpmP0l088N0rfmAHsXLYmOSfC3mIeqgiG k/JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=amZW9nEn2kcYm5OV3oNWiFJeCDUvvi2rjmxEspFAbcU=; b=FS4zpY8tFDP+VCO6e13GoW5acfw+AosfEuwLsHzPUywAQhx/EPK8/zEZ7XS2i7fC8K IsDnd82+/Ty8GqAohLb70JQT2oQH9Boj8Q90BXt+tRyTeJhzWBNng6bFc1Ob2/Qgng/1 TREfWx8pSN9PokDP46JI90dZ5bx0WlNU/ewIXlJ4jPZT+IeX7RzUub63tShFNibuhfqy y/WXiOzAnAzg2Vzl2u/JTguby2EXoTQuJA2fgOFNwuCgb3GwfP1wNNYXrlWsnKK5H+iW GDr/UNhh4sD0z7yjTP+DMOMGWtFPnO3USJZcp+IHhe1NWhGDpkKMRxHF1H6o2CtSNPmK XUkg== X-Gm-Message-State: APjAAAUTRc3jrEAiywsGpQBRBvbWSu8gGMBwC12twStW09i+1F2w2Mki 7YLMRIsZapkzf14YKxv5Z+n2M8FSqtyicWYtv73h7g== X-Google-Smtp-Source: APXvYqyYRrfSmXtpxmjprPPPRYuWZYpVoI2ersqEJ8xahYauRe9Sr2OxOTDGWUoK6OceUpoj9/JtCb/oGCEkL4dL7Dk= X-Received: by 2002:a5d:6ccd:: with SMTP id c13mr38625219wrc.4.1563366337144; Wed, 17 Jul 2019 05:25:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 17 Jul 2019 13:25:23 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch] - RE-SQL and modified SQL tests for Check Constraint node To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000002dfcb4058ddf97af" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000002dfcb4058ddf97af Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Tue, Jul 16, 2019 at 12:01 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi Dave, > > On Tue, Jul 16, 2019 at 2:05 PM Dave Page wrote: > >> Hi >> >> On Tue, Jul 16, 2019 at 7:22 AM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch for the RE-SQL and modified SQL tests for >>> check constraint node. >>> >>> For the table child nodes, *create table endpoint *with proper data is >>> required in the JSON file. >>> I have introduced one new parameter named *store_table_id* in the table >>> create endpoint, so the created table ID will be stored for the rest of the >>> scenarios >>> >> >> This breaks the type tests :-( >> >> Fixed. > Please find the attached updated patch. > > Thanks, > Khushboo > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --0000000000002dfcb4058ddf97af Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Tue, Jul 16, 2019 at 12:01 PM Khu= shboo Vashi <khushboo= .vashi@enterprisedb.com> wrote:
Hi Dave,

=
On Tue, Ju= l 16, 2019 at 2:05 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
=
On Tue= , Jul 16, 2019 at 7:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com&= gt; wrote:
Hi,

Please find the attached patch for = the RE-SQL and modified SQL tests for check constraint node.

=
For the table child nodes, create table endpoint with pro= per data is required in the JSON file.
I have introduced one new = parameter named store_table_id in the table create endpoint, so the = created table ID will be stored for the rest of the scenarios

This breaks the type tests :-(=C2=A0

Fixed.
Please fi= nd the attached updated patch.=C2=A0

Thanks,
=
Khushboo
--
Dave Page
Blog: http://pgsnake.blogs= pot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
= The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--0000000000002dfcb4058ddf97af--