Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP5dB-00084r-M9 for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 10:18:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bP5dB-0000Tz-69 for pgadmin-hackers@arkaria.postgresql.org; Mon, 18 Jul 2016 10:18:33 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bP5dA-0000Tj-78 for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 10:18:32 +0000 Received: from mail-it0-x229.google.com ([2607:f8b0:4001:c0b::229]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bP5d6-00017F-TE for pgadmin-hackers@postgresql.org; Mon, 18 Jul 2016 10:18:31 +0000 Received: by mail-it0-x229.google.com with SMTP id j124so27474173ith.1 for ; Mon, 18 Jul 2016 03:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AtsieE160q6aTL9v8yYTIdHYlnNbkkB8aAI3OKG47NM=; b=W4pH/yj4ueM3t0B5VzWDnmhvcXIpBR6S3/aotMapzqQMbkbGGmG2Cr/yMFhnR5s6GZ +djjuOhupm7IwuuMg5/7PngEEzhb21PrpZ5cp14XaMkq2VbHlpIG8FD2b0sybxrXtC18 86sWUSxQZQDXY9IldHzrzPmIBfggCctvNebKAu38QDh873gUOFbhWKtoxFsqAb27JDgG zL4p9/ms1KSpEgKhw/2Uq7WUK1SsOPGcpPLvztn+5C22CkgZs0Er/YIOI2vp+874kT3s v6BkpuM1s77SC6cv363eGmF9LPLwISiN/lvdiy0AyAxxUf8bdi//v9O5JlkV6DXSZvtS FHdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AtsieE160q6aTL9v8yYTIdHYlnNbkkB8aAI3OKG47NM=; b=cKopndyOCqoQ3W3e8CrbZ/OZkRM8Ryo7Hza+hRrUJU6qqitFqQQEtEP8xlDJK9RcsM 6n9i006nORpXod5bQ21QvRVvTx0fQOyvclsHW62XeoRSNq6NISViU1e+1peJmDB+Cw99 e2EBkvO7kWoiKn8iiNFAf4bVzGfkdJ9ieknhUFv03gVIZnfFdLyZx8DhB1JDgjcieeA7 MNRXEnLwLrzRcUl3ngzEh+DUPzBNs9omJWffu1yIPNwxQEg4CfSNMoSeSCf1/9tlAGCU n30v88KT9dfKz8mRtzA/T/fJ62uoQ8Xz9l07yRj0QTJO9cdzgYTQsjJuCWo09qjwXI8Z qnKQ== X-Gm-Message-State: ALyK8tJGnUFxhGDYrRUR1K40iSB0AHSxYn3vPa50DScPdxNeNVdhlLLaC+P/KNCPshUGaRanQPs0Rq1volqJRw== X-Received: by 10.36.117.79 with SMTP id y76mr39894395itc.35.1468837107893; Mon, 18 Jul 2016 03:18:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.208.97 with HTTP; Mon, 18 Jul 2016 03:18:26 -0700 (PDT) In-Reply-To: References: <70470862-26C1-4281-838E-F2C755E5C645@enterprisedb.com> <671D8CC8-C1D8-4CC1-BC32-431C496C4C5C@enterprisedb.com> From: Dave Page Date: Mon, 18 Jul 2016 11:18:26 +0100 Message-ID: Subject: Re: PATCH: Fix the issue for saving query output as CSV To: Neel Patel Cc: Harshal Dhumal , Akshay Joshi , Murtuza Zabuawala , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a114a90ce0c9f730537e64ab5 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a90ce0c9f730537e64ab5 Content-Type: text/plain; charset=UTF-8 Thanks! On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel wrote: > Hi Dave, > > Yes, it will break in runtime. If we need to support downloading at server > side then we need to change the runtime code. > I will send the patch for runtime to support server side download CSV file. > > Thanks, > Neel Patel > > On Fri, Jul 15, 2016 at 3:05 PM, Dave Page wrote: > >> Hi >> >> This seems to break downloads in the runtime. It works in Safari and >> Chrome, but in the runtime the suggested filename is >> "6980287?query=SELECT+*+FROM+pem.probe_column%0AORDER+BY+id%0AASC+&filename=probe_column.csv", >> and after changing that and hitting OK, the "Downloading file" dialogue is >> shown indefinitely. >> >> On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA rebased patch for RM1405 >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Wed, Jul 13, 2016 at 5:15 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Yes sure >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Wed, Jul 13, 2016 at 5:10 PM, Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> Can you rebase this please? >>>>> >>>>> Thanks. >>>>> >>>>> On Mon, Jul 11, 2016 at 9:16 AM, Harshal Dhumal < >>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch for RM1405. Also to allow download in runtime we will still >>>>>> need patch >>>>>> >>>>>> sent by Neel. >>>>>> >>>>>> Changes: To download query result to CSV directly from server and not >>>>>> to use download attr. of anchor tag () as it's not support by all of >>>>>> major browsers (e.g. Safari). >>>>>> Also it's not feasible to load data in html to download if result set >>>>>> of query is very huge (in GBs). >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Software Engineer* >>>>>> >>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> On Wed, Jun 29, 2016 at 4:53 PM, Akshay Joshi < >>>>>> akshay.joshi@enterprisedb.com> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala >>>>>> zabuawala@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Yes, It will not work in runtime as well but I think Neel is >>>>>>>> working for fix in run time for this issue, We might able to fix it in run >>>>>>>> time but issue persists in Safari unless they add support in browser itself. >>>>>>>> >>>>>>>> https://webkit.org/status/#feature-download-attribute >>>>>>>> >>>>>>>> >>>>>>>> > On 29-Jun-2016, at 3:40 pm, Dave Page wrote: >>>>>>>> > >>>>>>>> > On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala >>>>>>>> > wrote: >>>>>>>> >> Yes Dave, I agree that downloading files has been supported in >>>>>>>> browsers since long . >>>>>>>> >> >>>>>>>> >> But in general we send request & then receives files from web >>>>>>>> server but in our case we are fetching our data from Backbone models & then >>>>>>>> converting it to CSV format for downloading as a file at client side in >>>>>>>> browser itself. >>>>>>>> > >>>>>>>> > If Safari doesn't support client-side saving of files, then I >>>>>>>> have to >>>>>>>> > wonder if our runtime will either - both are webkit based. >>>>>>>> > >>>>>>>> > So I guess the next question to ask is; why don't we just >>>>>>>> generate the >>>>>>>> > CSV on the server side? >>>>>>>> > >>>>>>>> >>>>>>>> @Akshay, >>>>>>>> Can you please suggest on above? >>>>>>>> >>>>>>> >>>>>>> As we already have complete data in backgrid's full collection, >>>>>>> so I have used it instead of fetching it again. >>>>>>> >>>>>>>> >>>>>>>> > -- >>>>>>>> > Dave Page >>>>>>>> > Blog: http://pgsnake.blogspot.com >>>>>>>> > Twitter: @pgsnake >>>>>>>> > >>>>>>>> > EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> > The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sent via pgadmin-hackers mailing list ( >>>>>>>> pgadmin-hackers@postgresql.org) >>>>>>>> To make changes to your subscription: >>>>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Akshay Joshi* >>>>>>> *Principal Software Engineer * >>>>>>> >>>>>>> >>>>>>> >>>>>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 >>>>>>> 976-788-8246* >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --001a114a90ce0c9f730537e64ab5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks!

On Mon, Jul 18, 2016 at 10:42 AM, Neel Patel <neel.= patel@enterprisedb.com> wrote:
Hi Dave,

Yes, it will break in runt= ime. If we need to support downloading at server side then we need to chang= e the runtime code.
I will send the patch for runtime to support = server side download CSV file.

Thanks,
N= eel Patel

On Fri, Jul 15, 2016 at 3:05 PM= , Dave Page <dpage@pgadmin.org> wrote:
Hi

This seems to break do= wnloads in the runtime. It works in Safari and Chrome, but in the runtime t= he suggested filename is "6980287?query=3DSELECT+*+FROM+pem.probe_colu= mn%0AORDER+BY+id%0AASC+&filename=3Dprobe_column.csv", and after ch= anging that and hitting OK, the "Downloading file" dialogue is sh= own indefinitely.

On Wed, Jul 13, 2016 at 1:16 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA rebased= patch for RM1405

--=C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:1= 5 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
Yes sure=

--=C2=A0
Harshal Dhumal
Software Eng= ineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 13, 2016 at 5:1= 0 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

Can you rebase this= please?

Thanks.

On Mon, Jul 11, 2016 at 9:1= 6 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= ; wrote:
Hi,

PFA patch for RM1405. Also to allow download in runtime = we will still need patch sent by Neel.

Changes: To download = query result to CSV directly from server and not to use download attr. of a= nchor tag (<a>) as it's not support by all of major browsers (e.g= . Safari).
Also it's not feasible to load data in html to download i= f result set of query is very huge (in GBs).<= br>




--= =C2=A0
Harshal Dhumal
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Wed, Jun 29, 2016 at 4:53 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:

=
On Wed, Jun 29, 2016 at 3:52 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Yes, It will not work in runtime as w= ell but I think Neel is working for fix in run time for this issue, We migh= t able to fix it in run time but issue persists in Safari unless they add s= upport in browser itself.

https://webkit.org/status/#feature-download-att= ribute


> On 29-Jun-2016, at 3:40 pm, Dave Page <dpage@pgadmin.org> wrote:
>
> On Tue, Jun 28, 2016 at 10:33 AM, Murtuza Zabuawala
> <murtuza.zabuawala@enterprisedb.com> wrote:
>> Yes Dave, I agree that downloading files has been supported in bro= wsers since long .
>>
>> But in general we send request & then receives files from web = server but in our case we are fetching our data from Backbone models & = then converting it to CSV format for downloading as a file at client side i= n browser itself.
>
> If Safari doesn't support client-side saving of files, then I have= to
> wonder if our runtime will either - both are webkit based.
>
> So I guess the next question to ask is; why don't we just generate= the
> CSV on the server side?
>

@Akshay,
Can you please suggest on above?

=C2=A0 =C2=A0As we already have complete data in backgrid's full collection, so I have used it instead of fetching it again. =C2=A0 = =C2=A0

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=


--
Akshay Joshi
Principal Software Enginee= r=C2=A0

=

+91 20-3058-9517
Mobile: +91 976-788-8246




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company




--
=
Dave Page=
Blog: http://= pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprised= b.com
The Enterprise PostgreSQL Company
--001a114a90ce0c9f730537e64ab5--