MIME-Version: 1.0
References: 
 <CANxoLDdQr19YWNRgYU+ARs4BgnJGwNBu_51+g0AXWbCC6ZpNNA@mail.gmail.com>
In-Reply-To: 
 <CANxoLDdQr19YWNRgYU+ARs4BgnJGwNBu_51+g0AXWbCC6ZpNNA@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Tue, 18 Dec 2018 09:19:08 +0000
Message-ID: 
 <CA+OCxoxno88VLcWxc5ybfDxg=yZNpUFdNCXmKgF4hk_sN50HUQ@mail.gmail.com>
Subject: Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify
 NULL values in CSV export
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000078c41b057d4864db"
Precedence: bulk

--00000000000078c41b057d4864db
Content-Type: text/plain; charset="UTF-8"

Hi

On Tue, Dec 18, 2018 at 3:45 AM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Hackers,
>
> Attached is the patch to fix RM #3780 pgAdmin4 lacks ability to specify
> NULL values in CSV export.
>
> Please review it.
>

A few points;

- You've included code from backports.csv, but per the licence you need to
include a description of the changes made.

- Shouldn't backports.csv be removed from requirements.txt, or is it used
elsewhere?

- If the previous point is true, then I'm fairly sure there is code in one
or more of the many package build scripts that adds an __init__.py file to
backports.csv in the venv that's created.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--00000000000078c41b057d4864db
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi<br><br><div class=3D"gmail_quote"><div dir=3D"ltr">On T=
ue, Dec 18, 2018 at 3:45 AM Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi=
@enterprisedb.com">akshay.joshi@enterprisedb.com</a>&gt; wrote:<br></div><b=
lockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-le=
ft:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=
=3D"ltr">Hi Hackers,<div><br></div><div>Attached is the patch to fix RM #37=
80=C2=A0pgAdmin4 lacks ability to specify NULL values in <span id=3D"gmail-=
m_-3640237263547570362:1ww.4">CSV</span> export.</div><div><br></div><div>P=
lease review it.</div></div></div></blockquote><div><br></div><div>A few po=
ints;</div><div><br></div><div>- You&#39;ve included code from backports.cs=
v, but per the licence you need to include a description of the changes mad=
e.</div><div><br></div><div>- Shouldn&#39;t backports.csv be removed from r=
equirements.txt, or is it used elsewhere?</div><div><br></div><div>- If the=
 previous point is true, then I&#39;m fairly sure there is code in one or m=
ore of the many package build scripts that adds an __init__.py file to back=
ports.csv in the venv that&#39;s created.</div><div>=C2=A0</div></div>-- <b=
r><div dir=3D"ltr" class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"=
http://pgsnake.blogspot.com" target=3D"_blank">http://pgsnake.blogspot.com<=
/a><br>Twitter: @pgsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.ente=
rprisedb.com" target=3D"_blank">http://www.enterprisedb.com</a><br>The Ente=
rprise PostgreSQL Company<br></div></div>

--00000000000078c41b057d4864db--