MIME-Version: 1.0
References: 
 <CAK6syAryyMuRZVBe=dz47kWk0fr2Yy2-j53Tj8LGJCx3gpbQhA@mail.gmail.com>
 <CA+OCxoxHi6PU7dTbC1qvswniaCsrGmhkfaRYO_jimX14xg3zhQ@mail.gmail.com>
 <CAK6syAqgLAVLsWCoevtnWX+V_cgKOQra=oohXwnrzYj7fSp9ug@mail.gmail.com>
In-Reply-To: 
 <CAK6syAqgLAVLsWCoevtnWX+V_cgKOQra=oohXwnrzYj7fSp9ug@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Thu, 11 Jul 2019 10:14:27 +0100
Message-ID: 
 <CA+OCxoxnzFjL0DrQNs=ps1QtxtuLVEgnB74jfPQX-i5aH3i7Lw@mail.gmail.com>
Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control
To: Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000042657e058d6439c5"
Precedence: bulk

--00000000000042657e058d6439c5
Content-Type: text/plain; charset="UTF-8"

Thanks - patch applied with some doc tweaks.

No need for a new ticket!

On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay <
ganesh.jaybhay@enterprisedb.com> wrote:

> Hi Dave,
>
> Ticket number 3919 refers to keyboard accessibility issues for sub-node
> control and back grid but this patch covers only sub-node control. Should I
> create new one?
> I have added the screenshot having newly added shortcut and updated
> keyboard shortcut rst file. Also moved the code changes from backgrid.js to
> backgrid.pgadmin.js.
>
> Please find the attached updated patch.
>
> Regards,
> Ganesh Jaybhay
>
> On Tue, Jul 9, 2019 at 9:28 PM Dave Page <dpage@pgadmin.org> wrote:
>
>> Hi,
>>
>> What's the ticket number for this? That's a fair amount of code for a
>> one-line description. There are also no doc changes describing how to
>> navigate the sub-node control that I can see.
>>
>> Also; instead of changing the repo used for backgrid, can we not
>> un-vendorise it?
>>
>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <
>> ganesh.jaybhay@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch for keyboard accessibility of sub-node control. It
>>> also covers sub-node dialog forward/backward tab navigation with shortcuts.
>>>
>>> Kindly review.
>>>
>>> Regards,
>>> Ganesh Jaybhay
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--00000000000042657e058d6439c5
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks - patch applied with some doc tweaks.<div><br></div=
><div>No need for a new ticket!</div></div><br><div class=3D"gmail_quote"><=
div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jul 11, 2019 at 7:00 AM Ganesh=
 Jaybhay &lt;<a href=3D"mailto:ganesh.jaybhay@enterprisedb.com">ganesh.jayb=
hay@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi Dave,<div><br></di=
v><div>Ticket number 3919 refers to keyboard accessibility issues for sub-n=
ode control and back grid but this patch covers only sub-node control. Shou=
ld I create new one?</div><div>I have added the screenshot having newly add=
ed shortcut and updated keyboard shortcut rst file. Also moved the code cha=
nges from backgrid.js to backgrid.pgadmin.js.</div><div><br></div><div>Plea=
se find the attached updated patch.</div><div><br></div><div>Regards,</div>=
<div>Ganesh Jaybhay</div></div><br><div class=3D"gmail_quote"><div dir=3D"l=
tr" class=3D"gmail_attr">On Tue, Jul 9, 2019 at 9:28 PM Dave Page &lt;<a hr=
ef=3D"mailto:dpage@pgadmin.org" target=3D"_blank">dpage@pgadmin.org</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr">Hi,<div><br></div><div>What&#39;s the ticket number for this? That=
&#39;s a fair amount of code for a one-line description. There are also no =
doc changes describing how to navigate the sub-node control that I can see.=
</div><div><br></div><div>Also; instead of changing the repo used for backg=
rid, can we not un-vendorise it?</div></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Mon, Jul 8, 2019 at 4:49 PM Ganesh=
 Jaybhay &lt;<a href=3D"mailto:ganesh.jaybhay@enterprisedb.com" target=3D"_=
blank">ganesh.jaybhay@enterprisedb.com</a>&gt; wrote:<br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi =
Hackers,<div><br></div><div>Attached is the patch for keyboard accessibilit=
y of sub-node control. It also covers sub-node dialog forward/backward tab =
navigation with shortcuts.</div><div><br></div><div>Kindly review.</div><di=
v><br></div><div>Regards,</div><div>Ganesh Jaybhay</div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail-m_-2496002411021818271gmail-m_1569451339284942244gmail_sign=
ature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blogspot.com" target=3D=
"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @pgsnake<br><br>Enterp=
riseDB UK: <a href=3D"http://www.enterprisedb.com" target=3D"_blank">http:/=
/www.enterprisedb.com</a><br>The Enterprise PostgreSQL Company<br></div>
</blockquote></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
 class=3D"gmail_signature">Dave Page<br>Blog: <a href=3D"http://pgsnake.blo=
gspot.com" target=3D"_blank">http://pgsnake.blogspot.com</a><br>Twitter: @p=
gsnake<br><br>EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" targ=
et=3D"_blank">http://www.enterprisedb.com</a><br>The Enterprise PostgreSQL =
Company<br></div>

--00000000000042657e058d6439c5--