Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haHGr-000607-IS for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 10:11:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1haHGq-0001ZY-DS for pgadmin-hackers@arkaria.postgresql.org; Mon, 10 Jun 2019 10:11:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haHGp-0001ZP-RM for pgadmin-hackers@lists.postgresql.org; Mon, 10 Jun 2019 10:11:20 +0000 Received: from mail-it1-x143.google.com ([2607:f8b0:4864:20::143]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1haHGm-0005ef-RD for pgadmin-hackers@postgresql.org; Mon, 10 Jun 2019 10:11:19 +0000 Received: by mail-it1-x143.google.com with SMTP id x22so12254040itl.2 for ; Mon, 10 Jun 2019 03:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T6JIqtJdToJLJmoaZf5nUvXAHxsZXBXs4WAnDinxX4Q=; b=hCTD8YQllONipF8rNKO1uKWhdB2s44xIyGX12cGWuSbIbHJrvGq9u9agiUc9DRT808 fD5G6M5lY65G7xSR/SE0AcBwHq2DCimxpsPHoYLcGUAhOfxaRCPZTT0g4iCIZTA20mCV q6huOhw+Aho3TP/jYZ5WCfaQQGpLfuD0DqJgE/bl8zyf5U5m1Db3lxXjUFmP5v0xRuZ/ 1IXNKvoIGRbDCim0GUs5fHlrAB1sdMFcsFnPhKm0DbpysD7Hg/BRKd2GUMm2cdIwiIU3 YlPPDtpY+Y8T6Qjjmc5uqhm20sL9GDVFUSh6SOZm4IiaREUUv3hEW+s2QgCFEkBLIj4O ncyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T6JIqtJdToJLJmoaZf5nUvXAHxsZXBXs4WAnDinxX4Q=; b=RIuZLnuQx2XJ6kjWcQy6eYlX1RBJKAeelsqYf9I50k/enX1oowgQTLlhMUqfsJPZWn k2R8DxEuH2+IoUtMH6C4zHoaKGx6q+yOActHux/p8k2h+JQnqyaAFRvHMOtaGJt8NAhL uo3dGMaGX4Sw4aG3T+J/hM65Ayul5AQKHcqVsY/Ke/veA5gspzrsh8kAzvzPp+79AA11 QBqwqqg9cOAZa1Qe7XTZOZsmkugHWsdGmE9JLbWqEg2+hfID04HIMn68WayCGnlS7yap N5LgSaDUTdn0CZQa4Fr0N7pMuhqgcwhmOOkFFZELFeDJM89BcHnhQKYCvVPbvUrtC/wa lmiA== X-Gm-Message-State: APjAAAW17Eyn7mQPg5J8ZuDJMXQlg8wj2DWAGYSovlum26wIpkCaHelt 6nPEyXra0EP4lIErrNtVV6OyX2pTKMkXT6E0cUYL6Q== X-Google-Smtp-Source: APXvYqyWkWEAC5IXx9Bn6CjRllFj9Gwr0ctth/gJ4Awwyt4U5bHJw9YcoqqD6DFlsqsSUX6OKldK1SKfkNUQcKITrqQ= X-Received: by 2002:a05:660c:c1:: with SMTP id q1mr12737370itk.103.1560161474963; Mon, 10 Jun 2019 03:11:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Mon, 10 Jun 2019 11:11:02 +0100 Message-ID: Subject: Re: [pgAdmin][RM4195] Tab navigation is broken in Query tool (Accessibility) To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000820076058af566e8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000820076058af566e8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, applied! On Wed, Jun 5, 2019 at 1:18 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated, rebased patch. I was using the wrong key code fo= r > "[" and "]" while registering, but strangely it was working for me. I hav= e > corrected that. > Plus, I found a bug in Preferences. If a preference name is same in two > different modules, then it was registered only once in SQLiteDB. (eg- > move_previous in Debugger and SQLEditor). Fixed that. > > Kindly review. > > > On Thu, May 30, 2019 at 7:36 PM Dave Page wrote: > >> Hi >> >> On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> On Thu, May 30, 2019 at 1:38 AM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Tue, May 28, 2019 at 3:41 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Thu, May 23, 2019 at 1:31 PM Dave Page wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> On further testing, this doesn't seem to be working as expected. >>>>>> Alt+Shift+] or [ in the query tool are typing =E2=80=99 and =E2=80= =9D and not changing the >>>>>> tab. If I switch to a non-input tab (e.g. History), they still don't= work. >>>>>> >>>>> I am not able to simulate the quotes problem, but I have made a few >>>>> corrections to fix the switching. >>>>> Attached is the updated patch, kindly review. >>>>> >>>> >>>> Alt+Shift+[ (or ]) don[t work at all for me now :-( >>>> >>> Did you restart the server after applying the patch ? What shortcut >>> does preferences show ? >>> >> >> Yes, did that, rebuilt the bundle and hard-reloaded the browser, all >> multiple times. >> >> The shortcut preferences show the expected keys. >> >> >>> >>>> >>>>> >>>>>> Alt+Shift+Tab changes the panel successfully though, and does cause >>>>>> the flash as expected. >>>>>> >>>>>> I'm using Chrome 74.0.3729.131 on Mojave. >>>>>> >>>>>> On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Attached is the updated patch with doc changes. >>>>>>> >>>>>>> On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal < >>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> On Tue, May 21, 2019 at 5:32 PM Dave Page >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Tue, May 21, 2019 at 10:01 AM Aditya Toshniwal < >>>>>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Hackers, >>>>>>>>>> >>>>>>>>>> Attached is the patch to fix the accessibility issue in query >>>>>>>>>> tool. >>>>>>>>>> >>>>>>>>>> The query tool can be completely restructured unlike previously >>>>>>>>>> where query tool used to stick at top and other tabs in the bott= om. >>>>>>>>>> - I have added a new shortcut to switch between frames if in >>>>>>>>>> query tool the tab positions are changed. On switching the frame= s, the >>>>>>>>>> frame will blink to show it is focussed. >>>>>>>>>> - In the frame, you can switch tab same as previous. The tabs in >>>>>>>>>> SQL editor are cyclic now, which means if you execute shortcut t= o go right >>>>>>>>>> on the last tab then it will cycle to first tab. >>>>>>>>>> - I have also changed the default shortcut to switch between tab= s >>>>>>>>>> from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] similar to what = we have in >>>>>>>>>> browser tabs. >>>>>>>>>> - Similar changes done for debugger also. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Shouldn't there be documentation changes to go with this? >>>>>>>>> >>>>>>>> Yes, definitely :P >>>>>>>> Will send the updated patch. >>>>>>>> >>>>>>>>> >>>>>>>>> Otherwise, it seems to work :-) >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Dave Page >>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>> Twitter: @pgsnake >>>>>>>>> >>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Thanks and Regards, >>>>>>>> Aditya Toshniwal >>>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000820076058af566e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied!

On Wed, Jun 5, 2019 at 1:18 PM Aditya Tosh= niwal <aditya.toshn= iwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated, = rebased patch. I was using the wrong key code for "[" and "]= " while registering, but strangely it was working for me. I have corre= cted that.
Plus, I found a bug in Preferences. If a preference name is same in tw= o different modules, then it was registered only once in SQLiteDB. (eg- mov= e_previous in Debugger and SQLEditor). Fixed that.

Kindly review.<= /font>


On Thu, May 30, 2019 at 7:36 PM Dave Page <dpage@pgadmin.org> wrote= :
Hi

On Thu, May 30, 2019 at 4:40 AM Aditya Toshniwal <= adit= ya.toshniwal@enterprisedb.com> wrote:
Hi,=C2=A0

On Thu, May 30, 2019 at = 1:38 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Tue, May 28, 2019 at 3:41 AM = Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi,

<= div class=3D"gmail_quote">
On Thu, May= 23, 2019 at 1:31 PM Dave Page <dpage@pgadmin.org> wrote:
Hi,

On further testing, this doesn't seem t= o be working as expected. Alt+Shift+] or [ in the query tool are typing=C2= =A0=E2=80=99 and =E2=80=9D and not changing the tab. If I switch to a non-i= nput tab (e.g. History), they still don't work.=C2=A0
=
I am not able to simulate the quotes problem, but I hav= e made a few corrections to fix the switching.
Attached is the= updated patch, kindly review.=C2=A0
<= div>
Alt+Shift+[ (or ]) don[t work at all for me now :-(
Did you restart the server after applying the pa= tch ?=C2=A0 What shortcut does preferences show ?=C2=A0
<= /div>

Yes, did that, rebuilt the bundle and= hard-reloaded the browser, all multiple times.

Th= e shortcut preferences show the expected keys.
=C2=A0
=C2=A0

Alt+Shift+Tab changes the panel succ= essfully though, and does cause the flash as expected.=C2=A0

=
I'm using Chrome=C2=A074.0.3729.131 on Mojave.

On Wed, May 22, 2019 at 6:53 AM Aditya Toshniwal <aditya.toshniwal@enter= prisedb.com> wrote:
H= i,

Attached is the updated patch with doc = changes.

On Tue, May 21, 2019 at 5:42 PM Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi,

<= div dir=3D"ltr" class=3D"gmail_attr">On Tue, May 21, 2019 at 5:32 PM Dave P= age <dpage@pgadmi= n.org> wrote:
Hi

On Tue, May 21, 2019 at 10:01 AM A= ditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Hi Hackers,

Attached is the patch to fix the accessibility issu= e in query tool.

The query tool can be comp= letely restructured unlike previously where query tool used to stick at top= and other tabs in the bottom.=C2=A0
- I have added a new shortcut to switch between frames if in q= uery tool the tab positions are changed. On switching the frames, the frame= will blink to show it is focussed.=C2=A0
- In the frame, you can switch tab same as previous. The = tabs in SQL editor are cyclic now, which means if you execute shortcut to g= o right on the last tab then it will cycle to first tab.
- I have also changed the default shortcut= to switch between tabs from Shift+Ctrl+ArrowKeys to Shift+Ctrl+[ and ] sim= ilar to what we have in browser tabs.
- Similar changes done for debugger also.

Shouldn't there be documentation changes to go= with this?=C2=A0
Yes, definitely :P<= /div>
Will send the updated patch.=C2=A0

Otherwise, it seems to work :-)

= --
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


--
Thanks = and Regards,
<= font size=3D"2" color=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshn= iwal
S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"


--
Thanks and Regards,
<= span style=3D"background-color:rgb(255,255,255)">Aditya Toshniwal
<= div>Software Engineer |=C2=A0E= nterpriseDB India |=C2=A0Pun= e
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com<= br>Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpri= se PostgreSQL Company


--
= Thanks and = Regards,
Aditya Toshniwal=
Softw= are Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Com= plain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterp= riseDB UK: http:/= /www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000820076058af566e8--