Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hieqL-0003Hy-00 for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 12:58:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hieqJ-00079p-SM for pgadmin-hackers@arkaria.postgresql.org; Wed, 03 Jul 2019 12:58:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hieqJ-00079C-5j for pgadmin-hackers@lists.postgresql.org; Wed, 03 Jul 2019 12:58:35 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hieqG-00048n-8S for pgadmin-hackers@postgresql.org; Wed, 03 Jul 2019 12:58:34 +0000 Received: by mail-wr1-x443.google.com with SMTP id u18so2731178wru.1 for ; Wed, 03 Jul 2019 05:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mj0LBZREINI6wD85y6cZ8fUVxMAhbX7GjgcDOh+gXIE=; b=k49JQc1QE8YgyRJBqXViSyu2lTm3uzOBZyankW7CoBX/0jO0NypSUkIUVBgTiqQlva 38DdwJGRF/DPwGJDrP479ouAPi3iw4Eo68NXdrDajF28Ar+jEN9v/aNs1HyXht+HkRwg lV+yXOxkH6vx07qpR6xw8TJYZDLaeXARBPzbpHX6ePSpew1p5MRmnvlKup3XcnPfJ5u5 ZtnG9QImPesmh1iL4nL6t+0OGm6XFlhXMCWIRK1xqz3nHQj0vF65sLBOceXFhWHvyrBY Nk57ZKumLhBWYeaupehjIEQwXp+HXX0pD7CFRprHHo+dsy5Kx8UAFqO60jja96o/gMUq 2qVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mj0LBZREINI6wD85y6cZ8fUVxMAhbX7GjgcDOh+gXIE=; b=M8/qH8IC8gSaeXQ+K0+fJsFy5qe4upRb+pLqyR1sytsQl1Bzz2ozEEeMYclLc3ul67 qVC72KEX9NmT3u2+LZYCM/TtF2xucr595RPcm2bNHZJr7BgItyyiRHARyi9vchBPBq1K N6DvesYZODA/TenCt6AcT59BPnmMxWFswodLmeQSIsjWrt9coBpUWibEqen2E/Pd7vRg 4iHf2SXkS0PZIrlmwZJIrnI2qgsfn975X4TdajQptqdud0E/eC1CH6L7lcAsyOstY5EX KpznuENQdtDosD8LUAMW8dnI1Cu5lEkYN5XVZpENLacVqVyHzUVxB7+f5Xy1nFBtthLG slQw== X-Gm-Message-State: APjAAAVl+/hiesBv2pUiKeflwrezkHGUJm991YUnXvupEXBtqeYfkgmD 2zY1GE6qMdRSk+XhyxaiNz7oDFluBV4C1xcWRpsk1A== X-Google-Smtp-Source: APXvYqx4PlYj9I3QxMN6gDY64469qQs3VI1B0BvHi6pTTRauJym4TwTPMwRIHHYen1qvEWCzeUJyNVV8CjWZxZ4j8VM= X-Received: by 2002:a05:6000:1285:: with SMTP id f5mr13792645wrx.315.1562158710665; Wed, 03 Jul 2019 05:58:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Page Date: Wed, 3 Jul 2019 13:58:17 +0100 Message-ID: Subject: Re: [pgAdmin][RM4335] Add EXPLAIN option SETTINGS and SUMMARY To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000084628058cc66b87" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000084628058cc66b87 Content-Type: text/plain; charset="UTF-8" Thanks, applied. On Tue, Jul 2, 2019 at 8:38 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The SUMMARY data will be visible on hover > over the top-right icon along JIT stats and Triggers (if any). > I'm not sure where does SETTINGS data come in plan output for PGv12. But > the query is executed with correct options if required. > Docs updated. > > Also, I have fixed a tooltip flickering issue with this patch (#4224) > > Kindly review. > > On Fri, Jun 28, 2019 at 10:15 PM Dave Page wrote: > >> Hi >> >> On Fri, Jun 28, 2019 at 9:27 AM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the updated patch to fix the review comments of trailing >>> mail. >>> Kindly review. >>> >> >> So where is the summary supposed to be displayed? It's now requesting it >> from the server, and it's in the JSON response, but isn't displayed >> anywhere that I can see. >> >> >>> >>> On Thu, Jun 27, 2019 at 4:49 PM Dave Page wrote: >>> >>>> Hi >>>> >>>> On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Wed, Jun 26, 2019 at 8:22 PM Dave Page wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> Something isn't working correctly - I turned on the summary option, >>>>>> and this is the query that was run when I hit the EXPLAIN button: >>>>>> >>>>>> EXPLAIN (FORMAT JSON,ANALYZE False,VERBOSE False,COSTS False,TIMING >>>>>> False,SUMMARY False,BUFFERS False) select * from pg_tables >>>>>> >>>>> >>>>>> Aside from the formatting (s/True/true, s/False/false, missing spaces >>>>>> etc), shouldn't it say SUMMARY true? I've cleared the browser and bundle >>>>>> caches, rebundled etc. >>>>>> >>>>> I think I misunderstood the documents - >>>>> https://www.postgresql.org/docs/12/sql-explain.html. Few of the >>>>> parameters are applicable only to EXPLAIN ANALYSE and not to EXPLAIN. Will >>>>> make the changes, along with formatting to existing codes as well. >>>>> >>>> >>>> I'm not sure that explains why the summary option is set to *false* for >>>> an EXPLAIN action, but anyway, please make sure it works :-) >>>> >>>> >>>>> >>>>>> Shouldn't there also be documentation updates? >>>>>> >>>>> Yeah. (I always miss that :/) >>>>> >>>>>> >>>>>> On Wed, Jun 26, 2019 at 7:59 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to add support for SETTINGS(v12+) and >>>>>>> SUMMARY(v10+) explain options. These options will be visible only if >>>>>>> version is supported. >>>>>>> >>>>>>> I have also created and fixed RM4395. The explain options changed on >>>>>>> one query tool should not change explain options on other query tools or >>>>>>> preferences. The initial values will be taken from preferences are usual. >>>>>>> >>>>>>> Kindly review. >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company --000000000000084628058cc66b87 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, applied.

On Tue, Jul 2, 2019 at 8:38 AM Aditya Tosh= niwal <aditya.toshn= iwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated p= atch. The SUMMARY data will be visible on hover over the top-right icon alo= ng JIT stats and Triggers (if any).
I'm not sure where does SETTINGS da= ta come in plan output for PGv12. But the query is executed with correct op= tions if required.
Docs updated.

Also, I have fixed a tooltip flickeri= ng issue with this patch (#4224)

Kindly review.

On Fri, Jun 28, 2= 019 at 10:15 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

=
On Fri, Ju= n 28, 2019 at 9:27 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the updated patch to fix the revie= w comments of trailing mail.
Kindly review.


On Thu, Jun 27, 2019 at 4:49 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 27, 2019 at 12:32 AM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
Hi,

On Wed, Jun 26, 2019 at 8:22 PM Dave Pa= ge <dpage@pgadmin= .org> wrote:
Hi

Something isn't working corr= ectly - I turned on the summary option, and this is the query that was run = when I hit the EXPLAIN button:

EXPLAIN (FORMAT JSO= N,ANALYZE False,VERBOSE False,COSTS False,TIMING False,SUMMARY False,BUFFER= S False) select * from pg_tables

Aside from the formatting (s/True/true, s/False/false, missing spaces= etc), shouldn't it say SUMMARY true? I've cleared the browser and = bundle caches, rebundled etc.
I think I misunderst= ood the documents -=C2=A0https://www.postgresql.org/docs/12/s= ql-explain.html. Few of the parameters are applicable only to EXPLAIN ANALY= SE and not to EXPLAIN. Will make the changes, along with formatting to exis= ting codes as well.=C2=A0

I'm not sure that explains why the summary option is set to *fa= lse* for an EXPLAIN action, but anyway, please make sure it works :-)
=
=C2=A0

Shouldn't there also be= documentation updates?
Yeah. (I always miss that = :/)=C2=A0
On Wed, J= un 26, 2019 at 7:59 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch = to add support for SETTINGS(v12+) and SUMMARY(v10+) explain options. These = options will be visible only if version is supported.

I have also created and fixed RM4395. The explain options change= d on one query tool should not change explain options on other query tools = or preferences. The initial values will be taken from preferences are usual= .

Kindly review.

-- <= br>
= Thanks and = Regards,
Aditya Toshniwal=
Softw= are Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company


--
Thanks an= d Regards,
Aditya Toshniw= al
S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"


--
Dave PageBlog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company


--
=
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0= Pune
"Don't C= omplain about Heat, Plant a TREE"
=


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company
=


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB I= ndia |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @p= gsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL = Company
--000000000000084628058cc66b87--