Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxXlB-0006aF-S9 for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 11:13:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bxXlB-0003L6-Ep for pgadmin-hackers@arkaria.postgresql.org; Fri, 21 Oct 2016 11:13:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bxXkx-0002zb-DC for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 11:12:59 +0000 Received: from mail-it0-x235.google.com ([2607:f8b0:4001:c0b::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bxXkq-0004n6-8U for pgadmin-hackers@postgresql.org; Fri, 21 Oct 2016 11:12:58 +0000 Received: by mail-it0-x235.google.com with SMTP id k64so48006902itb.0 for ; Fri, 21 Oct 2016 04:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Hl7rQq4+jvkh0os0VCTK7XGdgbtnPYZz/jJ3KeoDYuk=; b=iXYXf/hwUeo0umvq2JKSKq0dJO/pA63qQ44t+0ehHYBxkIBBRfGUlR8wJC2OqT16K4 5hO+H6QTD+WX3c90Prq5G9sLI39WdttghIpW0AKcUj95B6yN5ug6X3WHYpKS80yK3nhN Yu7NCuJo510mLnJPClwMLyWxsvezHTQU5FEBpJYwIPUbQkdMdHlYGfySe0Kxnijuo3B+ BbLOLyzvkFplpTfcU0xs0YjpwWU+NRAjJdTpjBz8o4wQm7KdMPoxuZVj8cKpsrsJluRj 2mrpt4glYHZqKdwuoSpOqikEqBsioNgbYPGFXP+DdlocZdz095h0sb5dp/L/kzNzKUUa XGNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Hl7rQq4+jvkh0os0VCTK7XGdgbtnPYZz/jJ3KeoDYuk=; b=kjyR4hw0rv8jUj2sQivzQUTyn0kqAsVukczYpZcLJ4xmrnvst9+oQEW35XKcf9gyPj zRs+aTp2ZF53OkblcapgPjw0v9m5hUJhi7yyhaI4BKAarA5Z+3zXrLT1Q3kauGZjqRe9 RmzIj7SzYQeDYdhzmEOSaeyhQvLVOrXVPC0JfZNcnUZkY/PSIDub1ja3oRG3TFH3z0y0 AfFJ6UdI/VJf8tjQuVcKYHJmhJ4EzKNkc3rVA2LRxlZ9hZ214Lm3BA1ztwLFTBCnTC/K gxD8Vds4ZAlYinhSgd3sMMTQ6U5Uq21JN5cVntjHQvBwBYM+JviN3D2MEVSrDWstifHl wJRA== X-Gm-Message-State: ABUngveEOYWJzypuBV9i3Yvly+SzKJLcn4eVNGaN1+clcKvgInvAoNML0gv/dI9Px/q7opQyexXBhROYt7gC0w== X-Received: by 10.107.12.206 with SMTP id 75mr301631iom.208.1477048371359; Fri, 21 Oct 2016 04:12:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.82.130 with HTTP; Fri, 21 Oct 2016 04:12:50 -0700 (PDT) In-Reply-To: References: From: Dave Page Date: Fri, 21 Oct 2016 12:12:50 +0100 Message-ID: Subject: Re: [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited To: Surinder Kumar Cc: pgadmin-hackers Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org Thanks, applied (and I dealt with the RM). On Thu, Oct 20, 2016 at 7:58 AM, Surinder Kumar wrote: > Hi, > > While fixing RM1840, I found when we add new index, it doesn't add under > right parent. i.e. columns collection. because wrong parent is given in > response. > I also verified other nodes. This issue is only with index node. > > Do, I need to create separate RM for this case. ? > > Please find attached minor patch and review. > > On Tue, Oct 18, 2016 at 4:03 PM, Dave Page wrote: >> >> Thanks - applied! >> >> On Mon, Oct 17, 2016 at 7:48 AM, Surinder Kumar >> wrote: >> > On Sun, Oct 16, 2016 at 7:29 AM, Dave Page wrote: >> >> >> >> Hi >> >> >> >> I just found a case where this patch is broken - if you update the >> >> comment >> >> on a type, it looks like it tried to lookup the schema ID using the >> >> type >> >> name, which a) isn't in the posted data so gives a 500 response, and b) >> >> wouldn't be safe anyway, if there were types with the same name in >> >> multiple >> >> schemas. >> > >> > I have fixed this issue. Now it will lookup the schema ID against the >> > type >> > id instead of type name. >> >> >> >> >> >> Actually, it looks like that's an issue when creating a type too - that >> >> is >> >> also using an unsafe schema lookup. >> >> >> >> Please fix this ASAP (i.e. Monday) and double check to ensure we're not >> >> doing any more unsafe lookups like this. >> > >> > It looks good to me in other nodes. >> > Please find attached patch and review. >> >> >> >> >> >> Thanks. >> >> >> >> >> >> On Friday, October 14, 2016, Dave Page wrote: >> >>> >> >>> Thanks, applied. >> >>> >> >>> On Friday, October 14, 2016, Surinder Kumar >> >>> wrote: >> >>>> >> >>>> Hi >> >>>> >> >>>> Following are the issues fixed in nodes: >> >>>> >> >>>> 1) If we create/update a node with non-default schema, It should >> >>>> return >> >>>> selected schema id in return response. but default schema id is >> >>>> returned >> >>>> every time due to which it throws error in properties panel. >> >>>> Fixed in Domains, Collation, Types, Views & Table node. >> >>>> >> >>>> 2) Incorrect parent id of object node is returned from nodes method >> >>>> due >> >>>> to which wrong parent id is passed while updating object and >> >>>> thus node didn't get refreshed. >> >>>> Fixed in FTS Configuration, FTS Parser nodes. >> >>>> >> >>>> Also, I have kept changes of first patch which are essential to >> >>>> refresh >> >>>> node every time. Without that patch nodes properties panel updates >> >>>> only >> >>>> sometimes. >> >>>> >> >>>> Please find attached patch. Please review and let me know for >> >>>> comments. >> >>>> >> >>>> Thanks >> >>>> Surinder Kumar >> >>>> >> >>>> >> >>>> >> >>>> On Fri, Sep 23, 2016 at 6:00 PM, Dave Page wrote: >> >>>>> >> >>>>> Umm, no it wasn't - sorry. >> >>>>> >> >>>>> I see the same issue with Types. Can you fix that, and check all >> >>>>> other >> >>>>> nodes as well please? >> >>>>> >> >>>>> Thanks. >> >>>>> >> >>>>> On Fri, Sep 23, 2016 at 1:29 PM, Dave Page >> >>>>> wrote: >> >>>>> > Thanks, applied. >> >>>>> > >> >>>>> > On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar >> >>>>> > wrote: >> >>>>> >> Hi, >> >>>>> >> >> >>>>> >> Please find updated patch with changes: >> >>>>> >> 1) On debugging through JS files, the issue was in synonym update >> >>>>> >> method >> >>>>> >> which wasn't returning node object. >> >>>>> >> 2) retrieving schema name in node.sql for creating node object in >> >>>>> >> update >> >>>>> >> method. >> >>>>> >> >> >>>>> >> Please review and let me know for comments. >> >>>>> >> >> >>>>> >> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page >> >>>>> >> wrote: >> >>>>> >>> >> >>>>> >>> Hi >> >>>>> >>> >> >>>>> >>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar >> >>>>> >>> wrote: >> >>>>> >>> > Hi >> >>>>> >>> > >> >>>>> >>> > Issue: >> >>>>> >>> > on updating node, we deselect and then again select the node >> >>>>> >>> > updated to >> >>>>> >>> > refresh the panel. but it needs some delay of few milliseconds >> >>>>> >>> > between >> >>>>> >>> > deselect and select to fix this issue. >> >>>>> >>> > >> >>>>> >>> > Please find attached patch and review. >> >>>>> >>> >> >>>>> >>> This does not resolve the issue for me. I tested using a synonym >> >>>>> >>> to >> >>>>> >>> a >> >>>>> >>> package on EPAS 9.5, by changing the target package name. >> >>>>> >>> >> >>>>> >>> >> >>>>> >>> -- >> >>>>> >>> Dave Page >> >>>>> >>> Blog: http://pgsnake.blogspot.com >> >>>>> >>> Twitter: @pgsnake >> >>>>> >>> >> >>>>> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>>> >>> The Enterprise PostgreSQL Company >> >>>>> >> >> >>>>> >> >> >>>>> > >> >>>>> > >> >>>>> > >> >>>>> > -- >> >>>>> > Dave Page >> >>>>> > Blog: http://pgsnake.blogspot.com >> >>>>> > Twitter: @pgsnake >> >>>>> > >> >>>>> > EnterpriseDB UK: http://www.enterprisedb.com >> >>>>> > The Enterprise PostgreSQL Company >> >>>>> >> >>>>> >> >>>>> >> >>>>> -- >> >>>>> Dave Page >> >>>>> Blog: http://pgsnake.blogspot.com >> >>>>> Twitter: @pgsnake >> >>>>> >> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >> >>>>> The Enterprise PostgreSQL Company >> >>>> >> >>>> >> >>> >> >>> >> >>> -- >> >>> Dave Page >> >>> Blog: http://pgsnake.blogspot.com >> >>> Twitter: @pgsnake >> >>> >> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company >> >>> >> >> >> >> >> >> -- >> >> Dave Page >> >> Blog: http://pgsnake.blogspot.com >> >> Twitter: @pgsnake >> >> >> >> EnterpriseDB UK: http://www.enterprisedb.com >> >> The Enterprise PostgreSQL Company >> >> >> > >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers